From 00be0b565c41a7569fd23aa940a2d2da7040d78b Mon Sep 17 00:00:00 2001 From: Dennis Guse Date: Sun, 26 Jul 2026 15:46:24 +0200 Subject: [PATCH] Cleanup: removed unused methods and constants. --- .../opentracks/util/EspressoUtils.java | 10 ++++------ .../data/statistics/ExtremityMonitor.java | 18 ------------------ .../ChooseActivityTypeDialogFragment.java | 4 ++-- .../exporter/HealthConnectUtils.java | 2 -- .../opentracks/sensors/GpsStatusManager.java | 2 -- .../FilterDialogFragment.java | 6 ------ .../dennisguse/opentracks/util/FileUtils.java | 4 ---- .../opentracks/util/IntentUtils.java | 2 -- 8 files changed, 6 insertions(+), 42 deletions(-) diff --git a/src/androidTest/java/de/dennisguse/opentracks/util/EspressoUtils.java b/src/androidTest/java/de/dennisguse/opentracks/util/EspressoUtils.java index 459c55148..c10651480 100644 --- a/src/androidTest/java/de/dennisguse/opentracks/util/EspressoUtils.java +++ b/src/androidTest/java/de/dennisguse/opentracks/util/EspressoUtils.java @@ -1,8 +1,8 @@ package de.dennisguse.opentracks.util; -import static org.hamcrest.Matchers.allOf; -import static androidx.test.espresso.matcher.ViewMatchers.isDisplayed; import static androidx.test.espresso.matcher.ViewMatchers.isAssignableFrom; +import static androidx.test.espresso.matcher.ViewMatchers.isDisplayed; +import static org.hamcrest.Matchers.allOf; import android.app.Activity; import android.os.SystemClock; @@ -14,11 +14,11 @@ import androidx.recyclerview.widget.RecyclerView; import androidx.test.espresso.PerformException; import androidx.test.espresso.UiController; import androidx.test.espresso.ViewAction; +import androidx.test.espresso.util.HumanReadables; +import androidx.test.espresso.util.TreeIterables; import androidx.test.platform.app.InstrumentationRegistry; import androidx.test.runner.lifecycle.ActivityLifecycleMonitorRegistry; import androidx.test.runner.lifecycle.Stage; -import androidx.test.espresso.util.HumanReadables; -import androidx.test.espresso.util.TreeIterables; import androidx.viewpager2.widget.ViewPager2; import com.google.android.material.tabs.TabLayout; @@ -33,8 +33,6 @@ import java.util.function.Predicate; public class EspressoUtils { - private static final long VIEW_POLLING_INTERVAL_MS = 50; - public static Matcher withRecyclerViewItemCount(final int count) { return new TypeSafeMatcher<>() { @Override diff --git a/src/main/java/de/dennisguse/opentracks/data/statistics/ExtremityMonitor.java b/src/main/java/de/dennisguse/opentracks/data/statistics/ExtremityMonitor.java index ac7147034..ade7a2785 100644 --- a/src/main/java/de/dennisguse/opentracks/data/statistics/ExtremityMonitor.java +++ b/src/main/java/de/dennisguse/opentracks/data/statistics/ExtremityMonitor.java @@ -50,15 +50,6 @@ public class ExtremityMonitor { return min; } - /** - * Sets the minimum value. - * - * @param min the minimum value - */ - public void setMin(double min) { - this.min = min; - } - /** * Gets the maximum value seen. */ @@ -66,15 +57,6 @@ public class ExtremityMonitor { return max; } - /** - * Sets the maximum value. - * - * @param max the maximum value - */ - public void setMax(double max) { - this.max = max; - } - /** * Updates the min and the max with a new value. * diff --git a/src/main/java/de/dennisguse/opentracks/fragments/ChooseActivityTypeDialogFragment.java b/src/main/java/de/dennisguse/opentracks/fragments/ChooseActivityTypeDialogFragment.java index e6967d633..84858768a 100644 --- a/src/main/java/de/dennisguse/opentracks/fragments/ChooseActivityTypeDialogFragment.java +++ b/src/main/java/de/dennisguse/opentracks/fragments/ChooseActivityTypeDialogFragment.java @@ -56,7 +56,7 @@ public class ChooseActivityTypeDialogFragment extends DialogFragment implements ActivityType.WORKOUT ); - private static int getPosition(Context context, ActivityType activityType) { + private static int getPosition(ActivityType activityType) { if (activityType == null) { return -1; } @@ -92,7 +92,7 @@ public class ChooseActivityTypeDialogFragment extends DialogFragment implements } final ChooseActivityTypeImageAdapter imageAdapter = new ChooseActivityTypeImageAdapter(iconDrawableIds); - int position = getPosition(getContext(), preselectedActivityType); + int position = getPosition(preselectedActivityType); if (position != -1) { imageAdapter.setSelected(position); } diff --git a/src/main/java/de/dennisguse/opentracks/io/healthconnect/exporter/HealthConnectUtils.java b/src/main/java/de/dennisguse/opentracks/io/healthconnect/exporter/HealthConnectUtils.java index 591a0070c..cc3998bf5 100644 --- a/src/main/java/de/dennisguse/opentracks/io/healthconnect/exporter/HealthConnectUtils.java +++ b/src/main/java/de/dennisguse/opentracks/io/healthconnect/exporter/HealthConnectUtils.java @@ -27,8 +27,6 @@ import kotlinx.coroutines.BuildersKt; */ public class HealthConnectUtils { - private static final String TAG = HealthConnectUtils.class.getSimpleName(); - static final String WRITE_EXERCISE_PERMISSION = HealthPermission.getWritePermission(JvmClassMappingKt.getKotlinClass(ExerciseSessionRecord.class)); static final String WRITE_EXERCISE_ROUTE_PERMISSION = HealthPermission.PERMISSION_WRITE_EXERCISE_ROUTE; diff --git a/src/main/java/de/dennisguse/opentracks/sensors/GpsStatusManager.java b/src/main/java/de/dennisguse/opentracks/sensors/GpsStatusManager.java index 5a5154d95..d82dbac81 100644 --- a/src/main/java/de/dennisguse/opentracks/sensors/GpsStatusManager.java +++ b/src/main/java/de/dennisguse/opentracks/sensors/GpsStatusManager.java @@ -20,8 +20,6 @@ import de.dennisguse.opentracks.settings.PreferencesUtils; */ class GpsStatusManager { - private static final String TAG = GpsStatusManager.class.getSimpleName(); - // The duration that GpsStatus waits from minimal interval to consider GPS lost. @VisibleForTesting public static final Duration SIGNAL_LOST_THRESHOLD = Duration.ofSeconds(30); diff --git a/src/main/java/de/dennisguse/opentracks/ui/aggregatedStatistics/FilterDialogFragment.java b/src/main/java/de/dennisguse/opentracks/ui/aggregatedStatistics/FilterDialogFragment.java index 5241e7c97..19d78072a 100644 --- a/src/main/java/de/dennisguse/opentracks/ui/aggregatedStatistics/FilterDialogFragment.java +++ b/src/main/java/de/dennisguse/opentracks/ui/aggregatedStatistics/FilterDialogFragment.java @@ -136,12 +136,6 @@ public class FilterDialogFragment extends DialogFragment { public final String value; public boolean isChecked; - public FilterItem(String id, String value) { - this.id = id; - this.value = value; - this.isChecked = true; - } - public FilterItem(String id, String value, boolean isChecked) { this.id = id; this.value = value; diff --git a/src/main/java/de/dennisguse/opentracks/util/FileUtils.java b/src/main/java/de/dennisguse/opentracks/util/FileUtils.java index 40f9e966d..b18272129 100644 --- a/src/main/java/de/dennisguse/opentracks/util/FileUtils.java +++ b/src/main/java/de/dennisguse/opentracks/util/FileUtils.java @@ -104,10 +104,6 @@ public class FileUtils { return fileName.substring(index + 1); } - public static String getExtension(DocumentFile file) { - return getExtension(file.getName()); - } - public static String getExtension(Uri uri) { return getExtension(uri.toString()); } diff --git a/src/main/java/de/dennisguse/opentracks/util/IntentUtils.java b/src/main/java/de/dennisguse/opentracks/util/IntentUtils.java index f0468c62d..0e6cf9d0f 100644 --- a/src/main/java/de/dennisguse/opentracks/util/IntentUtils.java +++ b/src/main/java/de/dennisguse/opentracks/util/IntentUtils.java @@ -36,8 +36,6 @@ public class IntentUtils { private static final String TAG = IntentUtils.class.getSimpleName(); - private static final String JPEG_EXTENSION = "jpeg"; - private IntentUtils() { }