diff --git a/src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java b/src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java index 0b0cfd3b0..c4bd431eb 100644 --- a/src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java +++ b/src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java @@ -255,7 +255,7 @@ public class ContentProviderUtils { * @param selectionArgs the selection arguments. Can be null * @param sortOrder the sort order. Can be null */ - public Cursor getTrackCursor(String selection, String[] selectionArgs, String sortOrder) { + Cursor getTrackCursor(String selection, String[] selectionArgs, String sortOrder) { return contentResolver.query(TracksColumns.CONTENT_URI, null, selection, selectionArgs, sortOrder); } @@ -322,6 +322,7 @@ public class ContentProviderUtils { return values; } + //TODO Align with fillTrackPoint public Marker createMarker(Cursor cursor) { int idIndex = cursor.getColumnIndexOrThrow(MarkerColumns._ID); int nameIndex = cursor.getColumnIndexOrThrow(MarkerColumns.NAME); @@ -430,6 +431,10 @@ public class ContentProviderUtils { return null; } + public Cursor getMarkerCursor(@NonNull Track.Id trackId) { + return getMarkerCursor(trackId, -1); + } + /** * The caller owns the returned cursor and is responsible for closing it. * @@ -450,7 +455,7 @@ public class ContentProviderUtils { @VisibleForTesting public List getMarkers(Track.Id trackId) { ArrayList markers = new ArrayList<>(); - try (Cursor cursor = getMarkerCursor(trackId, -1)) { + try (Cursor cursor = getMarkerCursor(trackId)) { if (cursor.moveToFirst()) { do { markers.add(createMarker(cursor)); diff --git a/src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java b/src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java index c74a2a7db..817ba0fce 100644 --- a/src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java +++ b/src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java @@ -238,7 +238,7 @@ public class GPXTrackExporter implements TrackExporter { } private void writeMarkers(Track track) throws InterruptedException { - try (Cursor cursor = contentProviderUtils.getMarkerCursor(track.getId(), -1)) { + try (Cursor cursor = contentProviderUtils.getMarkerCursor(track.getId())) { if (cursor != null && cursor.moveToFirst()) { for (int i = 0; i < cursor.getCount(); i++) { if (Thread.interrupted()) { diff --git a/src/main/java/de/dennisguse/opentracks/io/file/exporter/KMLTrackExporter.java b/src/main/java/de/dennisguse/opentracks/io/file/exporter/KMLTrackExporter.java index df48289e7..68b912d98 100644 --- a/src/main/java/de/dennisguse/opentracks/io/file/exporter/KMLTrackExporter.java +++ b/src/main/java/de/dennisguse/opentracks/io/file/exporter/KMLTrackExporter.java @@ -136,7 +136,7 @@ public class KMLTrackExporter implements TrackExporter { private void writeMarkers(Track track) throws InterruptedException { boolean hasMarkers = false; - try (Cursor cursor = contentProviderUtils.getMarkerCursor(track.getId(), -1)) { + try (Cursor cursor = contentProviderUtils.getMarkerCursor(track.getId())) { if (cursor != null && cursor.moveToFirst()) { for (int i = 0; i < cursor.getCount(); i++) { if (Thread.interrupted()) { diff --git a/src/main/java/de/dennisguse/opentracks/io/file/exporter/KMZTrackExporter.java b/src/main/java/de/dennisguse/opentracks/io/file/exporter/KMZTrackExporter.java index debe6800d..10f7798f4 100644 --- a/src/main/java/de/dennisguse/opentracks/io/file/exporter/KMZTrackExporter.java +++ b/src/main/java/de/dennisguse/opentracks/io/file/exporter/KMZTrackExporter.java @@ -89,7 +89,7 @@ public class KMZTrackExporter implements TrackExporter { private void addImages(Context context, List tracks, ZipOutputStream zipOutputStream) throws InterruptedException, IOException { for (Track track : tracks) { - try (Cursor cursor = contentProviderUtils.getMarkerCursor(track.getId(), -1)) { + try (Cursor cursor = contentProviderUtils.getMarkerCursor(track.getId())) { if (cursor != null && cursor.moveToFirst()) { for (int i = 0; i < cursor.getCount(); i++) { if (Thread.interrupted()) { diff --git a/src/main/java/de/dennisguse/opentracks/io/file/importer/KMZTrackImporter.java b/src/main/java/de/dennisguse/opentracks/io/file/importer/KMZTrackImporter.java index 28363a0d5..78bde1bc9 100644 --- a/src/main/java/de/dennisguse/opentracks/io/file/importer/KMZTrackImporter.java +++ b/src/main/java/de/dennisguse/opentracks/io/file/importer/KMZTrackImporter.java @@ -17,6 +17,7 @@ package de.dennisguse.opentracks.io.file.importer; import android.content.Context; +import android.database.Cursor; import android.net.Uri; import android.os.Build; import android.util.Log; diff --git a/src/main/java/de/dennisguse/opentracks/ui/markers/MarkerDetailActivity.java b/src/main/java/de/dennisguse/opentracks/ui/markers/MarkerDetailActivity.java index d281b8b66..eb9c365a6 100644 --- a/src/main/java/de/dennisguse/opentracks/ui/markers/MarkerDetailActivity.java +++ b/src/main/java/de/dennisguse/opentracks/ui/markers/MarkerDetailActivity.java @@ -68,7 +68,7 @@ public class MarkerDetailActivity extends AbstractActivity implements DeleteMark Marker marker = contentProviderUtils.getMarker(markerId); //TODO only load used data: ID + name - cursor = contentProviderUtils.getMarkerCursor(marker.getTrackId(), -1); + cursor = contentProviderUtils.getMarkerCursor(marker.getTrackId()); if (cursor == null) { finish(); }