Cleanup.

src/main/java/de/dennisguse/opentracks/fragments/ChartDistanceFragment.java

@@ -2,8 +2,6 @@ package de.dennisguse.opentracks.fragments;
 
 public class ChartDistanceFragment extends ChartFragment {
 
-    public static final String CHART_FRAGMENT_TAG = ChartDistanceFragment.class.getSimpleName();
-
     public ChartDistanceFragment() {
         super(true);
     }

src/main/java/de/dennisguse/opentracks/fragments/ChartFragment.java

@@ -73,7 +73,7 @@ public abstract class ChartFragment extends Fragment implements TrackDataListene
 
     // Modes of operation
     private boolean chartByDistance;
-    private boolean[] chartShow = new boolean[]{true, true, true, true, true, true};
+    private final boolean[] chartShow = new boolean[]{true, true, true, true, true, true};
 
     // UI elements
     private ChartView chartView;

src/main/java/de/dennisguse/opentracks/fragments/ChartTimeFragment.java

@@ -2,8 +2,6 @@ package de.dennisguse.opentracks.fragments;
 
 public class ChartTimeFragment extends ChartFragment {
 
-    public static final String CHART_FRAGMENT_TAG = ChartTimeFragment.class.getSimpleName();
-
     public ChartTimeFragment() {
         super(false);
     }

src/main/java/de/dennisguse/opentracks/fragments/ChooseActivityTypeDialogFragment.java

@@ -39,7 +39,7 @@ public class ChooseActivityTypeDialogFragment extends DialogFragment implements
         return TrackIconUtils.getAllIconValues().indexOf(iconValue);
     }
 
-    private String preselectedCategory;
+    private final String preselectedCategory;
 
     private ChooseActivityTypeCaller chooseActivityTypeCaller;
 
@@ -71,7 +71,6 @@ public class ChooseActivityTypeDialogFragment extends DialogFragment implements
         int position = getPosition(getContext(), preselectedCategory);
         if (position != -1) {
             imageAdapter.setSelected(position);
-            imageAdapter.notifyDataSetChanged();
         }
 
         gridView.setOnItemClickListener(this);

src/main/java/de/dennisguse/opentracks/fragments/ChooseActivityTypeImageAdapter.java

@@ -56,12 +56,9 @@ public class ChooseActivityTypeImageAdapter extends BaseAdapter {
         return 0;
     }
 
-    public int getSelected() {
-        return selected;
-    }
-
     public void setSelected(int position) {
         selected = position;
+        notifyDataSetChanged();
     }
 
     @Override

src/main/java/de/dennisguse/opentracks/fragments/ConfirmDeleteDialogFragment.java

@@ -37,7 +37,7 @@ public class ConfirmDeleteDialogFragment extends DialogFragment {
 
     private static final String CONFIRM_DELETE_DIALOG_TAG = "confirmDeleteDialog";
     private ConfirmDeleteCaller caller;
-    private long[] trackIds;
+    private final long[] trackIds;
 
     public ConfirmDeleteDialogFragment(long[] trackIds) {
         this.trackIds = trackIds;

src/main/java/de/dennisguse/opentracks/fragments/DeleteMarkerDialogFragment.java

@@ -38,7 +38,7 @@ import de.dennisguse.opentracks.util.DialogUtils;
 public class DeleteMarkerDialogFragment extends DialogFragment {
 
     private static final String DELETE_MARKER_DIALOG_TAG = "deleteMarkerDialog";
-    private long[] markerIds;
+    private final long[] markerIds;
 
     private DeleteMarkerCaller caller;
 
@@ -82,7 +82,7 @@ public class DeleteMarkerDialogFragment extends DialogFragment {
                             public void run() {
                                 ContentProviderUtils contentProviderUtils = new ContentProviderUtils(fragmentActivity);
                                 for (long markerId : markerIds) {
-                                    contentProviderUtils.deleteWaypoint(fragmentActivity, markerId);
+                                    contentProviderUtils.deleteWaypoint(markerId);
                                 }
                                 caller.onDeleteMarkerDone();
                             }

src/main/java/de/dennisguse/opentracks/fragments/FileTypeDialogFragment.java

@@ -40,10 +40,10 @@ import de.dennisguse.opentracks.io.file.TrackFileFormat;
 public class FileTypeDialogFragment extends DialogFragment {
 
     private static final String FILE_TYPE_DIALOG_TAG = "fileType";
-    private int titleId;
+    private final int titleId;
 
     private FileTypeCaller caller;
-    private int optionId;
+    private final int optionId;
 
     public FileTypeDialogFragment(int titleId, int optionId) {
         this.titleId = titleId;

src/main/java/de/dennisguse/opentracks/fragments/MarkerDetailFragment.java

@@ -64,7 +64,7 @@ public class MarkerDetailFragment extends Fragment {
     private ImageView textGradient;
     private LinearLayout waypointInfo;
     private Waypoint waypoint;
-    private Runnable hideText = new Runnable() {
+    private final Runnable hideText = new Runnable() {
         @Override
         public void run() {
             Animation animation = AnimationUtils.loadAnimation(getActivity(), R.anim.fadeout);
@@ -219,7 +219,7 @@ public class MarkerDetailFragment extends Fragment {
             photoView.setImageResource(MarkerUtils.ICON_ID);
         }
 
-        setName(R.id.marker_detail_waypoint_name, hasPhoto);
+        setName(hasPhoto);
 
         TextView category = getView().findViewById(R.id.marker_detail_waypoint_category);
         ListItemUtils.setTextView(getActivity(), category, StringUtils.getCategory(waypoint.getCategory()), hasPhoto);
@@ -227,16 +227,16 @@ public class MarkerDetailFragment extends Fragment {
         TextView description = getView().findViewById(R.id.marker_detail_waypoint_description);
         ListItemUtils.setTextView(getActivity(), description, waypoint.getDescription(), hasPhoto);
 
-        setLocation(R.id.marker_detail_waypoint_location, hasPhoto);
+        setLocation(hasPhoto);
     }
 
-    private void setName(int resId, boolean addShadow) {
-        TextView textView = getView().findViewById(resId);
+    private void setName(boolean addShadow) {
+        TextView textView = getView().findViewById(R.id.marker_detail_waypoint_name);
         ListItemUtils.setTextView(getActivity(), textView, waypoint.getName(), addShadow);
     }
 
-    private void setLocation(int resId, boolean addShadow) {
-        TextView textView = getView().findViewById(resId);
+    private void setLocation(boolean addShadow) {
+        TextView textView = getView().findViewById(R.id.marker_detail_waypoint_location);
         Location location = waypoint.getLocation();
         String value;
         if (location == null) {