Performance: Keep reference to sharedPreferences.

So far, we opened the SharedPreferences very often, which is very slow; also happened in the UI thread a lot.

Fixes #642.

src/main/java/de/dennisguse/opentracks/services/handlers/GpsStatus.java

@@ -1,6 +1,7 @@
 package de.dennisguse.opentracks.services.handlers;
 
 import android.content.Context;
+import android.content.SharedPreferences;
 import android.location.LocationManager;
 import android.os.Handler;
 
@@ -15,6 +16,7 @@ import de.dennisguse.opentracks.util.PreferencesUtils;
 /**
  * This class handle GPS status according to received locations and some thresholds.
  */
+//TODO should handle sharedpreference changes
 class GpsStatus {
 
     private static final String TAG = GpsStatus.class.getSimpleName();
@@ -60,16 +62,16 @@ class GpsStatus {
     private final Handler gpsStatusHandler;
     private GpsStatusRunner gpsStatusRunner = null;
 
-    /**
-     * @param context              The context object.
-     * @param client               The client.
-     * @param minRecordingInterval Value of min recording interval preference.
-     */
-    public GpsStatus(Context context, GpsStatusListener client, Duration minRecordingInterval) {
+    public GpsStatus(Context context, GpsStatusListener client) {
         this.client = client;
         this.context = context;
-        signalBadThreshold = PreferencesUtils.getRecordingDistanceInterval(context);
+
+        SharedPreferences sharedPreferences = PreferencesUtils.getSharedPreferences(context);
+        signalBadThreshold = PreferencesUtils.getRecordingDistanceInterval(sharedPreferences, context);
+
+        Duration minRecordingInterval = Duration.ofSeconds(PreferencesUtils.getMinRecordingInterval(sharedPreferences, context));
         signalLostThreshold = !minRecordingInterval.isNegative() ? SIGNAL_LOST_THRESHOLD.plus(minRecordingInterval) : SIGNAL_LOST_THRESHOLD;
+
         gpsStatusHandler = new Handler();
     }
 

src/main/java/de/dennisguse/opentracks/services/handlers/HandlerServer.java

@@ -3,12 +3,14 @@ package de.dennisguse.opentracks.services.handlers;
 import android.content.Context;
 import android.content.SharedPreferences;
 
+import androidx.annotation.NonNull;
 import androidx.annotation.VisibleForTesting;
 
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 
 import de.dennisguse.opentracks.content.data.TrackPoint;
+import de.dennisguse.opentracks.util.PreferencesUtils;
 
 public class HandlerServer {
 
@@ -32,8 +34,9 @@ public class HandlerServer {
     public void start(Context context) {
         serviceExecutor = Executors.newSingleThreadExecutor();
 
+        SharedPreferences sharedPreferences = PreferencesUtils.getSharedPreferences(context);
         locationHandler.onStart(context);
-        locationHandler.onSharedPreferenceChanged(context, null, null);
+        locationHandler.onSharedPreferenceChanged(context, sharedPreferences, null);
     }
 
     public void stop(Context context) {
@@ -45,7 +48,7 @@ public class HandlerServer {
         serviceExecutor = null;
     }
 
-    public void onSharedPreferenceChanged(Context context, SharedPreferences preferences, String key) {
+    public void onSharedPreferenceChanged(@NonNull Context context, @NonNull SharedPreferences preferences, String key) {
         locationHandler.onSharedPreferenceChanged(context, preferences, key);
     }
 
@@ -70,8 +73,10 @@ public class HandlerServer {
     }
 
     public interface Handler {
-        void onStart(Context context);
-        void onStop(Context context);
-        void onSharedPreferenceChanged(Context context, SharedPreferences preferences, String key);
+        void onStart(@NonNull Context context);
+
+        void onStop(@NonNull Context context);
+
+        void onSharedPreferenceChanged(@NonNull Context context, @NonNull SharedPreferences preferences, String key);
     }
 }

src/main/java/de/dennisguse/opentracks/services/handlers/LocationHandler.java

@@ -34,14 +34,14 @@ class LocationHandler implements HandlerServer.Handler, LocationListener, GpsSta
     }
 
     @Override
-    public void onStart(Context context) {
-        gpsStatus = new GpsStatus(context, this, Duration.ofSeconds(PreferencesUtils.getMinRecordingInterval(context)));
+    public void onStart(@NonNull Context context) {
+        gpsStatus = new GpsStatus(context, this);
         locationManager = (LocationManager) context.getSystemService(Context.LOCATION_SERVICE);
         registerLocationListener();
     }
 
     @Override
-    public void onStop(Context context) {
+    public void onStop(@NonNull Context context) {
         unregisterLocationListener();
         locationManager = null;
         if (gpsStatus != null) {
@@ -51,9 +51,9 @@ class LocationHandler implements HandlerServer.Handler, LocationListener, GpsSta
     }
 
     @Override
-    public void onSharedPreferenceChanged(Context context, SharedPreferences preferences, String key) {
+    public void onSharedPreferenceChanged(@NonNull Context context, @NonNull SharedPreferences sharedPreferences, String key) {
         if (PreferencesUtils.isKey(context, R.string.min_recording_interval_key, key)) {
-            int minRecordingInterval = PreferencesUtils.getMinRecordingInterval(context);
+            int minRecordingInterval = PreferencesUtils.getMinRecordingInterval(sharedPreferences, context);
             if (minRecordingInterval == PreferencesUtils.getMinRecordingIntervalAdaptBatteryLife(context)) {
                 // Choose battery life over moving time accuracy.
                 locationListenerPolicy = new AdaptiveLocationListenerPolicy(Duration.ofSeconds(30), Duration.ofSeconds(5), 5);
@@ -69,16 +69,16 @@ class LocationHandler implements HandlerServer.Handler, LocationListener, GpsSta
             }
         }
         if (PreferencesUtils.isKey(context, R.string.recording_gps_accuracy_key, key)) {
-            recordingGpsAccuracy = PreferencesUtils.getRecordingGPSAccuracy(context);
+            recordingGpsAccuracy = PreferencesUtils.getRecordingGPSAccuracy(sharedPreferences, context);
         }
         if (PreferencesUtils.isKey(context, R.string.min_recording_interval_key, key)) {
             if (gpsStatus != null) {
-                gpsStatus.onMinRecordingIntervalChanged(PreferencesUtils.getMinRecordingInterval(context));
+                gpsStatus.onMinRecordingIntervalChanged(PreferencesUtils.getMinRecordingInterval(sharedPreferences, context));
             }
         }
         if (PreferencesUtils.isKey(context, R.string.recording_distance_interval_key, key)) {
             if (gpsStatus != null) {
-                gpsStatus.onRecordingDistanceChanged(PreferencesUtils.getRecordingDistanceInterval(context));
+                gpsStatus.onRecordingDistanceChanged(PreferencesUtils.getRecordingDistanceInterval(sharedPreferences, context));
             }
         }
     }