Code cleanup, in MyTracksLocationManager, use the same handler for content observer

This commit is contained in:
Jimmy Shih
2013-06-14 10:14:24 -07:00
parent 33b4b62ad0
commit 1d6710e30e
@@ -51,8 +51,8 @@ public class MyTracksLocationManager {
*/ */
private class GoogleSettingsObserver extends ContentObserver { private class GoogleSettingsObserver extends ContentObserver {
public GoogleSettingsObserver() { public GoogleSettingsObserver(Handler handler) {
super(new Handler()); super(handler);
} }
@Override @Override
@@ -91,7 +91,8 @@ public class MyTracksLocationManager {
LocationRequest.PRIORITY_HIGH_ACCURACY).setInterval(requestLocationUpdatesTime) LocationRequest.PRIORITY_HIGH_ACCURACY).setInterval(requestLocationUpdatesTime)
.setFastestInterval(requestLocationUpdatesTime) .setFastestInterval(requestLocationUpdatesTime)
.setSmallestDisplacement(requestLocationUpdatesDistance); .setSmallestDisplacement(requestLocationUpdatesDistance);
locationClient.requestLocationUpdates(locationRequest, requestLocationUpdates, looper); locationClient.requestLocationUpdates(
locationRequest, requestLocationUpdates, handler.getLooper());
} }
} }
}); });
@@ -104,7 +105,6 @@ public class MyTracksLocationManager {
public void onConnectionFailed(ConnectionResult connectionResult) {} public void onConnectionFailed(ConnectionResult connectionResult) {}
}; };
private final Looper looper;
private final Handler handler; private final Handler handler;
private final LocationClient locationClient; private final LocationClient locationClient;
private final LocationManager locationManager; private final LocationManager locationManager;
@@ -119,8 +119,7 @@ public class MyTracksLocationManager {
private long requestLocationUpdatesTime; private long requestLocationUpdatesTime;
public MyTracksLocationManager(Context context, Looper looper, boolean enableLocaitonClient) { public MyTracksLocationManager(Context context, Looper looper, boolean enableLocaitonClient) {
this.looper = looper; this.handler = new Handler(looper);
handler = new Handler(looper);
if (enableLocaitonClient) { if (enableLocaitonClient) {
locationClient = new LocationClient(context, connectionCallbacks, onConnectionFailedListener); locationClient = new LocationClient(context, connectionCallbacks, onConnectionFailedListener);
@@ -131,7 +130,7 @@ public class MyTracksLocationManager {
locationManager = (LocationManager) context.getSystemService(Context.LOCATION_SERVICE); locationManager = (LocationManager) context.getSystemService(Context.LOCATION_SERVICE);
contentResolver = context.getContentResolver(); contentResolver = context.getContentResolver();
observer = new GoogleSettingsObserver(); observer = new GoogleSettingsObserver(handler);
isAvailable = GoogleLocationUtils.isAvailable(context); isAvailable = GoogleLocationUtils.isAvailable(context);
isAllowed = isUseLocationForServicesOn(); isAllowed = isUseLocationForServicesOn();