Cleanup using AndroidStudio analyze.

src/androidTest/java/de/dennisguse/opentracks/services/TrackRecordingServiceTestStateMachine.java

@@ -195,7 +195,7 @@ public class TrackRecordingServiceTestStateMachine {
 
     @MediumTest
     @Test
-    public void cannotResume_non_existing_track() throws InterruptedException {
+    public void cannotResume_non_existing_track() {
         // given
         assertFalse(service.isRecording());
         assertEquals(TrackRecordingService.STATUS_DEFAULT, service.getRecordingStatusObservable().getValue());

src/androidTest/java/de/dennisguse/opentracks/stats/TrackStatisticsUpdaterTest.java

@@ -78,7 +78,7 @@ public class TrackStatisticsUpdaterTest {
 
         // when
         TrackStatisticsUpdater subject = new TrackStatisticsUpdater();
-        data.trackPoints.forEach(it -> subject.addTrackPoint(it));
+        data.trackPoints.forEach(subject::addTrackPoint);
 
         // then
         TrackStatistics statistics = subject.getTrackStatistics();

src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java

@@ -146,9 +146,7 @@ public class TrackRecordingActivity extends AbstractActivity implements ChooseAc
             finish();
             return true;
         });
-        viewBinding.trackRecordingFabAction.setOnClickListener((view) -> {
+        viewBinding.trackRecordingFabAction.setOnClickListener((view) -> Toast.makeText(TrackRecordingActivity.this, getString(R.string.hold_to_stop), Toast.LENGTH_LONG).show());
-            Toast.makeText(TrackRecordingActivity.this, getString(R.string.hold_to_stop), Toast.LENGTH_LONG).show();
-        });
 
         viewBinding.bottomAppBar.setNavigationIcon(R.drawable.ic_baseline_arrow_back_24);
         setSupportActionBar(viewBinding.bottomAppBar);

src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordingFragment.java

@@ -77,10 +77,8 @@ public class StatisticsRecordingFragment extends Fragment {
         }
     };
 
-    private final TrackRecordingServiceConnection.Callback bindChangedCallback = (service, unused) -> {
+    private final TrackRecordingServiceConnection.Callback bindChangedCallback = (service, unused) -> service.getRecordingDataObservable()
-        service.getRecordingDataObservable()
+            .observe(StatisticsRecordingFragment.this, this::onRecordingDataChanged);
-                .observe(StatisticsRecordingFragment.this, this::onRecordingDataChanged);
-    };
 
     @Override
     public void onCreate(@Nullable Bundle savedInstanceState) {

src/main/java/de/dennisguse/opentracks/introduction/IntroductionActivity.java

@@ -62,8 +62,8 @@ public class IntroductionActivity extends AbstractActivity {
     private static class CustomFragmentPagerAdapter extends FragmentStateAdapter {
 
         private static final List<FragmentCreator> fragmentCreators = List.of(
-                (FragmentCreator) WelcomeFragment::newInstance,
+                WelcomeFragment::newInstance,
-                (FragmentCreator) OSMDashboardFragment::newInstance
+                OSMDashboardFragment::newInstance
         );
 
         public CustomFragmentPagerAdapter(@NonNull FragmentActivity fa) {

src/main/java/de/dennisguse/opentracks/settings/ImportExportSettingsFragment.java

@@ -73,9 +73,7 @@ public class ImportExportSettingsFragment extends PreferenceFragmentCompat {
 
     private void setFilenameTemplate() {
         EditTextPreference preference = findPreference(getString(R.string.export_filename_format_key));
-        preference.setOnBindEditTextListener(t -> {
+        preference.setOnBindEditTextListener(t -> t.setHint(getString(R.string.export_filename_format_default)));
-            t.setHint(getString(R.string.export_filename_format_default));
-        });
         preference.setDialogMessage(TrackFilenameGenerator.getAllOptions());
 
         preference.setOnPreferenceChangeListener((p, newValue) -> new TrackFilenameGenerator(newValue.toString()).isValid());

src/main/java/de/dennisguse/opentracks/ui/intervals/IntervalStatisticsModel.java

@@ -131,7 +131,7 @@ public class IntervalStatisticsModel extends AndroidViewModel {
         OPTION_20(20),
         OPTION_50(50);
 
-        static IntervalOption DEFAULT = OPTION_1;
+        static final IntervalOption DEFAULT = OPTION_1;
 
         private final double multiplier;