Hide activityTypeLabel in statistic summary.

.idea/misc.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
-  <component name="ProjectRootManager" version="2" languageLevel="JDK_1_7" project-jdk-name="1.8" project-jdk-type="JavaSDK">
+  <component name="ProjectRootManager" version="2" languageLevel="JDK_1_8" project-jdk-name="1.8" project-jdk-type="JavaSDK">
     <output url="file://$PROJECT_DIR$/build/classes" />
   </component>
   <component name="ProjectType">

src/main/java/de/dennisguse/opentracks/TrackDetailActivity.java

@@ -41,6 +41,10 @@ import androidx.core.app.TaskStackBuilder;
 import androidx.core.content.FileProvider;
 import androidx.viewpager.widget.ViewPager;
 
+import java.io.File;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+
 import de.dennisguse.opentracks.content.ContentProviderUtils;
 import de.dennisguse.opentracks.content.Track;
 import de.dennisguse.opentracks.content.TrackDataHub;
@@ -63,10 +67,6 @@ import de.dennisguse.opentracks.util.TrackIconUtils;
 import de.dennisguse.opentracks.util.TrackRecordingServiceConnectionUtils;
 import de.dennisguse.opentracks.util.TrackUtils;
 
-import java.io.File;
-import java.text.SimpleDateFormat;
-import java.util.Date;
-
 /**
  * An activity to show the track detail.
  *
@@ -392,13 +392,11 @@ public class TrackDetailActivity extends AbstractTrackActivity implements Choose
         String fileName = SimpleDateFormat.getDateTimeInstance().format(new Date());
         File file = new File(dir, FileUtils.buildUniqueFileName(dir, fileName, JPEG_EXTENSION));
 
-        if (file != null) {
+        photoUri = FileProvider.getUriForFile(this, FileUtils.FILEPROVIDER, file);
-            photoUri = FileProvider.getUriForFile(this, FileUtils.FILEPROVIDER, file);
+        Log.d(TAG, "Taking photo to URI: " + photoUri);
-            Log.d(TAG, "Taking photo to URI: " + photoUri);
+        Intent intent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE)
-            Intent intent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE)
+                .putExtra(MediaStore.EXTRA_OUTPUT, photoUri);
-                    .putExtra(MediaStore.EXTRA_OUTPUT, photoUri);
+        startActivityForResult(intent, CAMERA_REQUEST_CODE);
-            startActivityForResult(intent, CAMERA_REQUEST_CODE);
-        }
     }
 
     @Override

src/main/java/de/dennisguse/opentracks/io/file/exporter/SaveActivity.java

@@ -82,8 +82,7 @@ public class SaveActivity extends Activity {
             return;
         }
 
-        File directory = playTrack ? new File(getCacheDir(), FileUtils.PLAY_TRACKS_DIR)
+        File directory = playTrack ? new File(getCacheDir(), FileUtils.PLAY_TRACKS_DIR) : new File(FileUtils.getPath(trackFileFormat.getExtension()));
-                : new File(FileUtils.getPath(trackFileFormat.getExtension()));
         if (!FileUtils.ensureDirectoryExists(directory)) {
             Toast.makeText(this, R.string.external_storage_not_writable, Toast.LENGTH_LONG).show();
             finish();
@@ -96,8 +95,7 @@ public class SaveActivity extends Activity {
             }
         }
 
-        directoryDisplayName = playTrack ? directory.getName()
+        directoryDisplayName = playTrack ? directory.getName() : FileUtils.getPathDisplayName(trackFileFormat.getExtension());
-                : FileUtils.getPathDisplayName(trackFileFormat.getExtension());
 
         Object retained = getLastNonConfigurationInstance();
         if (retained instanceof SaveAsyncTask) {

src/main/java/de/dennisguse/opentracks/util/StatsUtils.java

@@ -143,6 +143,8 @@ public class StatsUtils {
         setDistanceValue(context, getView(activity, view, R.id.stats_distance), totalDistance, metricUnits);
 
         // Set activity type
+        getView(activity, null, R.id.stats_activity_type_label).setVisibility(trackIconValue != null ? View.VISIBLE : View.GONE);
+
         Spinner spinner = (Spinner) getView(activity, view, R.id.stats_activity_type_icon);
         spinner.setVisibility(trackIconValue != null ? View.VISIBLE : View.GONE);
         if (trackIconValue != null) {

src/main/res/layout/stats_activity_type.xml

@@ -17,7 +17,7 @@ limitations under the License.
     style="@style/StatsLargeItemContainer">
     <!-- Label -->
     <TextView
-        android:id="@+id/stats_label"
+        android:id="@+id/stats_activity_type_label"
         style="@style/StatsLargeLabel"
         android:text="@string/track_edit_activity_type_hint" />
     <!-- Value container -->

src/main/res/layout/stats_content.xml

@@ -24,7 +24,7 @@ limitations under the License.
             layout="@layout/stats_large_item" />
 
         <include
-            android:id="@+id/stats_calorie"
+            android:id="@+id/stats_activity_type"
             layout="@layout/stats_activity_type" />
     </LinearLayout>
     <!-- Total time and moving time -->