From 3c4a921f9a3dd7964169e213f4c976aa4fe1b855 Mon Sep 17 00:00:00 2001 From: Rodrigo Damazio Date: Mon, 1 Nov 2010 05:27:04 -0200 Subject: [PATCH] Addressing review suggestions --- .../apps/mytracks/services/StatusAnnouncerTask.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MyTracks/src/com/google/android/apps/mytracks/services/StatusAnnouncerTask.java b/MyTracks/src/com/google/android/apps/mytracks/services/StatusAnnouncerTask.java index 4113cdc59..537586f87 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/services/StatusAnnouncerTask.java +++ b/MyTracks/src/com/google/android/apps/mytracks/services/StatusAnnouncerTask.java @@ -76,10 +76,10 @@ public class StatusAnnouncerTask implements PeriodicTask { private final PhoneStateListener phoneListener = new PhoneStateListener() { @Override public void onCallStateChanged(int state, String incomingNumber) { - speechAllowed = (state == TelephonyManager.CALL_STATE_IDLE); + speechAllowed = state == TelephonyManager.CALL_STATE_IDLE; if (!speechAllowed && tts.isSpeaking()) { - // Stop speaking if we are + // If we're already speaking, stop it. tts.stop(); } } @@ -116,8 +116,8 @@ public class StatusAnnouncerTask implements PeriodicTask { int languageAvailability = tts.isLanguageAvailable(speechLanguage); if (languageAvailability == TextToSpeech.LANG_MISSING_DATA || languageAvailability == TextToSpeech.LANG_NOT_SUPPORTED) { - // English is probably supported - // TODO: Somehow use announcement strings from English too + // English is probably supported. + // TODO: Somehow use announcement strings from English too. Log.w(MyTracksConstants.TAG, "Default language not available, using English."); speechLanguage = Locale.ENGLISH; } @@ -232,7 +232,7 @@ public class StatusAnnouncerTask implements PeriodicTask { @Override public void shutdown() { - // Stop listening to phone state + // Stop listening to phone state. TelephonyManager telephony = (TelephonyManager) context.getSystemService(Context.TELEPHONY_SERVICE); telephony.listen(phoneListener, PhoneStateListener.LISTEN_NONE);