diff --git a/MyTracksTest/src/com/google/android/apps/mytracks/smoketest/MyTracksSmokeTest.java b/MyTracksTest/src/com/google/android/apps/mytracks/smoketest/MyTracksSmokeTest.java index c0d0e9471..911551ad1 100644 --- a/MyTracksTest/src/com/google/android/apps/mytracks/smoketest/MyTracksSmokeTest.java +++ b/MyTracksTest/src/com/google/android/apps/mytracks/smoketest/MyTracksSmokeTest.java @@ -70,7 +70,7 @@ public class MyTracksSmokeTest extends ActivityInstrumentationTestCase2 displayCheckBoxs = solo.getCurrentCheckBoxes(); boolean useMetric = displayCheckBoxs.get(0).isChecked(); solo.clickOnCheckBox(0); solo.goBack(); - // Changes a setting of sharing. + // Change a setting of sharing. solo.clickOnText(activityMyTracks.getString(R.string.settings_sharing)); solo.waitForText(activityMyTracks.getString(R.string.settings_sharing_allow_access)); ArrayList sharingCheckBoxs = solo.getCurrentCheckBoxes(); boolean newMapsPublic = sharingCheckBoxs.get(0).isChecked(); solo.clickOnCheckBox(0); - // Rotates on a sub setting page when the value of a checkbox is changed. + // Rotate on a sub setting page when the value of a checkbox is changed. instrumentation.waitForIdleSync(); rotateAllActivities(); solo.waitForText(activityMyTracks.getString(R.string.settings_sharing_allow_access)); assertEquals(!newMapsPublic, sharingCheckBoxs.get(0).isChecked()); solo.goBack(); - // Resets all settings. + // Reset all settings. solo.clickOnText(activityMyTracks.getString(R.string.settings_reset)); solo.clickOnButton(activityMyTracks.getString(R.string.generic_ok)); - // Checks settings. + // Check settings. solo.clickOnText(activityMyTracks.getString(R.string.settings_display)); solo.waitForText(activityMyTracks.getString(R.string.settings_display_metric)); displayCheckBoxs = solo.getCurrentCheckBoxes(); @@ -279,7 +284,7 @@ public class MyTracksSmokeTest extends ActivityInstrumentationTestCase2 */ public void testExportAndImportTracks() { - // Creates a new track with 3 gps data. + // Create a new track with 3 gps data. createSimpleTrack(3); solo.goBack(); instrumentation.waitForIdleSync(); - // Creates a empty track. + // Create a empty track. createSimpleTrack(0); solo.goBack(); instrumentation.waitForIdleSync(); - // Deletes all exported gpx and kml tracks. + // Delete all exported gpx and kml tracks. deleteExportedFiles(GPX); deleteExportedFiles(KML); int gpxFilesNumber = 0; @@ -344,7 +349,7 @@ public class MyTracksSmokeTest extends ActivityInstrumentationTestCase2 allViews = solo.getViews(); for (View view : allViews) { if (view instanceof MapView) { - assertEquals(isMapMode, !(((MapView) view).isSatellite())); + assertEquals(isMapMode, !((MapView) view).isSatellite()); } } instrumentation.waitForIdleSync(); @@ -426,18 +431,18 @@ public class MyTracksSmokeTest extends ActivityInstrumentationTestCase2 allActivities = solo.getAllOpenedActivities(); diff --git a/MyTracksTest/src/com/google/android/apps/mytracks/smoketest/SmokeTestUtils.java b/MyTracksTest/src/com/google/android/apps/mytracks/smoketest/SmokeTestUtils.java index 28097c69d..8ca3d64af 100644 --- a/MyTracksTest/src/com/google/android/apps/mytracks/smoketest/SmokeTestUtils.java +++ b/MyTracksTest/src/com/google/android/apps/mytracks/smoketest/SmokeTestUtils.java @@ -42,8 +42,7 @@ public class SmokeTestUtils { private static final float DELTA_LONGITUDE = 0.0005f; private static final float DELTA_LADITUDE = 0.0005f; - private SmokeTestUtils() { - } + private SmokeTestUtils() {} /** * Sends Gps data to emulator. @@ -51,9 +50,7 @@ public class SmokeTestUtils { * @param number send times */ public static void sendGps(int number) { - if (number < 1) { - return; - } + if (number < 1) { return; } PrintStream out = null; Socket socket = null; try { @@ -83,15 +80,11 @@ public class SmokeTestUtils { /** * Rotates the given activity. * - * @param activity a given activity. - * @return current orientation of the activity. + * @param activity a given activity */ - public static int rotateActivity(Activity activity) { - if (activity.getResources().getConfiguration().orientation == Configuration.ORIENTATION_PORTRAIT) { - activity.setRequestedOrientation(ORIENTATION_LANDSCAPE); - } else { - activity.setRequestedOrientation(ORIENTATION_PORTRAIT); - } - return activity.getRequestedOrientation(); + public static void rotateActivity(Activity activity) { + activity + .setRequestedOrientation(activity.getResources().getConfiguration().orientation == Configuration.ORIENTATION_PORTRAIT ? ORIENTATION_LANDSCAPE + : ORIENTATION_PORTRAIT); } }