Public API: allow marker creation.

Fixes #2031.

src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java

@@ -487,12 +487,11 @@ public class ContentProviderUtils {
         return markers;
     }
 
-    /**
-     * @return the content provider URI of the inserted marker.
-     */
-    public Uri insertMarker(@NonNull Marker marker) {
+    // TODO Merge with updateMarker
+    public Marker.Id insertMarker(@NonNull Marker marker) {
         marker.setId(null);
-        return contentResolver.insert(MarkerColumns.CONTENT_URI, createContentValues(marker));
+        Uri uri = contentResolver.insert(MarkerColumns.CONTENT_URI, createContentValues(marker));
+        return new Marker.Id(ContentUris.parseId(uri));
     }
 
     private void deleteMarkerPhoto(Context context, Marker marker) {

src/main/java/de/dennisguse/opentracks/publicapi/AbstractAPIActivity.java

@@ -13,7 +13,7 @@ import de.dennisguse.opentracks.services.TrackRecordingService;
 import de.dennisguse.opentracks.services.TrackRecordingServiceConnection;
 import de.dennisguse.opentracks.settings.PreferencesUtils;
 
-public abstract class AbstractAPIActivity extends AppCompatActivity {
+abstract class AbstractAPIActivity extends AppCompatActivity {
 
     private final String TAG = AbstractAPIActivity.class.getSimpleName();
 

src/main/java/de/dennisguse/opentracks/publicapi/CreateMarker.java

@@ -0,0 +1,16 @@
+package de.dennisguse.opentracks.publicapi;
+
+import de.dennisguse.opentracks.services.TrackRecordingService;
+
+public class CreateMarker extends AbstractAPIActivity {
+
+    @Override
+    protected void execute(TrackRecordingService service) {
+        service.createMarker();
+    }
+
+    @Override
+    protected boolean isPostExecuteStopService() {
+        return false;
+    }
+}

src/main/java/de/dennisguse/opentracks/publicapi/CreateMarkerActivity.java

@@ -12,7 +12,7 @@ import de.dennisguse.opentracks.ui.markers.MarkerEditActivity;
 import de.dennisguse.opentracks.util.IntentUtils;
 
 /**
- * Public API to creates a Marker for a given track with a given location
+ * INTERNAL: only meant for clients of OSMDashboard API.
  */
 public class CreateMarkerActivity extends AppCompatActivity {
 

src/main/java/de/dennisguse/opentracks/publicapi/ShowMarkerActivity.java

@@ -13,7 +13,7 @@ import de.dennisguse.opentracks.ui.markers.MarkerDetailActivity;
 import de.dennisguse.opentracks.util.IntentUtils;
 
 /**
- * Public api to show an existing marker
+ * INTERNAL: only meant for clients of OSMDashboard API.
  */
 public class ShowMarkerActivity extends AppCompatActivity {
 

src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java

@@ -36,7 +36,9 @@ import java.io.PrintWriter;
 import java.io.StringWriter;
 import java.time.Duration;
 
+import de.dennisguse.opentracks.data.ContentProviderUtils;
 import de.dennisguse.opentracks.data.models.Distance;
+import de.dennisguse.opentracks.data.models.Marker;
 import de.dennisguse.opentracks.data.models.Track;
 import de.dennisguse.opentracks.data.models.TrackPoint;
 import de.dennisguse.opentracks.sensors.sensorData.SensorDataSet;
@@ -243,6 +245,20 @@ public class TrackRecordingService extends Service implements TrackPointCreator.
         gpsStatusObservable.postValue(STATUS_GPS_DEFAULT);
     }
 
+    public Marker.Id createMarker() {
+        if (!isRecording()) {
+            return null;
+        }
+
+        //TODO This contains some duplication to TrackRecodingActivity's Marker creation
+        TrackPoint trackPoint = trackRecordingManager.getLastStoredTrackPointWithLocation();
+        if (trackPoint == null) {
+            return null;
+        }
+        Marker marker = new Marker(recordingStatus.trackId(), trackPoint);
+        return new ContentProviderUtils(this).insertMarker(marker);
+    }
+
     @Override
     public boolean newTrackPoint(TrackPoint trackPoint, Distance thresholdHorizontalAccuracy) {
         if (!isRecording()) {