Cleanup: TrackRecordingServiceConnection.

src/main/java/de/dennisguse/opentracks/TrackListActivity.java

@@ -157,8 +157,7 @@ public class TrackListActivity extends AbstractTrackDeleteActivity implements Co
                 startActivity(new Intent(Settings.ACTION_LOCATION_SOURCE_SETTINGS));
             } else {
                 if (gpsStatusValue.isGpsStarted()) {
-                    recordingStatusConnection.unbindAndStop(this);
+                    recordingStatusConnection.stopService(this);
-                    recordingStatusConnection.startConnection(this); //TODO We need to stay listening!
                 } else {
                     new TrackRecordingServiceConnection((service, connection) -> {
                         service.tryStartSensors();
@@ -220,7 +219,7 @@ public class TrackListActivity extends AbstractTrackDeleteActivity implements Co
         super.onStart();
 
         PreferencesUtils.registerOnSharedPreferenceChangeListener(sharedPreferenceChangeListener);
-        recordingStatusConnection.startConnection(this);
+        recordingStatusConnection.bind(this);
     }
 
     @Override

src/main/java/de/dennisguse/opentracks/TrackRecordedActivity.java

@@ -126,7 +126,7 @@ public class TrackRecordedActivity extends AbstractTrackDeleteActivity implement
             trackDataHub.loadTrack(trackId);
         }
 
-        trackRecordingServiceConnection.startConnection(this);
+        trackRecordingServiceConnection.bind(this);
     }
 
     @Override

src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java

@@ -207,7 +207,7 @@ public class TrackRecordingActivity extends AbstractActivity implements ChooseAc
 
         PreferencesUtils.registerOnSharedPreferenceChangeListener(sharedPreferenceChangeListener);
 
-        trackRecordingServiceConnection.startConnection(this);
+        trackRecordingServiceConnection.bind(this);
         trackDataHub.start();
     }
 

src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordingFragment.java

@@ -88,7 +88,7 @@ public class StatisticsRecordingFragment extends Fragment {
 
         PreferencesUtils.registerOnSharedPreferenceChangeListener(sharedPreferenceChangeListener);
 
-        trackRecordingServiceConnection.startConnection(getContext());
+        trackRecordingServiceConnection.bind(getContext());
     }
 
     @Override

src/main/java/de/dennisguse/opentracks/services/TrackRecordingServiceConnection.java

@@ -74,14 +74,21 @@ public class TrackRecordingServiceConnection {
         setTrackRecordingService(null);
     };
 
-    public TrackRecordingServiceConnection() {
-        callback = null;
-    }
-
     public TrackRecordingServiceConnection(@NonNull Callback callback) {
         this.callback = callback;
     }
 
+    public void bind(@NonNull Context context) {
+        if (trackRecordingService != null) {
+            // Service is already started and bound.
+            return;
+        }
+
+        Log.i(TAG, "Binding the service.");
+        int flags = BuildConfig.DEBUG ? Context.BIND_DEBUG_UNBIND : 0;
+        context.bindService(new Intent(context, TrackRecordingService.class), serviceConnection, flags);
+    }
+
     public void startAndBind(Context context) {
         if (trackRecordingService != null) {
             // Service is already started and bound.
@@ -90,7 +97,7 @@ public class TrackRecordingServiceConnection {
 
         ContextCompat.startForegroundService(context, new Intent(context, TrackRecordingService.class));
 
-        startConnection(context);
+        bind(context);
     }
 
     //TODO There should be a better way to implement this.
@@ -105,20 +112,7 @@ public class TrackRecordingServiceConnection {
             startAndBind(context);
             return;
         }
-        if (callback != null) {
+        callback.onConnected(trackRecordingService, this);
-            callback.onConnected(trackRecordingService, this);
-        }
-    }
-
-    public void startConnection(@NonNull Context context) {
-        if (trackRecordingService != null) {
-            // Service is already started and bound.
-            return;
-        }
-
-        Log.i(TAG, "Binding the service.");
-        int flags = BuildConfig.DEBUG ? Context.BIND_DEBUG_UNBIND : 0;
-        context.bindService(new Intent(context, TrackRecordingService.class), serviceConnection, flags);
     }
 
     /**
@@ -134,15 +128,19 @@ public class TrackRecordingServiceConnection {
         setTrackRecordingService(null);
     }
 
+    public void stopService(Context context) {
+        context.stopService(new Intent(context, TrackRecordingService.class));
+    }
+
     public void unbindAndStop(Context context) {
         unbind(context);
-        context.stopService(new Intent(context, TrackRecordingService.class));
+        stopService(context);
     }
 
     private void setTrackRecordingService(TrackRecordingService value) {
         trackRecordingService = value;
-        if (callback != null && value != null) {
+        if (value != null) {
-                callback.onConnected(value, this);
+            callback.onConnected(value, this);
         }
     }
 

src/main/java/de/dennisguse/opentracks/ui/markers/MarkerEditViewModel.java

@@ -32,7 +32,7 @@ public class MarkerEditViewModel extends AndroidViewModel {
     private MutableLiveData<Marker> markerData;
     private boolean isNewMarker;
     private Uri photoOriginalUri;
-    private final TrackRecordingServiceConnection trackRecordingServiceConnection = new TrackRecordingServiceConnection();
+    private final TrackRecordingServiceConnection trackRecordingServiceConnection = new TrackRecordingServiceConnection((service, connection) -> {});
 
     public MarkerEditViewModel(@NonNull Application application) {
         super(application);
@@ -41,7 +41,7 @@ public class MarkerEditViewModel extends AndroidViewModel {
     public LiveData<Marker> getMarkerData(@NonNull Track.Id trackId, @Nullable Marker.Id markerId) {
         if (markerData == null) {
             markerData = new MutableLiveData<>();
-            trackRecordingServiceConnection.startConnection(getApplication());
+            trackRecordingServiceConnection.bind(getApplication());
             loadData(trackId, markerId);
         }
         return markerData;

src/main/java/de/dennisguse/opentracks/ui/markers/MarkerListActivity.java

@@ -119,13 +119,13 @@ public class MarkerListActivity extends AbstractActivity {
     @Override
     protected void onStart() {
         super.onStart();
-        trackRecordingServiceConnection.startConnection(this);
+        trackRecordingServiceConnection.bind(this);
     }
 
     @Override
     protected void onResume() {
         super.onResume();
-        trackRecordingServiceConnection.startConnection(this);
+        trackRecordingServiceConnection.bind(this);
         this.invalidateOptionsMenu();
         loadData();
     }