From 5de2012452dd2436df748dcbd30eb67bb91b4d75 Mon Sep 17 00:00:00 2001 From: Dennis Guse Date: Mon, 1 Jan 2024 15:35:19 +0100 Subject: [PATCH] Android14: crash if permissions were not granted. This is better than not starting the recording. Part of #1781. --- .../opentracks/services/TrackRecordingService.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java index 29cedf294..ad2e62722 100644 --- a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java +++ b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java @@ -26,7 +26,6 @@ import android.os.Looper; import android.os.PowerManager.WakeLock; import android.util.Log; import android.util.Pair; -import android.widget.Toast; import androidx.annotation.Nullable; import androidx.annotation.VisibleForTesting; @@ -38,7 +37,6 @@ import java.io.PrintWriter; import java.io.StringWriter; import java.time.Duration; -import de.dennisguse.opentracks.R; import de.dennisguse.opentracks.data.models.Distance; import de.dennisguse.opentracks.data.models.Marker; import de.dennisguse.opentracks.data.models.Track; @@ -217,8 +215,7 @@ public class TrackRecordingService extends Service implements TrackPointCreator. if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) { if (!PermissionRequester.RECORDING.hasPermission(this)) { - Toast.makeText(this, R.string.permission_recording_failed, Toast.LENGTH_LONG).show(); - return; + throw new RuntimeException("Android14: Please grant permissions LOCATION and NEARBY DEVICES (manually)"); } }