Fix unit test for ResultDialogFactoryTest

- change to the MyTracks activity because the SendActivity doesn't have a
  window to display the dialog.
This commit is contained in:
Jimmy Shih
2011-11-10 18:40:26 -08:00
parent 2dd37ff965
commit 60f34d89ba
@@ -15,6 +15,7 @@
*/ */
package com.google.android.apps.mytracks.io.sendtogoogle; package com.google.android.apps.mytracks.io.sendtogoogle;
import com.google.android.apps.mytracks.MyTracks;
import com.google.android.maps.mytracks.R; import com.google.android.maps.mytracks.R;
import android.app.AlertDialog; import android.app.AlertDialog;
@@ -32,9 +33,9 @@ import java.util.List;
* *
* @author Matthew Simmons * @author Matthew Simmons
*/ */
public class ResultDialogFactoryTest extends ActivityInstrumentationTestCase2<SendActivity> { public class ResultDialogFactoryTest extends ActivityInstrumentationTestCase2<MyTracks> {
public ResultDialogFactoryTest() { public ResultDialogFactoryTest() {
super(SendActivity.class); super(MyTracks.class);
} }
private List<SendResult> makeResults(SendResult... results) { private List<SendResult> makeResults(SendResult... results) {
@@ -50,11 +51,19 @@ public class ResultDialogFactoryTest extends ActivityInstrumentationTestCase2<Se
public void onClick(DialogInterface dialog, int which) {} public void onClick(DialogInterface dialog, int which) {}
}; };
private MyTracks myTracks;
protected void setUp() throws Exception {
super.setUp();
myTracks = getActivity();
};
public void testSuccess_noShare() { public void testSuccess_noShare() {
List<SendResult> results = makeResults(new SendResult(SendType.MYMAPS, true), List<SendResult> results = makeResults(new SendResult(SendType.MYMAPS, true),
new SendResult(SendType.DOCS, true)); new SendResult(SendType.DOCS, true));
AlertDialog dialog = ResultDialogFactory.makeDialog(getActivity(), results, clickListener, null, null); AlertDialog dialog = ResultDialogFactory.makeDialog(
myTracks, results, clickListener, null, null);
dialog.show(); dialog.show();
ListView listView = (ListView) dialog.findViewById(R.id.send_to_google_result_list); ListView listView = (ListView) dialog.findViewById(R.id.send_to_google_result_list);
@@ -82,11 +91,11 @@ public class ResultDialogFactoryTest extends ActivityInstrumentationTestCase2<Se
} }
public void testSuccess_share() { public void testSuccess_share() {
List<SendResult> results = makeResults(new SendResult(SendType.MYMAPS, true), List<SendResult> results = makeResults(
new SendResult(SendType.DOCS, true)); new SendResult(SendType.MYMAPS, true), new SendResult(SendType.DOCS, true));
AlertDialog dialog = ResultDialogFactory.makeDialog(getActivity(), results, AlertDialog dialog = ResultDialogFactory.makeDialog(
clickListener, clickListener, null); myTracks, results, clickListener, clickListener, null);
dialog.show(); dialog.show();
assertEquals(View.VISIBLE, dialog.getButton(AlertDialog.BUTTON_POSITIVE).getVisibility()); assertEquals(View.VISIBLE, dialog.getButton(AlertDialog.BUTTON_POSITIVE).getVisibility());
@@ -97,7 +106,8 @@ public class ResultDialogFactoryTest extends ActivityInstrumentationTestCase2<Se
List<SendResult> results = makeResults(new SendResult(SendType.MYMAPS, true), List<SendResult> results = makeResults(new SendResult(SendType.MYMAPS, true),
new SendResult(SendType.DOCS, false)); new SendResult(SendType.DOCS, false));
AlertDialog dialog = ResultDialogFactory.makeDialog(getActivity(), results, clickListener, null, null); AlertDialog dialog = ResultDialogFactory.makeDialog(
myTracks, results, clickListener, null, null);
dialog.show(); dialog.show();
assertEquals(View.GONE, assertEquals(View.GONE,
@@ -110,8 +120,8 @@ public class ResultDialogFactoryTest extends ActivityInstrumentationTestCase2<Se
List<SendResult> results = makeResults(new SendResult(SendType.MYMAPS, true), List<SendResult> results = makeResults(new SendResult(SendType.MYMAPS, true),
new SendResult(SendType.DOCS, false)); new SendResult(SendType.DOCS, false));
AlertDialog dialog = ResultDialogFactory.makeDialog(getActivity(), results, AlertDialog dialog = ResultDialogFactory.makeDialog(
clickListener, clickListener, null); myTracks, results, clickListener, clickListener, null);
dialog.show(); dialog.show();
assertEquals(View.VISIBLE, dialog.getButton(AlertDialog.BUTTON_POSITIVE).getVisibility()); assertEquals(View.VISIBLE, dialog.getButton(AlertDialog.BUTTON_POSITIVE).getVisibility());