From 6ec78d77a9dff6304b08837c15c784eaedbac016 Mon Sep 17 00:00:00 2001
From: Dennis Guse <dennis.guse@alumni.tu-berlin.de>
Date: Sat, 14 Sep 2019 13:25:23 +0200
Subject: [PATCH] Changed gps menu item icon to represent actual state of the
 gps (and not the action to be executed).

---
 src/main/java/de/dennisguse/opentracks/TrackListActivity.java | 2 +-
 src/main/res/menu/track_list.xml                              | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/main/java/de/dennisguse/opentracks/TrackListActivity.java b/src/main/java/de/dennisguse/opentracks/TrackListActivity.java
index 2765df98d..65ddf7c49 100644
--- a/src/main/java/de/dennisguse/opentracks/TrackListActivity.java
+++ b/src/main/java/de/dennisguse/opentracks/TrackListActivity.java
@@ -528,7 +528,7 @@ public class TrackListActivity extends AbstractListActivity implements ConfirmDe
             startGpsMenuItem.setVisible(!isRecording);
             if (!isRecording) {
                 startGpsMenuItem.setTitle(isGpsStarted ? R.string.menu_stop_gps : R.string.menu_start_gps);
-                startGpsMenuItem.setIcon(isGpsStarted ? R.drawable.ic_gps_off_24dp : R.drawable.ic_gps_fixed_24dp);
+                startGpsMenuItem.setIcon(isGpsStarted ? R.drawable.ic_gps_fixed_24dp : R.drawable.ic_gps_off_24dp);
             }
         }
         if (aggregatedStatisticsMenuItem != null) {
diff --git a/src/main/res/menu/track_list.xml b/src/main/res/menu/track_list.xml
index e332c4e0b..e8f6a19bf 100644
--- a/src/main/res/menu/track_list.xml
+++ b/src/main/res/menu/track_list.xml
@@ -19,6 +19,7 @@ limitations under the License.
         android:actionViewClass="android.widget.SearchView"
         android:showAsAction="ifRoom"
         android:title="@string/menu_search" />
+    <!-- Icon and title is overwritten by TrackListActivity -->
     <item
         android:id="@+id/track_list_start_gps"
         android:icon="@drawable/ic_gps_off_24dp"