Remove the following strings and drawables

- menu_record_track
- menu_pause_track
- menu_stop_track

Update status and button images.
This commit is contained in:
Jimmy Shih
2012-09-04 11:21:47 -07:00
parent 7b025443c1
commit 72a6f31790
34 changed files with 37 additions and 45 deletions
Binary file not shown.

Before

Width:  |  Height:  |  Size: 10 KiB

After

Width:  |  Height:  |  Size: 6.4 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 9.2 KiB

After

Width:  |  Height:  |  Size: 7.6 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 4.8 KiB

After

Width:  |  Height:  |  Size: 6.7 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 7.1 KiB

After

Width:  |  Height:  |  Size: 7.1 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 1.1 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 55 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 54 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 2.8 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 3.0 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 7.8 KiB

After

Width:  |  Height:  |  Size: 5.0 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 7.0 KiB

After

Width:  |  Height:  |  Size: 5.8 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 4.1 KiB

After

Width:  |  Height:  |  Size: 5.2 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 5.5 KiB

After

Width:  |  Height:  |  Size: 5.5 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 1.1 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 55 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 54 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 2.8 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 2.9 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 13 KiB

After

Width:  |  Height:  |  Size: 7.7 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 11 KiB

After

Width:  |  Height:  |  Size: 9.4 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 5.5 KiB

After

Width:  |  Height:  |  Size: 8.2 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 8.7 KiB

After

Width:  |  Height:  |  Size: 8.7 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 1.2 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 45 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 41 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 2.8 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 3.1 KiB

+2 -2
View File
@@ -17,7 +17,7 @@ limitations under the License.
<merge xmlns:android="http://schemas.android.com/apk/res/android" > <merge xmlns:android="http://schemas.android.com/apk/res/android" >
<ImageButton <ImageButton
android:background="@android:color/transparent" android:background="@android:color/transparent"
android:contentDescription="@string/menu_record_track" android:contentDescription="@string/icon_record_track"
android:id="@+id/track_controller_record" android:id="@+id/track_controller_record"
android:layout_height="100dp" android:layout_height="100dp"
android:layout_width="wrap_content" android:layout_width="wrap_content"
@@ -45,7 +45,7 @@ limitations under the License.
</RelativeLayout> </RelativeLayout>
<ImageButton <ImageButton
android:background="@android:color/transparent" android:background="@android:color/transparent"
android:contentDescription="@string/menu_stop_recording" android:contentDescription="@string/icon_stop_recording"
android:id="@+id/track_controller_stop" android:id="@+id/track_controller_stop"
android:layout_height="100dp" android:layout_height="100dp"
android:layout_width="wrap_content" android:layout_width="wrap_content"
+2 -2
View File
@@ -93,13 +93,13 @@ limitations under the License.
</LinearLayout> </LinearLayout>
<ImageButton <ImageButton
android:background="@drawable/track_widget_record_button_background" android:background="@drawable/track_widget_record_button_background"
android:contentDescription="@string/menu_record_track" android:contentDescription="@string/icon_record_track"
android:id="@+id/track_widget_record_button" android:id="@+id/track_widget_record_button"
android:src="@drawable/track_widget_record_button" android:src="@drawable/track_widget_record_button"
style="@style/TrackWidgetButton" /> style="@style/TrackWidgetButton" />
<ImageButton <ImageButton
android:background="@drawable/track_widget_stop_button_background" android:background="@drawable/track_widget_stop_button_background"
android:contentDescription="@string/menu_stop_recording" android:contentDescription="@string/icon_stop_recording"
android:id="@+id/track_widget_stop_button" android:id="@+id/track_widget_stop_button"
android:src="@drawable/track_widget_stop_button" android:src="@drawable/track_widget_stop_button"
style="@style/TrackWidgetButton" /> style="@style/TrackWidgetButton" />
+12 -18
View File
@@ -890,6 +890,18 @@ limitations under the License.
translation_description="The accessibility description for the 'My Location' icon."> translation_description="The accessibility description for the 'My Location' icon.">
My Location My Location
</string> </string>
<string name="icon_pause_recording"
translation_description="The accessibility description for the pause recording icon.">
Pause recording
</string>
<string name="icon_record_track"
translation_description="The accessibility description for the record track icon.">
Record track
</string>
<string name="icon_stop_recording"
translation_description="The accessibility description for the stop recording icon.">
Stop recording
</string>
<string name="icon_track" <string name="icon_track"
translation_description="The accessibility description for the 'Track' icon."> translation_description="The accessibility description for the 'Track' icon.">
Track Track
@@ -1082,24 +1094,12 @@ limitations under the License.
Character limit: ~21 (1 line)"> Character limit: ~21 (1 line)">
Markers Markers
</string> </string>
<string name="menu_pause_track"
translation_description="In the menu, to pause a track.
Character limit: ~21 (1 line)">
Pause track
</string>
<string name="menu_play" <string name="menu_play"
translation_description="In the menu, to play a track. translation_description="In the menu, to play a track.
Character limit: ~21 (1 line)"> Character limit: ~21 (1 line)">
Play Play
</string> </string>
<string name="menu_record_track"
translation_description="In the menu, to start recording a track.
Character limit: ~21 (1 line)">
Record track
</string>
<string name="menu_satellite_mode" <string name="menu_satellite_mode"
translation_description="In the menu, to switch the display to the satellite mode. translation_description="In the menu, to switch the display to the satellite mode.
@@ -1171,12 +1171,6 @@ limitations under the License.
Character limit: ~21 (1 line)"> Character limit: ~21 (1 line)">
Split frequency Split frequency
</string> </string>
<string name="menu_stop_recording"
translation_description="In the menu, to stop recording a track.
Character limit: ~21 (1 line)">
Stop recording
</string>
<string name="menu_voice_frequency" <string name="menu_voice_frequency"
translation_description="In the menu, to configure the voice frequency, how frequent to announce translation_description="In the menu, to configure the voice frequency, how frequent to announce
status. status.
@@ -438,9 +438,9 @@ public class SearchListActivity extends AbstractMyTracksActivity implements Dele
int iconId; int iconId;
int iconContentDescriptionId; int iconContentDescriptionId;
if (isRecording) { if (isRecording) {
iconId = recordingTrackPaused ? R.drawable.menu_pause_track : R.drawable.menu_record_track; iconId = recordingTrackPaused ? R.drawable.status_paused : R.drawable.status_recording;
iconContentDescriptionId = recordingTrackPaused ? R.string.menu_pause_track iconContentDescriptionId = recordingTrackPaused ? R.string.icon_pause_recording
: R.drawable.menu_record_track; : R.string.icon_record_track;
} else { } else {
iconId = TrackIconUtils.getIconDrawable(track.getIcon()); iconId = TrackIconUtils.getIconDrawable(track.getIcon());
iconContentDescriptionId = R.string.icon_track; iconContentDescriptionId = R.string.icon_track;
@@ -96,7 +96,7 @@ public class TrackController {
recordImageButton.setImageResource( recordImageButton.setImageResource(
isRecording && !isPaused ? R.drawable.btn_pause : R.drawable.btn_record); isRecording && !isPaused ? R.drawable.btn_pause : R.drawable.btn_record);
recordImageButton.setContentDescription(activity.getString( recordImageButton.setContentDescription(activity.getString(
isRecording && !isPaused ? R.string.menu_pause_track : R.string.menu_record_track)); isRecording && !isPaused ? R.string.icon_pause_recording : R.string.icon_record_track));
stopImageButton.setImageResource(isRecording ? R.drawable.btn_stop_1 : R.drawable.btn_stop_0); stopImageButton.setImageResource(isRecording ? R.drawable.btn_stop_1 : R.drawable.btn_stop_0);
stopImageButton.setEnabled(isRecording); stopImageButton.setEnabled(isRecording);
@@ -275,10 +275,9 @@ public class TrackListActivity extends FragmentActivity implements DeleteOneTrac
int iconId; int iconId;
int iconContentDescriptionId; int iconContentDescriptionId;
if (isRecording) { if (isRecording) {
iconId = recordingTrackPaused ? R.drawable.menu_pause_track iconId = recordingTrackPaused ? R.drawable.status_paused : R.drawable.status_recording;
: R.drawable.menu_record_track; iconContentDescriptionId = recordingTrackPaused ? R.string.icon_pause_recording
iconContentDescriptionId = recordingTrackPaused ? R.string.menu_pause_track : R.string.icon_record_track;
: R.string.menu_record_track;
} else { } else {
iconId = TrackIconUtils.getIconDrawable(cursor.getString(iconIndex)); iconId = TrackIconUtils.getIconDrawable(cursor.getString(iconIndex));
iconContentDescriptionId = R.string.icon_track; iconContentDescriptionId = R.string.icon_track;
@@ -342,8 +342,8 @@ public class EndToEndTestUtils {
public static void createTrackWithPause(int numberOfGpsData) { public static void createTrackWithPause(int numberOfGpsData) {
EndToEndTestUtils.startRecording(); EndToEndTestUtils.startRecording();
EndToEndTestUtils.sendGps(numberOfGpsData); EndToEndTestUtils.sendGps(numberOfGpsData);
EndToEndTestUtils.findMenuItem(activityMytracks.getString(R.string.menu_pause_track), true); //EndToEndTestUtils.findMenuItem(activityMytracks.getString(R.string.menu_pause_track), true);
EndToEndTestUtils.findMenuItem(activityMytracks.getString(R.string.menu_record_track), true); //EndToEndTestUtils.findMenuItem(activityMytracks.getString(R.string.menu_record_track), true);
EndToEndTestUtils.sendGps(numberOfGpsData, numberOfGpsData); EndToEndTestUtils.sendGps(numberOfGpsData, numberOfGpsData);
EndToEndTestUtils.stopRecording(true); EndToEndTestUtils.stopRecording(true);
} }
@@ -430,21 +430,20 @@ public class EndToEndTestUtils {
*/ */
static boolean isUnderRecording() { static boolean isUnderRecording() {
View startButton = SOLO.getCurrentActivity().findViewById(R.id.track_controller_record); View startButton = SOLO.getCurrentActivity().findViewById(R.id.track_controller_record);
if(startButton != null && startButton.isShown()) { if (startButton != null && startButton.isShown()) {
return false; return false;
} }
// if (hasActionBar) {
if (hasActionBar) { // return getButtonOnScreen(activityMytracks
return getButtonOnScreen(activityMytracks // .getString(R.string.menu_record_track), false, false) == null;
.getString(R.string.menu_record_track), false, false) == null; // }
} // showMenuItem();
showMenuItem(); // if (SOLO.searchText(activityMytracks.getString(R.string.menu_record_track))
if (SOLO.searchText(activityMytracks.getString(R.string.menu_record_track)) // || SOLO.searchText(activityMytracks.getString(R.string.menu_play))) {
|| SOLO.searchText(activityMytracks.getString(R.string.menu_play))) { // SOLO.goBack();
SOLO.goBack(); // return false;
return false; // }
} // SOLO.goBack();
SOLO.goBack();
return true; return true;
} }