From 73872e8926d34802ebdbc4acc1f015a0a45c9a3a Mon Sep 17 00:00:00 2001
From: Dennis Guse <dennis.guse@alumni.tu-berlin.de>
Date: Thu, 16 Oct 2025 22:48:03 +0200
Subject: [PATCH] Cleanup.

---
 .../java/de/dennisguse/opentracks/data/models/TrackPoint.java | 2 +-
 .../opentracks/io/file/importer/ImportActivity.java           | 4 +---
 .../de/dennisguse/opentracks/settings/LocalePreference.java   | 2 +-
 .../de/dennisguse/opentracks/util/PermissionRequester.java    | 2 +-
 4 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/main/java/de/dennisguse/opentracks/data/models/TrackPoint.java b/src/main/java/de/dennisguse/opentracks/data/models/TrackPoint.java
index 90aa92d0a..393d49176 100644
--- a/src/main/java/de/dennisguse/opentracks/data/models/TrackPoint.java
+++ b/src/main/java/de/dennisguse/opentracks/data/models/TrackPoint.java
@@ -35,7 +35,7 @@ import java.util.Optional;
 public class TrackPoint {
 
     @Nullable
-    private TrackPoint.Id id;
+    private final TrackPoint.Id id;
 
     //Requires: position.time must be non-null
     @NonNull
diff --git a/src/main/java/de/dennisguse/opentracks/io/file/importer/ImportActivity.java b/src/main/java/de/dennisguse/opentracks/io/file/importer/ImportActivity.java
index 9138887f7..a3c33f20c 100644
--- a/src/main/java/de/dennisguse/opentracks/io/file/importer/ImportActivity.java
+++ b/src/main/java/de/dennisguse/opentracks/io/file/importer/ImportActivity.java
@@ -97,9 +97,7 @@ public class ImportActivity extends AbstractActivity {
 
         importer = new Importer(this, documentFiles);
         importer.getLiveData()
-                .observe(this, summary -> {
-                    setProgress(summary);
-                });
+                .observe(this, summary -> setProgress(summary));
         importer.startImport();
 
         //Works for a directory, but we might have received multiple files via SEND_MULTIPLE.
diff --git a/src/main/java/de/dennisguse/opentracks/settings/LocalePreference.java b/src/main/java/de/dennisguse/opentracks/settings/LocalePreference.java
index 95687143c..83c2f5658 100644
--- a/src/main/java/de/dennisguse/opentracks/settings/LocalePreference.java
+++ b/src/main/java/de/dennisguse/opentracks/settings/LocalePreference.java
@@ -29,7 +29,7 @@ import de.dennisguse.opentracks.R;
 
 public class LocalePreference extends ListPreference {
 
-    private String TAG = LocalePreference.class.getSimpleName();
+    private final String TAG = LocalePreference.class.getSimpleName();
 
     public LocalePreference(@NonNull Context context, @Nullable AttributeSet attrs, int defStyleAttr, int defStyleRes) {
         super(context, attrs, defStyleAttr, defStyleRes);
diff --git a/src/main/java/de/dennisguse/opentracks/util/PermissionRequester.java b/src/main/java/de/dennisguse/opentracks/util/PermissionRequester.java
index d8a9fe02c..f99f10fb4 100644
--- a/src/main/java/de/dennisguse/opentracks/util/PermissionRequester.java
+++ b/src/main/java/de/dennisguse/opentracks/util/PermissionRequester.java
@@ -95,7 +95,7 @@ public class PermissionRequester {
         ArrayList<String> recording = new ArrayList<>(GPS_PERMISSION);
         recording.addAll(BLUETOOTH_PERMISSIONS);
 
-        RECORDING_PERMISSIONS = Collections.unmodifiableList(new ArrayList<>(recording));
+        RECORDING_PERMISSIONS = List.copyOf(recording);
 
         recording.addAll(NOTIFICATION_PERMISSIONS);