karol/OpenTracks
1
0
Fork 0
forked from upstream-mirrors/OpenTracks
Code Pull Requests Actions Releases 2 Activity

announce called after getting recordingTrackId. Fixed a potencial race condition.

Browse Source
This commit is contained in:
Román Martínez
2021-04-17 16:41:34 +02:00
committed by Dennis Guse
parent 99126fa357
commit 772dad4837
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/de/dennisguse/opentracks/services/tasks/AnnouncementPeriodicTask.java
+6 -2
View File
@@ -146,9 +146,9 @@ public class AnnouncementPeriodicTask implements PeriodicTask {
@Override @Override
public void onTrackRecordingId(Track.Id trackId) { public void onTrackRecordingId(Track.Id trackId) {
recordingTrackId = trackId; recordingTrackId = trackId;
announce(trackRecordingService.getTrackStatistics());
} }
}); });
announce(trackRecordingService.getTrackStatistics());
} }
/** /**
@@ -181,7 +181,11 @@ public class AnnouncementPeriodicTask implements PeriodicTask {
} }
Track track = contentProviderUtils.getTrack(recordingTrackId); Track track = contentProviderUtils.getTrack(recordingTrackId);
String category = track != null ? track.getCategory() : ""; if (track == null) {
Log.i(TAG, "It doesn't exists a track with trackid = " + recordingTrackId);
return;
}
String category = track.getCategory();
//TODO Querying all TrackPoints all the time is inefficient; use TrackDataHub or something else. //TODO Querying all TrackPoints all the time is inefficient; use TrackDataHub or something else.
TrackPointIterator trackPointIterator = contentProviderUtils.getTrackPointLocationIterator(track.getId(), null); TrackPointIterator trackPointIterator = contentProviderUtils.getTrackPointLocationIterator(track.getId(), null);