Refactor Track.icon is now Track.activityTypeId.

Part of #1608.

src/androidTest/java/de/dennisguse/opentracks/io/file/importer/ExportImportTest.java

@@ -180,7 +180,7 @@ public class ExportImportTest {
         service.endCurrentTrack();
 
         Track track = contentProviderUtils.getTrack(trackId);
-        track.setIcon(TRACK_ICON);
+        track.setActivityTypeId(TRACK_ICON);
         track.setActivityType(TRACK_ACTIVITY_TYPE);
         track.setDescription(TRACK_DESCRIPTION);
         contentProviderUtils.updateTrack(track);
@@ -219,7 +219,7 @@ public class ExportImportTest {
         assertEquals(track.getActivityType(), importedTrack.getActivityType());
         assertEquals(track.getDescription(), importedTrack.getDescription());
         assertEquals(track.getName(), importedTrack.getName());
-        assertEquals(track.getIcon(), importedTrack.getIcon());
+        assertEquals(track.getActivityTypeId(), importedTrack.getActivityTypeId());
 
         // 2. trackpoints
         TrackPointAssert a = new TrackPointAssert();

src/androidTest/java/de/dennisguse/opentracks/io/file/importer/GPXTrackImporterTest.java

@@ -82,7 +82,7 @@ public class GPXTrackImporterTest {
         assertEquals("the category", importedTrack.getActivityType());
         assertEquals("the description", importedTrack.getDescription());
         assertEquals("2021-01-07 22:51", importedTrack.getName());
-        assertEquals("UNKNOWN", importedTrack.getIcon());
+        assertEquals("UNKNOWN", importedTrack.getActivityTypeId());
 
         //TODO Check trackstatistics
 
@@ -136,7 +136,7 @@ public class GPXTrackImporterTest {
         assertEquals("", importedTrack.getActivityType());
         assertEquals("", importedTrack.getDescription());
         assertEquals("20210907_213924.gpx", importedTrack.getName());
-        assertEquals("", importedTrack.getIcon());
+        assertEquals("", importedTrack.getActivityTypeId());
 
         // 3. trackstatistics
         TrackStatistics trackStatistics = importedTrack.getTrackStatistics();
@@ -184,7 +184,7 @@ public class GPXTrackImporterTest {
         assertEquals("", importedTrack.getActivityType());
         assertEquals("", importedTrack.getDescription());
         assertEquals("20210907_213924.gpx", importedTrack.getName());
-        assertEquals("", importedTrack.getIcon());
+        assertEquals("", importedTrack.getActivityTypeId());
 
         // 3. trackstatistics
         TrackStatistics trackStatistics = importedTrack.getTrackStatistics();

src/androidTest/java/de/dennisguse/opentracks/io/file/importer/KMLTrackImporterTest.java

@@ -73,7 +73,7 @@ public class KMLTrackImporterTest {
         assertEquals("", importedTrack.getActivityType());
         assertEquals("", importedTrack.getDescription());
         assertEquals("", importedTrack.getName());
-        assertEquals("", importedTrack.getIcon());
+        assertEquals("", importedTrack.getActivityTypeId());
 
         // 2. markers
         assertEquals(0, contentProviderUtils.getMarkers(importTrackId).size());
@@ -122,7 +122,7 @@ public class KMLTrackImporterTest {
         assertEquals("", importedTrack.getActivityType());
         assertEquals("", importedTrack.getDescription());
         assertEquals("", importedTrack.getName());
-        assertEquals("", importedTrack.getIcon());
+        assertEquals("", importedTrack.getActivityTypeId());
 
         // 2. markers
         assertEquals(0, contentProviderUtils.getMarkers(importTrackId).size());
@@ -162,7 +162,7 @@ public class KMLTrackImporterTest {
         assertEquals("unknown", importedTrack.getActivityType());
         assertEquals("Test Track", importedTrack.getDescription());
         assertEquals("2020-11-28 18:06", importedTrack.getName());
-        assertEquals("UNKNOWN", importedTrack.getIcon());
+        assertEquals("UNKNOWN", importedTrack.getActivityTypeId());
 
         // 2. markers
         assertEquals(0, contentProviderUtils.getMarkers(importTrackId).size());

src/androidTest/java/de/dennisguse/opentracks/ui/aggregatedStatistics/AggregatedStatisticsTest.java

@@ -40,7 +40,7 @@ public class AggregatedStatisticsTest {
         statistics.setMinAltitude(1200.0);  // Resulting min altitude
 
         Track track = new Track();
-        track.setIcon(ActivityType.findByLocalizedString(context, category)
+        track.setActivityTypeId(ActivityType.findByLocalizedString(context, category)
                 .getId());
         track.setActivityType(category);
         track.setTrackStatistics(statistics);

src/main/java/de/dennisguse/opentracks/TrackEditActivity.java

@@ -95,7 +95,7 @@ public class TrackEditActivity extends AbstractActivity implements ChooseActivit
             iconValue = bundle.getString(ICON_VALUE_KEY);
         }
         if (iconValue == null) {
-            iconValue = track.getIcon();
+            iconValue = track.getActivityTypeId();
         }
 
         setActivityTypeIcon(iconValue);

src/main/java/de/dennisguse/opentracks/TrackStoppedActivity.java

@@ -66,7 +66,7 @@ public class TrackStoppedActivity extends AbstractTrackDeleteActivity implements
             }
         });
 
-        String iconValue = track.getIcon();
+        String iconValue = track.getActivityTypeId();
 
         setActivityTypeIcon(iconValue);
         viewBinding.trackEditActivityTypeIcon.setOnClickListener(v -> ChooseActivityTypeDialogFragment.showDialog(getSupportFragmentManager(), viewBinding.trackEditActivityType.getText().toString()));

src/main/java/de/dennisguse/opentracks/data/ContentProviderUtils.java

@@ -163,7 +163,7 @@ public class ContentProviderUtils {
             trackStatistics.setTotalAltitudeLoss(cursor.getFloat(altitudeLossIndex));
         }
         if (!cursor.isNull(iconIndex)) {
-            track.setIcon(cursor.getString(iconIndex));
+            track.setActivityTypeId(cursor.getString(iconIndex));
         }
         return track;
     }
@@ -308,7 +308,7 @@ public class ContentProviderUtils {
         values.put(TracksColumns.MAX_ALTITUDE, trackStatistics.getMaxAltitude());
         values.put(TracksColumns.ALTITUDE_GAIN, trackStatistics.getTotalAltitudeGain());
         values.put(TracksColumns.ALTITUDE_LOSS, trackStatistics.getTotalAltitudeLoss());
-        values.put(TracksColumns.ICON, track.getIcon());
+        values.put(TracksColumns.ICON, track.getActivityTypeId());
 
         return values;
     }

src/main/java/de/dennisguse/opentracks/data/models/Track.java

@@ -46,7 +46,7 @@ public class Track {
     private String description = "";
     private String activityType = "";
 
-    private String icon = "";
+    private String activityTypeId = "";
 
     private final ZoneOffset zoneOffset;
 
@@ -105,12 +105,12 @@ public class Track {
         this.activityType = activityType;
     }
 
-    public String getIcon() {
+    public String getActivityTypeId() {
-        return icon;
+        return activityTypeId;
     }
 
-    public void setIcon(String icon) {
+    public void setActivityTypeId(String activityTypeId) {
-        this.icon = icon;
+        this.activityTypeId = activityTypeId;
     }
 
     public ZoneOffset getZoneOffset() {

src/main/java/de/dennisguse/opentracks/io/file/exporter/KMLTrackExporter.java

@@ -307,7 +307,7 @@ public class KMLTrackExporter implements TrackExporter {
 
             printWriter.println("<name>" + StringUtils.formatCData(track.getName()) + "</name>");
             printWriter.println("<description>" + StringUtils.formatCData(track.getDescription()) + "</description>");
-            printWriter.println("<icon>" + StringUtils.formatCData(track.getIcon()) + "</icon>");
+            printWriter.println("<icon>" + StringUtils.formatCData(track.getActivityTypeId()) + "</icon>");
             printWriter.println("<opentracks:trackid>" + track.getUuid() + "</opentracks:trackid>");
 
             printWriter.println("<styleUrl>#" + TRACK_STYLE + "</styleUrl>");

src/main/java/de/dennisguse/opentracks/io/file/importer/TrackImporter.java

@@ -112,7 +112,7 @@ public class TrackImporter {
             }
         }
 
-        track.setIcon(icon != null ? icon : "");
+        track.setActivityTypeId(icon != null ? icon : "");
     }
 
     void finish() {

src/main/java/de/dennisguse/opentracks/services/TrackRecordingManager.java

@@ -72,9 +72,9 @@ class TrackRecordingManager implements SharedPreferences.OnSharedPreferenceChang
 
         onNewTrackPoint(segmentStartTrackPoint);
 
-        String category = PreferencesUtils.getDefaultActivity();
+        String category = PreferencesUtils.getDefaultActivityTypeLocalized();
         track.setActivityType(category);
-        track.setIcon(ActivityType.findByLocalizedString(context, category)
+        track.setActivityTypeId(ActivityType.findByLocalizedString(context, category)
                 .getId());
         track.setTrackStatistics(trackStatisticsUpdater.getTrackStatistics());
         //TODO Pass TrackPoint

src/main/java/de/dennisguse/opentracks/settings/ActivityTypePreference.java

@@ -46,7 +46,7 @@ public class ActivityTypePreference extends DialogPreference {
         setDialogIcon(null);
         setPersistent(true);
 
-        SummaryProvider<DialogPreference> summaryProvider = preference -> PreferencesUtils.getDefaultActivity();
+        SummaryProvider<DialogPreference> summaryProvider = preference -> PreferencesUtils.getDefaultActivityTypeLocalized();
         setSummaryProvider(summaryProvider);
     }
 
@@ -77,7 +77,7 @@ public class ActivityTypePreference extends DialogPreference {
             final Context context = getActivity();
 
             textView = view.findViewById(R.id.activity_type_preference_text_view);
-            String category = PreferencesUtils.getDefaultActivity();
+            String category = PreferencesUtils.getDefaultActivityTypeLocalized();
             textView.setText(category);
             ArrayAdapter<String> adapter = new ArrayAdapter<>(context, android.R.layout.simple_dropdown_item_1line, ActivityType.getLocalizedStrings(context));
             textView.setAdapter(adapter);
@@ -104,7 +104,7 @@ public class ActivityTypePreference extends DialogPreference {
         }
 
         private void showIconSelectDialog() {
-            String category = PreferencesUtils.getDefaultActivity();
+            String category = PreferencesUtils.getDefaultActivityTypeLocalized();
             ChooseActivityTypeDialogFragment.showDialog(getActivity().getSupportFragmentManager(), category);
         }
 
@@ -113,7 +113,7 @@ public class ActivityTypePreference extends DialogPreference {
             if (positiveResult) {
                 String newDefaultActivity = textView.getText().toString();
                 if (getPreference().callChangeListener(newDefaultActivity)) {
-                    PreferencesUtils.setDefaultActivity(newDefaultActivity);
+                    PreferencesUtils.setDefaultActivityLocalized(newDefaultActivity);
                     HackUtils.invalidatePreference(getPreference());
                 }
             }

src/main/java/de/dennisguse/opentracks/settings/PreferencesUtils.java

@@ -90,11 +90,11 @@ public class PreferencesUtils {
         sharedPreferences.unregisterOnSharedPreferenceChangeListener(changeListener);
     }
 
-    public static String getDefaultActivity() {
+    public static String getDefaultActivityTypeLocalized() {
         return getString(R.string.default_activity_key, resources.getString(R.string.default_activity_default));
     }
 
-    public static void setDefaultActivity(String newDefaultActivity) {
+    public static void setDefaultActivityLocalized(String newDefaultActivity) {
         setString(R.string.default_activity_key, newDefaultActivity);
     }
 

src/main/java/de/dennisguse/opentracks/util/TrackUtils.java

@@ -49,9 +49,9 @@ public class TrackUtils {
             update = true;
         }
         if (iconValue != null) {
-            track.setIcon(iconValue);
+            track.setActivityTypeId(iconValue);
         } else if (activityType != null) {
-            track.setIcon(ActivityType.findByLocalizedString(context, activityType)
+            track.setActivityTypeId(ActivityType.findByLocalizedString(context, activityType)
                     .getId());
         }
         if (description != null) {