From 77f03dcc282c59c01d0bfdaa4614f5a38b10e42c Mon Sep 17 00:00:00 2001 From: Dennis Guse Date: Sun, 4 Jul 2021 21:41:05 +0200 Subject: [PATCH] Translation: use Android's cancel/ok. Fix #868. --- .../de/dennisguse/opentracks/io/file/ErrorListDialog.java | 4 +--- .../opentracks/io/file/exporter/ExportActivity.java | 2 +- .../opentracks/io/file/importer/ImportActivity.java | 2 +- .../de/dennisguse/opentracks/settings/SettingsActivity.java | 2 +- src/main/res/layout/help.xml | 2 +- src/main/res/layout/import_activity.xml | 2 +- src/main/res/layout/marker_edit.xml | 2 +- src/main/res/layout/track_edit.xml | 2 +- src/main/res/values-ar/strings.xml | 2 -- src/main/res/values-b+en+001/strings.xml | 2 -- src/main/res/values-b+es+419/strings.xml | 2 -- src/main/res/values-bg/strings.xml | 2 -- src/main/res/values-ca/strings.xml | 2 -- src/main/res/values-cs/strings.xml | 2 -- src/main/res/values-da/strings.xml | 2 -- src/main/res/values-de/strings.xml | 2 -- src/main/res/values-el/strings.xml | 2 -- src/main/res/values-es/strings.xml | 2 -- src/main/res/values-et/strings.xml | 2 -- src/main/res/values-eu/strings.xml | 2 -- src/main/res/values-fa/strings.xml | 2 -- src/main/res/values-fi/strings.xml | 2 -- src/main/res/values-fr-rCA/strings.xml | 2 -- src/main/res/values-fr-rCH/strings.xml | 2 -- src/main/res/values-fr/strings.xml | 2 -- src/main/res/values-gl/strings.xml | 2 -- src/main/res/values-hi/strings.xml | 2 -- src/main/res/values-hr/strings.xml | 2 -- src/main/res/values-hu/strings.xml | 2 -- src/main/res/values-in/strings.xml | 2 -- src/main/res/values-it/strings.xml | 2 -- src/main/res/values-iw/strings.xml | 2 -- src/main/res/values-ja/strings.xml | 2 -- src/main/res/values-ko/strings.xml | 2 -- src/main/res/values-lt/strings.xml | 2 -- src/main/res/values-lv/strings.xml | 2 -- src/main/res/values-mo/strings.xml | 2 -- src/main/res/values-ms/strings.xml | 2 -- src/main/res/values-nb/strings.xml | 2 -- src/main/res/values-nl/strings.xml | 2 -- src/main/res/values-pl/strings.xml | 2 -- src/main/res/values-pt-rBR/strings.xml | 2 -- src/main/res/values-pt-rPT/strings.xml | 2 -- src/main/res/values-pt/strings.xml | 2 -- src/main/res/values-ro/strings.xml | 2 -- src/main/res/values-ru/strings.xml | 2 -- src/main/res/values-sk/strings.xml | 2 -- src/main/res/values-sl/strings.xml | 2 -- src/main/res/values-sr/strings.xml | 2 -- src/main/res/values-sv/strings.xml | 2 -- src/main/res/values-th/strings.xml | 2 -- src/main/res/values-tl/strings.xml | 2 -- src/main/res/values-tr/strings.xml | 2 -- src/main/res/values-uk/strings.xml | 2 -- src/main/res/values-vi/strings.xml | 2 -- src/main/res/values-zh-rHK/strings.xml | 2 -- src/main/res/values-zh-rTW/strings.xml | 2 -- src/main/res/values-zh/strings.xml | 2 -- src/main/res/values/strings.xml | 2 -- src/main/res/xml/settings.xml | 4 ++-- 60 files changed, 10 insertions(+), 114 deletions(-) diff --git a/src/main/java/de/dennisguse/opentracks/io/file/ErrorListDialog.java b/src/main/java/de/dennisguse/opentracks/io/file/ErrorListDialog.java index 5d000f2d9..29b48f782 100644 --- a/src/main/java/de/dennisguse/opentracks/io/file/ErrorListDialog.java +++ b/src/main/java/de/dennisguse/opentracks/io/file/ErrorListDialog.java @@ -11,8 +11,6 @@ import androidx.fragment.app.FragmentManager; import java.util.ArrayList; -import de.dennisguse.opentracks.R; - public class ErrorListDialog extends DialogFragment { public static final String TAG = ErrorListDialog.class.getSimpleName(); @@ -61,7 +59,7 @@ public class ErrorListDialog extends DialogFragment { AlertDialog.Builder alertDialogBuilder = new AlertDialog.Builder(getActivity()) .setTitle(title) .setItems(tracks, null) - .setPositiveButton(R.string.generic_ok, (dialog, which) -> dismiss()); + .setPositiveButton(android.R.string.ok, (dialog, which) -> dismiss()); return alertDialogBuilder.create(); } } diff --git a/src/main/java/de/dennisguse/opentracks/io/file/exporter/ExportActivity.java b/src/main/java/de/dennisguse/opentracks/io/file/exporter/ExportActivity.java index 95b112533..046cc1852 100644 --- a/src/main/java/de/dennisguse/opentracks/io/file/exporter/ExportActivity.java +++ b/src/main/java/de/dennisguse/opentracks/io/file/exporter/ExportActivity.java @@ -291,7 +291,7 @@ public class ExportActivity extends FragmentActivity implements ExportServiceRes private void onExportEnded() { viewBinding.exportProgressRightButton.setVisibility(View.VISIBLE); - viewBinding.exportProgressRightButton.setText(getString(R.string.generic_ok)); + viewBinding.exportProgressRightButton.setText(getString(android.R.string.ok)); viewBinding.exportProgressRightButton.setOnClickListener((view) -> finish()); viewBinding.exportProgressAlertIcon.setVisibility(View.VISIBLE); diff --git a/src/main/java/de/dennisguse/opentracks/io/file/importer/ImportActivity.java b/src/main/java/de/dennisguse/opentracks/io/file/importer/ImportActivity.java index 8afb65d17..834e782db 100644 --- a/src/main/java/de/dennisguse/opentracks/io/file/importer/ImportActivity.java +++ b/src/main/java/de/dennisguse/opentracks/io/file/importer/ImportActivity.java @@ -176,7 +176,7 @@ public class ImportActivity extends FragmentActivity { viewBinding.importProgressAlertIcon.setVisibility(View.VISIBLE); viewBinding.importProgressRightButton.setVisibility(View.VISIBLE); - viewBinding.importProgressRightButton.setText(getString(R.string.generic_ok)); + viewBinding.importProgressRightButton.setText(getString(android.R.string.ok)); viewBinding.importProgressRightButton.setOnClickListener((view) -> { getViewModelStore().clear(); finish(); diff --git a/src/main/java/de/dennisguse/opentracks/settings/SettingsActivity.java b/src/main/java/de/dennisguse/opentracks/settings/SettingsActivity.java index 63145bcee..8182d1a07 100644 --- a/src/main/java/de/dennisguse/opentracks/settings/SettingsActivity.java +++ b/src/main/java/de/dennisguse/opentracks/settings/SettingsActivity.java @@ -74,7 +74,7 @@ public class SettingsActivity extends AbstractActivity implements ChooseActivity .setIcon(R.drawable.ic_logo_24dp) .setTitle(R.string.app_name) .setMessage(R.string.export_error_post_workout) - .setNeutralButton(R.string.generic_ok, null) + .setNeutralButton(android.R.string.ok, null) .create() .show(); } diff --git a/src/main/res/layout/help.xml b/src/main/res/layout/help.xml index 7aca91fb9..99ab71700 100644 --- a/src/main/res/layout/help.xml +++ b/src/main/res/layout/help.xml @@ -97,7 +97,7 @@ style="@style/TextMedium" android:layout_width="match_parent" android:layout_height="wrap_content" - android:text="@string/generic_no" /> + android:text="@android:string/no" /> diff --git a/src/main/res/layout/marker_edit.xml b/src/main/res/layout/marker_edit.xml index 5becbdddc..ecbd65ec7 100644 --- a/src/main/res/layout/marker_edit.xml +++ b/src/main/res/layout/marker_edit.xml @@ -117,7 +117,7 @@ limitations under the License. android:id="@+id/marker_edit_cancel" style="@style/BottomButton" android:layout_gravity="start" - android:text="@string/generic_cancel" /> + android:text="@android:string/cancel" />