diff --git a/MyTracks/res/layout/share_track.xml b/MyTracks/res/layout/share_track.xml index 6512e5e4e..010c380df 100644 --- a/MyTracks/res/layout/share_track.xml +++ b/MyTracks/res/layout/share_track.xml @@ -20,10 +20,7 @@ limitations under the License. android:layout_height="wrap_content" android:layout_width="match_parent" android:orientation="vertical" - android:paddingBottom="16dp" - android:paddingLeft="8dp" - android:paddingRight="8dp" - android:paddingTop="8dp" > + android:padding="8dp"> + \ No newline at end of file diff --git a/MyTracks/res/values/keys.xml b/MyTracks/res/values/keys.xml index cab2f9f93..c6d6c681e 100644 --- a/MyTracks/res/values/keys.xml +++ b/MyTracks/res/values/keys.xml @@ -61,7 +61,6 @@ limitations under the License. autoResumeTrackCurrentRetry bluetoothSensor confirmPlayEarth - confirmShareDrive driveDeletedList driveLargestChangeId driveSync diff --git a/MyTracks/res/values/strings.xml b/MyTracks/res/values/strings.xml index 1635b5125..cfd756111 100644 --- a/MyTracks/res/values/strings.xml +++ b/MyTracks/res/values/strings.xml @@ -1528,7 +1528,7 @@ limitations under the License. translation_description="In the 'Backup and reset' settings, after pressing the 'Restore now' option, the message in the alert dialog informing the user that there is no backup to restore from. - + %1$s the directory. E.g., '/MyTracks/backups'."> No backups found in %1$s. @@ -2024,15 +2024,14 @@ limitations under the License. - - This will upload your track to Google Drive so you can share the file with friends. - Email addresses + + This will updload your track to Google Drive. + Invite people to view @@ -2093,7 +2092,7 @@ limitations under the License. - Share track + Share track via Google Drive diff --git a/MyTracks/src/com/google/android/apps/mytracks/AbstractSendToGoogleActivity.java b/MyTracks/src/com/google/android/apps/mytracks/AbstractSendToGoogleActivity.java index 09be42dc6..fd39a3c3e 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/AbstractSendToGoogleActivity.java +++ b/MyTracks/src/com/google/android/apps/mytracks/AbstractSendToGoogleActivity.java @@ -335,34 +335,26 @@ public abstract class AbstractSendToGoogleActivity extends AbstractMyTracksActiv * * @param trackId the track id */ - protected void confirmShare(long trackId) { - ConfirmDialogFragment.newInstance(R.string.confirm_share_drive_key, - PreferencesUtils.CONFIRM_SHARE_DRIVE_DEFAULT, - getString(R.string.share_track_confirm_message), new long[] { trackId }) - .show(getSupportFragmentManager(), ConfirmDialogFragment.CONFIRM_DIALOG_TAG); + protected void shareTrack(long trackId) { + AnalyticsUtils.sendPageViews(this, "/action/share_drive"); + SendRequest newRequest; + newRequest = new SendRequest(trackId); + newRequest.setSendDrive(true); + newRequest.setDriveShare(true); + sendToGoogle(newRequest); } @Override public void onConfirmDone(int confirmId, long[] trackIds) { - Intent intent; - SendRequest newRequest; - switch (confirmId) { case R.string.confirm_play_earth_key: AnalyticsUtils.sendPageViews(this, "/action/play"); - intent = IntentUtils.newIntent(this, SaveActivity.class) + Intent intent = IntentUtils.newIntent(this, SaveActivity.class) .putExtra(SaveActivity.EXTRA_TRACK_IDS, trackIds) .putExtra(SaveActivity.EXTRA_TRACK_FILE_FORMAT, (Parcelable) TrackFileFormat.KML) .putExtra(SaveActivity.EXTRA_PLAY_TRACK, true); startActivity(intent); break; - case R.string.confirm_share_drive_key: - AnalyticsUtils.sendPageViews(this, "/action/share_drive"); - newRequest = new SendRequest(trackIds[0]); - newRequest.setSendDrive(true); - newRequest.setDriveShare(true); - sendToGoogle(newRequest); - break; default: } } diff --git a/MyTracks/src/com/google/android/apps/mytracks/SearchListActivity.java b/MyTracks/src/com/google/android/apps/mytracks/SearchListActivity.java index 8f8cec470..47e9a1c6c 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/SearchListActivity.java +++ b/MyTracks/src/com/google/android/apps/mytracks/SearchListActivity.java @@ -347,7 +347,7 @@ public class SearchListActivity extends AbstractSendToGoogleActivity confirmPlay(new long[] {trackId}); return true; case R.id.list_context_menu_share: - confirmShare(trackId); + shareTrack(trackId); return true; case R.id.list_context_menu_show_on_map: intent = IntentUtils.newIntent(this, TrackDetailActivity.class) diff --git a/MyTracks/src/com/google/android/apps/mytracks/TrackDetailActivity.java b/MyTracks/src/com/google/android/apps/mytracks/TrackDetailActivity.java index 7be2f04f0..50d89fd1d 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/TrackDetailActivity.java +++ b/MyTracks/src/com/google/android/apps/mytracks/TrackDetailActivity.java @@ -340,7 +340,7 @@ public class TrackDetailActivity extends AbstractSendToGoogleActivity confirmPlay(new long[] {trackId}); return true; case R.id.track_detail_share: - confirmShare(trackId); + shareTrack(trackId); return true; case R.id.track_detail_markers: intent = IntentUtils.newIntent(this, MarkerListActivity.class) diff --git a/MyTracks/src/com/google/android/apps/mytracks/TrackListActivity.java b/MyTracks/src/com/google/android/apps/mytracks/TrackListActivity.java index 0e24370c8..e690a2cb2 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/TrackListActivity.java +++ b/MyTracks/src/com/google/android/apps/mytracks/TrackListActivity.java @@ -770,7 +770,7 @@ public class TrackListActivity extends AbstractSendToGoogleActivity confirmPlay(trackIds); return true; case R.id.list_context_menu_share: - confirmShare(trackIds[0]); + shareTrack(trackIds[0]); return true; case R.id.list_context_menu_edit: Intent intent = IntentUtils.newIntent(this, TrackEditActivity.class) diff --git a/MyTracks/src/com/google/android/apps/mytracks/io/backup/PreferenceBackupHelper.java b/MyTracks/src/com/google/android/apps/mytracks/io/backup/PreferenceBackupHelper.java index 91ebe900b..cd8375906 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/io/backup/PreferenceBackupHelper.java +++ b/MyTracks/src/com/google/android/apps/mytracks/io/backup/PreferenceBackupHelper.java @@ -52,7 +52,6 @@ public class PreferenceBackupHelper { doNotBackup.add(context.getString(R.string.auto_resume_track_current_retry_key)); doNotBackup.add(context.getString(R.string.bluetooth_sensor_key)); doNotBackup.add(context.getString(R.string.confirm_play_earth_key)); - doNotBackup.add(context.getString(R.string.confirm_share_drive_key)); doNotBackup.add(context.getString(R.string.drive_deleted_list_key)); doNotBackup.add(context.getString(R.string.drive_largest_change_id_key)); doNotBackup.add(context.getString(R.string.drive_sync_key)); diff --git a/MyTracks/src/com/google/android/apps/mytracks/util/PreferencesUtils.java b/MyTracks/src/com/google/android/apps/mytracks/util/PreferencesUtils.java index 5bb4bbaec..8d54360ef 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/util/PreferencesUtils.java +++ b/MyTracks/src/com/google/android/apps/mytracks/util/PreferencesUtils.java @@ -58,7 +58,6 @@ public class PreferencesUtils { public static final boolean CHART_SHOW_SPEED_DEFAULT = true; public static final boolean CONFIRM_PLAY_EARTH_DEFAULT = true; - public static final boolean CONFIRM_SHARE_DRIVE_DEFAULT = true; public static final String DEFAULT_ACTIVITY_DEFAULT = ""; diff --git a/MyTracksTest_E2E/src/com/google/android/apps/mytracks/endtoendtest/common/ShareTest.java b/MyTracksTest_E2E/src/com/google/android/apps/mytracks/endtoendtest/common/ShareTest.java index 137e33644..3cf484df3 100644 --- a/MyTracksTest_E2E/src/com/google/android/apps/mytracks/endtoendtest/common/ShareTest.java +++ b/MyTracksTest_E2E/src/com/google/android/apps/mytracks/endtoendtest/common/ShareTest.java @@ -49,20 +49,6 @@ public class ShareTest extends ActivityInstrumentationTestCase2