From 920f8e418034f2dfbce3c1063a4a9543f5059bd3 Mon Sep 17 00:00:00 2001 From: youtaol Date: Tue, 24 Apr 2012 19:25:45 +0800 Subject: [PATCH] Change the way to generate the SQL statement to fix http://code.google.com/p/mytracks/issues/detail?id=907. --- .../content/MyTracksProviderUtilsImpl.java | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/MyTracksLib/src/com/google/android/apps/mytracks/content/MyTracksProviderUtilsImpl.java b/MyTracksLib/src/com/google/android/apps/mytracks/content/MyTracksProviderUtilsImpl.java index ee4cc81b6..1dc2b8a6f 100644 --- a/MyTracksLib/src/com/google/android/apps/mytracks/content/MyTracksProviderUtilsImpl.java +++ b/MyTracksLib/src/com/google/android/apps/mytracks/content/MyTracksProviderUtilsImpl.java @@ -851,12 +851,15 @@ public class MyTracksProviderUtilsImpl implements MyTracksProviderUtils { } String selection; + String[] selectionArgs; if (minTrackPointId >= 0) { - selection = String.format("%s=%d AND %s%s%d", - TrackPointsColumns.TRACKID, trackId, TrackPointsColumns._ID, - descending ? "<=" : ">=", minTrackPointId); + String comparison = descending ? "<=" : ">="; + selection = TrackPointsColumns.TRACKID + "=? AND " + TrackPointsColumns._ID + comparison + + "?"; + selectionArgs = new String[] { String.valueOf(trackId), String.valueOf(minTrackPointId) }; } else { - selection = String.format("%s=%d", TrackPointsColumns.TRACKID, trackId); + selection = TrackPointsColumns.TRACKID + "=?"; + selectionArgs = new String[] { String.valueOf(trackId) }; } String sortOrder = "_id " + (descending ? "DESC" : "ASC"); @@ -864,7 +867,7 @@ public class MyTracksProviderUtilsImpl implements MyTracksProviderUtils { sortOrder += " LIMIT " + maxLocations; } - return contentResolver.query(TrackPointsColumns.CONTENT_URI, null, selection, null, sortOrder); + return contentResolver.query(TrackPointsColumns.CONTENT_URI, null, selection, selectionArgs, sortOrder); } @Override @@ -1087,4 +1090,4 @@ public class MyTracksProviderUtilsImpl implements MyTracksProviderUtils { void setDefaultCursorBatchSize(int defaultCursorBatchSize) { this.defaultCursorBatchSize = defaultCursorBatchSize; } -} +} \ No newline at end of file