From 9b97cdfcd1539d13036914c2ab91c6177fa0b0d5 Mon Sep 17 00:00:00 2001
From: Dennis Guse <dennis.guse@alumni.tu-berlin.de>
Date: Sun, 12 Apr 2020 21:18:36 +0200
Subject: [PATCH] TrackRecordingService: cleanup.

if+return rather than if+else.
---
 .../services/TrackRecordingService.java       | 29 +++++++++++++++----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java
index 3d8a0e1a7..87cf1bb9d 100644
--- a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java
+++ b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java
@@ -588,6 +588,7 @@ public class TrackRecordingService extends Service {
         if (TrackPointUtils.after(trackPoint, lastValidTrackPoint)) {
             idleTime = trackPoint.getTime() - lastValidTrackPoint.getLocation().getTime();
         }
+
         locationListenerPolicy.updateIdleTime(idleTime);
         if (currentRecordingInterval != locationListenerPolicy.getDesiredPollingInterval()) {
             registerLocationListener();
@@ -615,21 +616,39 @@ public class TrackRecordingService extends Service {
 
             insertTrackPoint(track, trackPoint, null);
             isIdle = false;
-        } else if (trackPoint.getSensorDataSet() != null || distanceToLastTrackLocation >= recordingDistanceInterval) {
+
+            lastTrackPoint = trackPoint;
+            return;
+        }
+
+        if (trackPoint.getSensorDataSet() != null || distanceToLastTrackLocation >= recordingDistanceInterval) {
             insertTrackPoint(track, lastTrackPoint, lastValidTrackPoint);
             insertTrackPoint(track, trackPoint, null);
             isIdle = false;
-        } else if (!isIdle && !TrackPointUtils.isMoving(trackPoint)) {
+
+            lastTrackPoint = trackPoint;
+            return;
+        }
+
+        if (!isIdle && !TrackPointUtils.isMoving(trackPoint)) {
             insertTrackPoint(track, lastTrackPoint, lastValidTrackPoint);
             insertTrackPoint(track, trackPoint, null);
             isIdle = true;
-        } else if (isIdle && TrackPointUtils.isMoving(trackPoint)) {
+
+            lastTrackPoint = trackPoint;
+            return;
+        }
+
+        if (isIdle && TrackPointUtils.isMoving(trackPoint)) {
             insertTrackPoint(track, lastTrackPoint, lastValidTrackPoint);
             insertTrackPoint(track, trackPoint, null);
             isIdle = false;
-        } else {
-            Log.d(TAG, "Not recording TrackPoint, idle");
+
+            lastTrackPoint = trackPoint;
+            return;
         }
+
+        Log.d(TAG, "Not recording TrackPoint, idle");
         lastTrackPoint = trackPoint;
     }