Cleanup: use lambda instead of runnable.

src/main/java/de/dennisguse/opentracks/MarkerDetailActivity.java

@@ -109,12 +109,7 @@ public class MarkerDetailActivity extends AbstractActivity implements DeleteMark
 
     @Override
     public void onDeleteMarkerDone() {
-        runOnUiThread(new Runnable() {
+        runOnUiThread(this::finish);
-            @Override
-            public void run() {
-                finish();
-            }
-        });
     }
 
     /**

src/main/java/de/dennisguse/opentracks/MarkerListActivity.java

@@ -82,12 +82,7 @@ public class MarkerListActivity extends AbstractActivity implements DeleteMarker
                 recordingTrackPaused = PreferencesUtils.isRecordingTrackPaused(MarkerListActivity.this);
             }
             if (key != null) {
-                runOnUiThread(new Runnable() {
+                runOnUiThread(() -> MarkerListActivity.this.invalidateOptionsMenu());
-                    @Override
-                    public void run() {
-                        MarkerListActivity.this.invalidateOptionsMenu();
-                    }
-                });
             }
         }
     };

src/main/java/de/dennisguse/opentracks/SearchListActivity.java

@@ -153,12 +153,7 @@ public class SearchListActivity extends AbstractListActivity implements DeleteMa
                 recordingTrackPaused = PreferencesUtils.isRecordingTrackPaused(SearchListActivity.this);
             }
             if (key != null) {
-                runOnUiThread(new Runnable() {
+                runOnUiThread(() -> arrayAdapter.notifyDataSetChanged());
-                    @Override
-                    public void run() {
-                        arrayAdapter.notifyDataSetChanged();
-                    }
-                });
             }
         }
     };
@@ -346,12 +341,9 @@ public class SearchListActivity extends AbstractListActivity implements DeleteMa
         final List<Map<String, Object>> displayResults = prepareResultsforDisplay(scoredResults);
 
         // Use the UI thread to display the results
-        runOnUiThread(new Runnable() {
+        runOnUiThread(() -> {
-            @Override
-            public void run() {
             arrayAdapter.clear();
             arrayAdapter.addAll(displayResults);
-            }
         });
     }
 
@@ -448,12 +440,7 @@ public class SearchListActivity extends AbstractListActivity implements DeleteMa
 
     @Override
     public void onDeleteMarkerDone() {
-        runOnUiThread(new Runnable() {
+        runOnUiThread(() -> handleIntent(getIntent()));
-            @Override
-            public void run() {
-                handleIntent(getIntent());
-            }
-        });
     }
 
     @Override
@@ -463,11 +450,6 @@ public class SearchListActivity extends AbstractListActivity implements DeleteMa
 
     @Override
     protected void onDeleted() {
-        runOnUiThread(new Runnable() {
+        runOnUiThread(() -> handleIntent(getIntent()));
-            @Override
-            public void run() {
-                handleIntent(getIntent());
-            }
-        });
     }
 }

src/main/java/de/dennisguse/opentracks/TrackListActivity.java

@@ -143,14 +143,11 @@ public class TrackListActivity extends AbstractListActivity implements ConfirmDe
                 recordingTrackPaused = PreferencesUtils.isRecordingTrackPaused(TrackListActivity.this);
             }
             if (key != null) {
-                runOnUiThread(new Runnable() {
+                runOnUiThread(() -> {
-                    @Override
-                    public void run() {
                     TrackListActivity.this.invalidateOptionsMenu();
                     LoaderManager.getInstance(TrackListActivity.this).restartLoader(0, null, loaderCallbacks);
                     boolean isRecording = PreferencesUtils.isRecording(recordingTrackId);
                     trackController.update(isRecording, recordingTrackPaused);
-                    }
                 });
             }
         }
@@ -177,12 +174,7 @@ public class TrackListActivity extends AbstractListActivity implements ConfirmDe
             /*
              * After binding changes (e.g., becomes available), update the total time in trackController.
              */
-            runOnUiThread(new Runnable() {
+            runOnUiThread(() -> trackController.update(PreferencesUtils.isRecording(recordingTrackId), recordingTrackPaused));
-                @Override
-                public void run() {
-                    trackController.update(PreferencesUtils.isRecording(recordingTrackId), recordingTrackPaused);
-                }
-            });
 
             if (!startGps) {
                 return;

src/main/java/de/dennisguse/opentracks/TrackRecordedActivity.java

@@ -16,7 +16,6 @@
 
 package de.dennisguse.opentracks;
 
-import android.app.ActivityOptions;
 import android.content.Intent;
 import android.os.Bundle;
 import android.util.Log;
@@ -226,12 +225,7 @@ public class TrackRecordedActivity extends AbstractListActivity implements Choos
 
     @Override
     protected void onDeleted() {
-        runOnUiThread(new Runnable() {
+        runOnUiThread(this::finish);
-            @Override
-            public void run() {
-                finish();
-            }
-        });
     }
 
     /**
@@ -259,7 +253,6 @@ public class TrackRecordedActivity extends AbstractListActivity implements Choos
         if (trackId == -1L) {
             Log.e(TAG, "TrackDetailActivity needs EXTRA_TRACK_ID.");
             finish();
-            return;
         }
     }
 

src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java

@@ -1,6 +1,5 @@
 package de.dennisguse.opentracks;
 
-import android.app.ActivityOptions;
 import android.content.Intent;
 import android.content.SharedPreferences;
 import android.content.SharedPreferences.OnSharedPreferenceChangeListener;
@@ -68,12 +67,7 @@ public class TrackRecordingActivity extends AbstractActivity implements ChooseAc
         @Override
         public void run() {
             // After binding changes (is available), update the total time in trackController.
-            runOnUiThread(new Runnable() {
+            runOnUiThread(() -> trackController.update(true, recordingTrackPaused));
-                @Override
-                public void run() {
-                    trackController.update(true, recordingTrackPaused);
-                }
-            });
 
             if (recordingTrackId == -1L) {
                 TrackRecordingServiceInterface service = trackRecordingServiceConnection.getServiceIfBound();
@@ -130,12 +124,9 @@ public class TrackRecordingActivity extends AbstractActivity implements ChooseAc
 
             if (key == null) return;
 
-            runOnUiThread(new Runnable() {
+            runOnUiThread(() -> {
-                @Override
-                public void run() {
                 TrackRecordingActivity.this.invalidateOptionsMenu();
                 trackController.update(true, recordingTrackPaused);
-                }
             });
         }
     };

src/main/java/de/dennisguse/opentracks/content/TrackDataHub.java

@@ -144,13 +144,10 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL
 
         PreferencesUtils.register(context, this);
         onSharedPreferenceChanged(null, null);
-        runInHandlerThread(new Runnable() {
+        runInHandlerThread(() -> {
-            @Override
-            public void run() {
             if (started) {
                 loadDataForAll();
             }
-            }
         });
     }
 
@@ -178,16 +175,13 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL
     }
 
     public void loadTrack(final long trackId) {
-        runInHandlerThread(new Runnable() {
+        runInHandlerThread(() -> {
-            @Override
-            public void run() {
             if (trackId == selectedTrackId) {
                 Log.i(TAG, "Not reloading track " + trackId);
                 return;
             }
             selectedTrackId = trackId;
             loadDataForAll();
-            }
         });
     }
 
@@ -197,14 +191,11 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL
      * @param trackDataListener the track data listener
      */
     public void registerTrackDataListener(final TrackDataListener trackDataListener, final boolean tracksTable, final boolean waypointsTable, final boolean trackPointsTable_SampleIn, final boolean trackPointsTable_SampleOut) {
-        runInHandlerThread(new Runnable() {
+        runInHandlerThread(() -> {
-            @Override
-            public void run() {
             trackDataManager.registerTrackDataListener(trackDataListener, tracksTable, waypointsTable, trackPointsTable_SampleIn, trackPointsTable_SampleOut);
             if (started) {
                 loadDataForListener(trackDataListener);
             }
-            }
         });
     }
 
@@ -214,12 +205,7 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL
      * @param trackDataListener the track data listener
      */
     public void unregisterTrackDataListener(final TrackDataListener trackDataListener) {
-        runInHandlerThread(new Runnable() {
+        runInHandlerThread(() -> trackDataManager.unregisterTrackDataListener(trackDataListener));
-            @Override
-            public void run() {
-                trackDataManager.unregisterTrackDataListener(trackDataListener);
-            }
-        });
     }
 
     /**
@@ -238,16 +224,13 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL
 
     @Override
     public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, final String key) {
-        runInHandlerThread(new Runnable() {
+        runInHandlerThread(() -> {
-            @Override
-            public void run() {
             if (PreferencesUtils.isKey(context, R.string.recording_track_id_key, key)) {
                 recordingTrackId = PreferencesUtils.getRecordingTrackId(context);
             }
             if (PreferencesUtils.isKey(context, R.string.recording_track_paused_key, key)) {
                 recordingTrackPaused = PreferencesUtils.isRecordingTrackPaused(context);
             }
-            }
         });
     }
 
@@ -289,7 +272,7 @@ public class TrackDataHub implements SharedPreferences.OnSharedPreferenceChangeL
             if (isOnlyListener) {
                 resetSamplingState();
             }
-            Set<TrackDataListener> sampledOutListeners = hasSampledOut ? trackDataListeners : Collections.<TrackDataListener>emptySet();
+            Set<TrackDataListener> sampledOutListeners = hasSampledOut ? trackDataListeners : Collections.emptySet();
             notifyTrackPointsTableUpdate(isOnlyListener, trackDataListeners, sampledOutListeners);
         }
 

src/main/java/de/dennisguse/opentracks/fragments/ChartFragment.java

@@ -90,13 +90,10 @@ public class ChartFragment extends Fragment implements TrackDataListener {
                 boolean metricUnits = PreferencesUtils.isMetricUnits(getContext());
                 if (metricUnits != chartView.getMetricUnits()) {
                     chartView.setMetricUnits(metricUnits);
-                    runOnUiThread(new Runnable() {
+                    runOnUiThread(() -> {
-                        @Override
-                        public void run() {
                         if (isResumed()) {
                             chartView.requestLayout();
                         }
-                        }
                     });
                 }
             }
@@ -106,13 +103,10 @@ public class ChartFragment extends Fragment implements TrackDataListener {
                     chartView.setReportSpeed(reportSpeed);
                     chartView.applyReportSpeed();
 
-                    runOnUiThread(new Runnable() {
+                    runOnUiThread(() -> {
-                        @Override
-                        public void run() {
                         if (isResumed()) {
                             chartView.requestLayout();
                         }
-                        }
                     });
                 }
             }
@@ -214,13 +208,10 @@ public class ChartFragment extends Fragment implements TrackDataListener {
             trackStatisticsUpdater = startTime != -1L ? new TrackStatisticsUpdater(startTime) : null;
             pendingPoints.clear();
             chartView.reset();
-            runOnUiThread(new Runnable() {
+            runOnUiThread(() -> {
-                @Override
-                public void run() {
                 if (isResumed()) {
                     chartView.resetScroll();
                 }
-                }
             });
         }
     }

src/main/java/de/dennisguse/opentracks/fragments/DeleteMarkerDialogFragment.java

@@ -80,15 +80,12 @@ public class DeleteMarkerDialogFragment extends DialogFragment {
                 fragmentActivity, titleId, getString(messageId), new DialogInterface.OnClickListener() {
                     @Override
                     public void onClick(DialogInterface dialog, int which) {
-                        new Thread(new Runnable() {
+                        new Thread(() -> {
-                            @Override
-                            public void run() {
                             ContentProviderUtils contentProviderUtils = new ContentProviderUtils(fragmentActivity);
                             for (long markerId : markerIds) {
                                 contentProviderUtils.deleteWaypoint(getContext(), markerId);
                             }
                             caller.onDeleteMarkerDone();
-                            }
                         }).start();
                     }
                 });

src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordedFragment.java

@@ -59,13 +59,10 @@ public class StatisticsRecordedFragment extends Fragment implements TrackDataLis
         public void onSharedPreferenceChanged(SharedPreferences preferences, String key) {
             if (PreferencesUtils.isKey(getContext(), R.string.stats_units_key, key) || PreferencesUtils.isKey(getContext(), R.string.stats_rate_key, key)) {
                 if (isResumed()) {
-                    getActivity().runOnUiThread(new Runnable() {
+                    getActivity().runOnUiThread(() -> {
-                        @Override
-                        public void run() {
                         if (isResumed()) {
                             updateUI();
                         }
-                        }
                     });
                 }
             }
@@ -195,15 +192,12 @@ public class StatisticsRecordedFragment extends Fragment implements TrackDataLis
     @Override
     public void onTrackUpdated(final Track track) {
         if (isResumed()) {
-            getActivity().runOnUiThread(new Runnable() {
+            getActivity().runOnUiThread(() -> {
-                @Override
-                public void run() {
                 if (isResumed()) {
                     trackStatistics = track != null ? track.getTrackStatistics() : null;
                     category = track != null ? track.getCategory() : "";
                     updateUI();
                 }
-                }
             });
         }
     }

src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordingFragment.java

@@ -68,13 +68,10 @@ public class StatisticsRecordingFragment extends Fragment implements TrackDataLi
         public void onSharedPreferenceChanged(SharedPreferences preferences, String key) {
             if (PreferencesUtils.isKey(getContext(), R.string.stats_units_key, key) || PreferencesUtils.isKey(getContext(), R.string.stats_rate_key, key)) {
                 if (isResumed()) {
-                    getActivity().runOnUiThread(new Runnable() {
+                    getActivity().runOnUiThread(() -> {
-                        @Override
-                        public void run() {
                         if (isResumed()) {
                             updateUI();
                         }
-                        }
                     });
                 }
             }
@@ -308,15 +305,12 @@ public class StatisticsRecordingFragment extends Fragment implements TrackDataLi
     @Override
     public void onTrackUpdated(final Track track) {
         if (isResumed()) {
-            getActivity().runOnUiThread(new Runnable() {
+            getActivity().runOnUiThread(() -> {
-                @Override
-                public void run() {
                 if (isResumed()) {
                     lastTrackStatistics = track != null ? track.getTrackStatistics() : null;
                     category = track != null ? track.getCategory() : "";
                     updateUI();
                 }
-                }
             });
         }
     }
@@ -339,9 +333,7 @@ public class StatisticsRecordingFragment extends Fragment implements TrackDataLi
     @Override
     public void onNewTrackPointsDone() {
         if (isResumed()) {
-            getActivity().runOnUiThread(new Runnable() {
+            getActivity().runOnUiThread(() -> {
-                @Override
-                public void run() {
                 if (isResumed()) {
                     if (!isSelectedTrackRecording() || isSelectedTrackPaused()) {
                         lastTrackPoint = null;
@@ -357,7 +349,6 @@ public class StatisticsRecordingFragment extends Fragment implements TrackDataLi
                     }
                     setLocationValues();
                 }
-                }
             });
         }
     }

src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java

@@ -150,12 +150,7 @@ public class TrackRecordingService extends Service {
             if (locationExecutorService == null || locationExecutorService.isShutdown() || locationExecutorService.isTerminated()) {
                 return;
             }
-            locationExecutorService.submit(new Runnable() {
+            locationExecutorService.submit(() -> onLocationChangedAsync(location));
-                @Override
-                public void run() {
-                    onLocationChangedAsync(location);
-                }
-            });
         }
 
         @Override

src/main/java/de/dennisguse/opentracks/settings/SettingsActivity.java

@@ -60,20 +60,10 @@ public class SettingsActivity extends AppCompatActivity implements ChooseActivit
             @Override
             public void onSharedPreferenceChanged(SharedPreferences preferences, String key) {
                 if (PreferencesUtils.isKey(getActivity(), R.string.recording_track_id_key, key)) {
-                    getActivity().runOnUiThread(new Runnable() {
+                    getActivity().runOnUiThread(() -> updateReset());
-                        @Override
-                        public void run() {
-                            updateReset();
-                        }
-                    });
                 }
                 if (PreferencesUtils.isKey(getActivity(), R.string.stats_units_key, key)) {
-                    getActivity().runOnUiThread(new Runnable() {
+                    getActivity().runOnUiThread(() -> updateUnits());
-                        @Override
-                        public void run() {
-                            updateUnits();
-                        }
-                    });
                 }
             }
         };

src/main/java/de/dennisguse/opentracks/util/BluetoothUtils.java

@@ -61,14 +61,11 @@ public class BluetoothUtils {
         final Object mutex = new Object();
 
         Handler handler = new Handler(Looper.getMainLooper());
-        handler.post(new Runnable() {
+        handler.post(() -> {
-            @Override
-            public void run() {
             adapters.add(BluetoothAdapter.getDefaultAdapter());
             synchronized (mutex) {
                 mutex.notify();
             }
-            }
         });
 
         while (adapters.isEmpty()) {