Addressed Rodrigo's comments.

This commit is contained in:
Bartlomiej Niechwiej
2010-11-24 16:26:12 -08:00
parent 4d80af4e06
commit a4f855ccd8
2 changed files with 44 additions and 9 deletions
@@ -227,7 +227,9 @@ public class MyTracks extends TabActivity implements OnTouchListener,
} }
try { try {
return trackRecordingService.isRecording(); return trackRecordingService.isRecording();
} catch (Exception e) { // TODO: Emergency fix. // TODO: We catch Exception, because after eliminating the service process
// all exceptions it may throw are no longer wrapped in a RemoteException.
} catch (Exception e) {
Log.e(MyTracksConstants.TAG, "MyTracks: Remote exception.", e); Log.e(MyTracksConstants.TAG, "MyTracks: Remote exception.", e);
// Fall back to alternative check method. // Fall back to alternative check method.
@@ -907,7 +909,9 @@ public class MyTracks extends TabActivity implements OnTouchListener,
Log.e(MyTracksConstants.TAG, "Cannot insert waypoint marker?"); Log.e(MyTracksConstants.TAG, "Cannot insert waypoint marker?");
return -4; return -4;
} }
} catch (Exception e) { // TODO: Emergency fix. // TODO: We catch Exception, because after eliminating the service process
// all exceptions it may throw are no longer wrapped in a RemoteException.
} catch (Exception e) {
Toast.makeText(this, R.string.error_unable_to_insert_marker, Toast.makeText(this, R.string.error_unable_to_insert_marker,
Toast.LENGTH_LONG).show(); Toast.LENGTH_LONG).show();
Log.e(MyTracksConstants.TAG, "Cannot insert waypoint marker.", e); Log.e(MyTracksConstants.TAG, "Cannot insert waypoint marker.", e);
@@ -947,7 +951,9 @@ public class MyTracks extends TabActivity implements OnTouchListener,
Log.e(MyTracksConstants.TAG, "Cannot insert statistics marker?"); Log.e(MyTracksConstants.TAG, "Cannot insert statistics marker?");
return -4; return -4;
} }
} catch (Exception e) { // TODO: Emergency fix. // TODO: We catch Exception, because after eliminating the service process
// all exceptions it may throw are no longer wrapped in a RemoteException.
} catch (Exception e) {
Toast.makeText(this, R.string.error_unable_to_insert_marker, Toast.makeText(this, R.string.error_unable_to_insert_marker,
Toast.LENGTH_LONG).show(); Toast.LENGTH_LONG).show();
Log.e(MyTracksConstants.TAG, "Cannot insert statistics marker?", e); Log.e(MyTracksConstants.TAG, "Cannot insert statistics marker?", e);
@@ -1015,7 +1021,9 @@ public class MyTracks extends TabActivity implements OnTouchListener,
setSelectedTrackId(recordingTrackId); setSelectedTrackId(recordingTrackId);
Toast.makeText(this, getString(R.string.status_now_recording), Toast.makeText(this, getString(R.string.status_now_recording),
Toast.LENGTH_SHORT).show(); Toast.LENGTH_SHORT).show();
} catch (Exception e) { // TODO: Emergency fix. // TODO: We catch Exception, because after eliminating the service process
// all exceptions it may throw are no longer wrapped in a RemoteException.
} catch (Exception e) {
Toast.makeText(this, Toast.makeText(this,
getString(R.string.error_unable_to_start_recording), getString(R.string.error_unable_to_start_recording),
Toast.LENGTH_SHORT).show(); Toast.LENGTH_SHORT).show();
@@ -1048,7 +1056,9 @@ public class MyTracks extends TabActivity implements OnTouchListener,
long currentTrackId = recordingTrackId; long currentTrackId = recordingTrackId;
try { try {
trackRecordingService.endCurrentTrack(); trackRecordingService.endCurrentTrack();
} catch (Exception e) { // TODO: Emergency fix. // TODO: We catch Exception, because after eliminating the service process
// all exceptions it may throw are no longer wrapped in a RemoteException.
} catch (Exception e) {
Log.e(MyTracksConstants.TAG, "Unable to stop recording.", e); Log.e(MyTracksConstants.TAG, "Unable to stop recording.", e);
} }
Intent intent = new Intent(MyTracks.this, MyTracksDetails.class); Intent intent = new Intent(MyTracks.this, MyTracksDetails.class);
@@ -725,8 +725,7 @@ public class TrackRecordingService extends Service implements LocationListener {
locationManager = null; locationManager = null;
notificationManager = null; notificationManager = null;
providerUtils = null; providerUtils = null;
// TODO: Emergency fix to avoid NPE for buggy activities. binder.detachFromService();
//binder.detachFromService();
binder = null; binder = null;
// This should be the last operation. // This should be the last operation.
@@ -936,21 +935,33 @@ public class TrackRecordingService extends Service implements LocationListener {
@Override @Override
public boolean isRecording() { public boolean isRecording() {
if (service == null) {
throw new IllegalStateException("The service has been already detached!");
}
return service.isRecording(); return service.isRecording();
} }
@Override @Override
public long getRecordingTrackId() { public long getRecordingTrackId() {
if (service == null) {
throw new IllegalStateException("The service has been already detached!");
}
return service.recordingTrackId; return service.recordingTrackId;
} }
@Override @Override
public boolean hasRecorded() { public boolean hasRecorded() {
if (service == null) {
throw new IllegalStateException("The service has been already detached!");
}
return service.providerUtils.getLastTrackId() >= 0; return service.providerUtils.getLastTrackId() >= 0;
} }
@Override @Override
public long startNewTrack() { public long startNewTrack() {
if (service == null) {
throw new IllegalStateException("The service has been already detached!");
}
return service.startNewTrack(); return service.startNewTrack();
} }
@@ -963,6 +974,9 @@ public class TrackRecordingService extends Service implements LocationListener {
*/ */
@Override @Override
public long insertWaypointMarker(Waypoint waypoint) { public long insertWaypointMarker(Waypoint waypoint) {
if (service == null) {
throw new IllegalStateException("The service has been already detached!");
}
return service.insertWaypointMarker(waypoint); return service.insertWaypointMarker(waypoint);
} }
@@ -975,25 +989,36 @@ public class TrackRecordingService extends Service implements LocationListener {
*/ */
@Override @Override
public long insertStatisticsMarker(Location location) { public long insertStatisticsMarker(Location location) {
if (service == null) {
throw new IllegalStateException("The service has been already detached!");
}
return service.insertStatisticsMarker(location); return service.insertStatisticsMarker(location);
} }
@Override @Override
public void endCurrentTrack() { public void endCurrentTrack() {
if (service == null) {
throw new IllegalStateException("The service has been already detached!");
}
service.endCurrentTrack(); service.endCurrentTrack();
} }
@Override @Override
public void deleteAllTracks() { public void deleteAllTracks() {
if (service == null) {
throw new IllegalStateException("The service has been already detached!");
}
if (isRecording()) { if (isRecording()) {
throw new IllegalStateException( throw new IllegalStateException("Cannot delete all tracks while recording!");
"Cannot delete all tracks while recording!");
} }
service.providerUtils.deleteAllTracks(); service.providerUtils.deleteAllTracks();
} }
@Override @Override
public void recordLocation(Location loc) { public void recordLocation(Location loc) {
if (service == null) {
throw new IllegalStateException("The service has been already detached!");
}
service.onLocationChanged(loc); service.onLocationChanged(loc);
} }
} }