diff --git a/src/androidTest/java/de/dennisguse/opentracks/data/ShareContentProviderTest.java b/src/androidTest/java/de/dennisguse/opentracks/data/ShareContentProviderTest.java index a8c6f16d2..d7e63f348 100644 --- a/src/androidTest/java/de/dennisguse/opentracks/data/ShareContentProviderTest.java +++ b/src/androidTest/java/de/dennisguse/opentracks/data/ShareContentProviderTest.java @@ -7,7 +7,6 @@ import android.util.Pair; import org.junit.Test; -import java.util.HashSet; import java.util.Set; import de.dennisguse.opentracks.data.models.Track; @@ -24,10 +23,7 @@ public class ShareContentProviderTest { @Test public void testCreateAndParseURI_valid() { - Set trackIds = new HashSet<>(); - trackIds.add(new Track.Id(1)); - trackIds.add(new Track.Id(3)); - trackIds.add(new Track.Id(5)); + Set trackIds = Set.of(new Track.Id(1), new Track.Id(3), new Track.Id(5)); Pair shareURIandMIME = ShareContentProvider.createURI(trackIds, "filename.suffix", TrackFileFormat.KML_WITH_TRACKDETAIL_AND_SENSORDATA); @@ -36,9 +32,7 @@ public class ShareContentProviderTest { @Test public void testCreateURIescapeFilename() { - Set trackIds = new HashSet<>(); - trackIds.add(new Track.Id(1)); - Pair shareURIandMIME = ShareContentProvider.createURI(trackIds, "../../&1=1", TrackFileFormat.KML_WITH_TRACKDETAIL_AND_SENSORDATA); + Pair shareURIandMIME = ShareContentProvider.createURI(Set.of(new Track.Id(1)), "../../&1=1", TrackFileFormat.KML_WITH_TRACKDETAIL_AND_SENSORDATA); assertEquals(Uri.parse("content://de.dennisguse.opentracks.debug.content/tracks/KML_WITH_TRACKDETAIL_AND_SENSORDATA/1/..%2F..%2F%261%3D1"), shareURIandMIME.first); } diff --git a/src/main/java/de/dennisguse/opentracks/data/ShareContentProvider.java b/src/main/java/de/dennisguse/opentracks/data/ShareContentProvider.java index d2c59f6ae..4e5b3b9f3 100644 --- a/src/main/java/de/dennisguse/opentracks/data/ShareContentProvider.java +++ b/src/main/java/de/dennisguse/opentracks/data/ShareContentProvider.java @@ -24,6 +24,7 @@ import java.util.Collections; import java.util.HashSet; import java.util.List; import java.util.Set; +import java.util.stream.Collectors; import de.dennisguse.opentracks.data.models.Track; import de.dennisguse.opentracks.data.tables.TracksColumns; @@ -72,9 +73,7 @@ public class ShareContentProvider extends CustomContentProvider { * @return An URI for one file containing this tracks. */ public static Pair createURI(Track.Id trackId, String trackName, @NonNull TrackFileFormat trackFileFormat) { - Set trackIds = new HashSet<>(1); - trackIds.add(trackId); - return createURI(trackIds, trackName, trackFileFormat); + return createURI(Set.of(trackId), trackName, trackFileFormat); } /** @@ -108,11 +107,7 @@ public class ShareContentProvider extends CustomContentProvider { String[] uriTrackIds = uriPaths.get(2).split(TRACKID_DELIMITER); - Set trackIds = new HashSet<>(); - for (String uriTrackId : uriTrackIds) { - trackIds.add(new Track.Id(Long.parseLong(uriTrackId))); - } - return trackIds; + return Arrays.stream(uriTrackIds).map(uriTrackId -> new Track.Id(Long.parseLong(uriTrackId))).collect(Collectors.toSet()); } /** diff --git a/src/main/java/de/dennisguse/opentracks/data/TrackDataHub.java b/src/main/java/de/dennisguse/opentracks/data/TrackDataHub.java index 0182022ba..def843c74 100644 --- a/src/main/java/de/dennisguse/opentracks/data/TrackDataHub.java +++ b/src/main/java/de/dennisguse/opentracks/data/TrackDataHub.java @@ -25,14 +25,12 @@ import android.os.HandlerThread; import android.util.Log; import androidx.annotation.NonNull; -import androidx.annotation.Nullable; import androidx.annotation.VisibleForTesting; import java.util.Collections; import java.util.HashSet; import java.util.Set; -import de.dennisguse.opentracks.data.models.Altitude; import de.dennisguse.opentracks.data.models.Marker; import de.dennisguse.opentracks.data.models.Speed; import de.dennisguse.opentracks.data.models.Track;