Code review comments

MyTracks/res/values/strings.xml

@@ -211,8 +211,8 @@ limitations under the License.
   <string name="settings_auto_resume_track_timeout_summary">Maximum time in minutes after which a previously recording track will not be resumed on phone reboot</string>
 
   <string name="settings_timestamp_track_name">Timestamp as track name</string>
-  <string name="settings_timestamp_track_name_on">The default track name will be the date and time at the start of the track</string>
+  <string name="settings_timestamp_track_name_summary_on">The default track name will be the date and time at the start of the track</string>
-  <string name="settings_timestamp_track_name_off">Track names will have numbers which increment for each new track.</string>
+  <string name="settings_timestamp_track_name_summary_off">Track names will have numbers which increment for each new track.</string>
 
   <string name="pace_label">Pace</string>
 

MyTracks/res/xml/preferences.xml

@@ -103,8 +103,8 @@ limitations under the License.
     <CheckBoxPreference
         android:key="@string/timestamp_track_name_key"
         android:title="@string/settings_timestamp_track_name"
-        android:summaryOn="@string/settings_timestamp_track_name_on"
+        android:summaryOn="@string/settings_timestamp_track_name_summary_on"
-        android:summaryOff="@string/settings_timestamp_track_name_off"
+        android:summaryOff="@string/settings_timestamp_track_name_summary_off"
         android:defaultValue="true" />
 
   </PreferenceScreen>

MyTracks/src/com/google/android/apps/mytracks/services/DefaultTrackNameFactory.java

@@ -60,13 +60,7 @@ class DefaultTrackNameFactory {
   protected boolean useTimestampTrackName() {
     SharedPreferences prefs =
         context.getSharedPreferences(MyTracksSettings.SETTINGS_NAME, 0);
-
+    return prefs.getBoolean(
-    boolean useTimestamp = false;
+        context.getString(R.string.timestamp_track_name_key), true);
-    if (prefs != null) {
-      useTimestamp = prefs.getBoolean(
-          context.getString(R.string.timestamp_track_name_key), true);
-    }
-
-    return useTimestamp;
   }
 }

MyTracksTest/src/com/google/android/apps/mytracks/services/DefaultTrackNameFactoryTest.java

@@ -21,7 +21,16 @@ import android.test.AndroidTestCase;
 import java.text.SimpleDateFormat;
 import java.util.Date;
 
+/**
+ * Tests {@link DefaultTrackNameFactory}
+ * 
+ * @author Matthew Simmons
+ */
 public class DefaultTrackNameFactoryTest extends AndroidTestCase {
+  /**
+   * A version of the factory which allows us to supply our own answer as to
+   * whether a timestamp-based track name should be used.
+   */
   private static class MockDefaultTrackNameFactory
       extends DefaultTrackNameFactory {
     private final boolean useTimestamp;