From be096b96576bd8d7d1b13d73ae8850896a7c3ec5 Mon Sep 17 00:00:00 2001 From: Rodrigo Damazio Date: Wed, 1 Jun 2011 01:40:12 -0300 Subject: [PATCH] Removing no-longer-necessary methods from the platform adapters. --- .../android/apps/mytracks/util/ApiPlatformAdapter.java | 9 --------- .../apps/mytracks/util/CupcakePlatformAdapter.java | 8 +------- .../apps/mytracks/util/EclairPlatformAdapter.java | 6 ------ 3 files changed, 1 insertion(+), 22 deletions(-) diff --git a/MyTracks/src/com/google/android/apps/mytracks/util/ApiPlatformAdapter.java b/MyTracks/src/com/google/android/apps/mytracks/util/ApiPlatformAdapter.java index c68832735..f432fe8fa 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/util/ApiPlatformAdapter.java +++ b/MyTracks/src/com/google/android/apps/mytracks/util/ApiPlatformAdapter.java @@ -19,7 +19,6 @@ import android.app.Notification; import android.app.NotificationManager; import android.app.Service; import android.content.SharedPreferences; -import android.os.HandlerThread; /** * A set of methods that may be implemented in a platform specific way. @@ -51,14 +50,6 @@ public interface ApiPlatformAdapter { void stopForeground(Service service, NotificationManager notificationManager, int id); - /** - * Terminates the given handler thread. - * - * @param handlerThread the thread to be terminated. - * @return true whether the handler has been stopped or not. - */ - boolean stopHandlerThread(HandlerThread handlerThread); - /** * Applies all changes done to the given preferences editor. * Changes may or may not be applied immediately. diff --git a/MyTracks/src/com/google/android/apps/mytracks/util/CupcakePlatformAdapter.java b/MyTracks/src/com/google/android/apps/mytracks/util/CupcakePlatformAdapter.java index abdd9dfb7..fe6ec0b47 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/util/CupcakePlatformAdapter.java +++ b/MyTracks/src/com/google/android/apps/mytracks/util/CupcakePlatformAdapter.java @@ -16,11 +16,11 @@ package com.google.android.apps.mytracks.util; import static com.google.android.apps.mytracks.Constants.TAG; + import android.app.Notification; import android.app.NotificationManager; import android.app.Service; import android.content.SharedPreferences.Editor; -import android.os.HandlerThread; import android.util.Log; import java.lang.reflect.InvocationTargetException; @@ -70,12 +70,6 @@ public class CupcakePlatformAdapter implements ApiPlatformAdapter { } } - @Override - public boolean stopHandlerThread(HandlerThread handlerThread) { - // Do nothing, as Cupcake doesn't provide quit(). - return false; - } - @Override public void applyPreferenceChanges(Editor editor) { editor.commit(); diff --git a/MyTracks/src/com/google/android/apps/mytracks/util/EclairPlatformAdapter.java b/MyTracks/src/com/google/android/apps/mytracks/util/EclairPlatformAdapter.java index 91c1ea1d3..55540e1a4 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/util/EclairPlatformAdapter.java +++ b/MyTracks/src/com/google/android/apps/mytracks/util/EclairPlatformAdapter.java @@ -19,7 +19,6 @@ import android.app.Notification; import android.app.NotificationManager; import android.app.Service; import android.content.SharedPreferences.Editor; -import android.os.HandlerThread; /** * The Eclair (API level 5) specific implementation of the @@ -42,11 +41,6 @@ public class EclairPlatformAdapter implements ApiPlatformAdapter { service.stopForeground(id != -1); } - @Override - public boolean stopHandlerThread(HandlerThread handlerThread) { - return handlerThread.quit(); - } - @Override public void applyPreferenceChanges(Editor editor) { editor.commit();