From bf03de6be7730de13f7c582f16dc4b39886df971 Mon Sep 17 00:00:00 2001 From: Dennis Guse Date: Tue, 4 Apr 2023 21:46:54 +0200 Subject: [PATCH] Bugfix: GPS disabled warning was showing (repeatedly but incorrectly). Fixes #1429. --- .../dennisguse/opentracks/TrackRecordingActivity.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java b/src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java index 12c8d4e4c..3adb7a307 100644 --- a/src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java +++ b/src/main/java/de/dennisguse/opentracks/TrackRecordingActivity.java @@ -381,13 +381,18 @@ public class TrackRecordingActivity extends AbstractActivity implements ChooseAc } private void onGpsStatusChanged(GpsStatusValue gpsStatusValue) { - if (gpsStatusValue.isGpsStarted() && snackbar != null && snackbar.isShown()) { - snackbar.dismiss(); + boolean snackbarShowing = snackbar != null && snackbar.isShown(); + if (gpsStatusValue.isGpsStarted()) { + if (snackbarShowing) { + snackbar.dismiss(); + } return; } - if (gpsStatusValue != GpsStatusValue.GPS_DISABLED) { + + if (snackbarShowing) { return; } + snackbar = Snackbar .make(viewBinding.trackRecordingCoordinatorLayout, getString(R.string.gps_recording_status, getString(gpsStatusValue.message), getString(R.string.gps_recording_without_signal)),