karol/OpenTracks
1
0
Fork 0
forked from upstream-mirrors/OpenTracks
Code Pull Requests Actions Releases 2 Activity

code review comments

Browse Source
This commit is contained in:
Matthew Simmons
2011-03-07 13:54:45 -05:00
parent f9eba950e0
commit c16ce866dc
3 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
MyTracks/res/layout/send_to_google_result.xml
+5 -5
View File
@@ -37,11 +37,11 @@ services.
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:gravity="center_horizontal"> android:gravity="center_horizontal">
<!-- We don't want a divider, so we set its color to transparent. --> <!-- We don't want a divider, so we set its color to transparent. -->
<!-- We do this explicitly, rather than with a color resource, because --> <!-- We do this explicitly, rather than with a color resource, because -->
<!-- an apparent bug causes the divider to be wildly misrendered on --> <!-- an apparent bug causes the divider to be wildly misrendered on -->
<!-- a Mini X10 running 2.1. --> <!-- a Mini X10 running 2.1. -->
<ListView <ListView
android:id="@+id/send_to_google_result_list" android:id="@+id/send_to_google_result_list"
android:clickable="false" android:clickable="false"
android:paddingTop="10dip" android:paddingTop="10dip"
MyTracks/src/com/google/android/apps/mytracks/MyTracks.java
+1 -1
View File
@@ -1189,7 +1189,7 @@ public class MyTracks extends TabActivity implements OnTouchListener,
// listener will be null). The OK button listener will initiate the // listener will be null). The OK button listener will initiate the
// share. // share.
// //
// 2. The user did not pre-request a share, but the set of services to // 2. The user did not pre-request a share, and the set of services to
// which we succeeded in uploading the track are compatible with // which we succeeded in uploading the track are compatible with
// sharing. We'll display a share button (the share listener will be // sharing. We'll display a share button (the share listener will be
// non-null), and will share the link if the user clicks it. // non-null), and will share the link if the user clicks it.
MyTracks/src/com/google/android/apps/mytracks/io/sendtogoogle/SendDialog.java
+3 -5
View File
@@ -1,12 +1,12 @@
/* /*
* Copyright 2008 Google Inc. * Copyright 2008 Google Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); you may not * Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of * use this file except in compliance with the License. You may obtain a copy of
* the License at * the License at
* *
* http://www.apache.org/licenses/LICENSE-2.0 * http://www.apache.org/licenses/LICENSE-2.0
* *
* Unless required by applicable law or agreed to in writing, software * Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -84,8 +84,6 @@ public class SendDialog extends Dialog {
sendToFusionTablesCheckBox.isChecked() || sendToFusionTablesCheckBox.isChecked() ||
sendToDocsCheckBox.isChecked()); sendToDocsCheckBox.isChecked());
groupMyMaps.setVisibility(sendToMyMapsCheckBox.isChecked() ? View.VISIBLE : View.INVISIBLE); groupMyMaps.setVisibility(sendToMyMapsCheckBox.isChecked() ? View.VISIBLE : View.INVISIBLE);
//groupDocs.setVisibility(
// sendToDocsCheckBox.isChecked() ? View.VISIBLE : View.INVISIBLE);
} }
}; };