From c9231a764007dd77f4180d2508442ca7cdf6c930 Mon Sep 17 00:00:00 2001 From: Dennis Guse Date: Sun, 4 Jul 2021 08:47:20 +0200 Subject: [PATCH] Add copy constructor to SensorDataSet to avoid undesired changes. --- .../opentracks/content/sensor/SensorDataSet.java | 7 +++++++ .../services/sensors/BluetoothRemoteSensorManager.java | 3 +-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/main/java/de/dennisguse/opentracks/content/sensor/SensorDataSet.java b/src/main/java/de/dennisguse/opentracks/content/sensor/SensorDataSet.java index 08a956d9e..4ac2461d1 100644 --- a/src/main/java/de/dennisguse/opentracks/content/sensor/SensorDataSet.java +++ b/src/main/java/de/dennisguse/opentracks/content/sensor/SensorDataSet.java @@ -17,6 +17,13 @@ public final class SensorDataSet { public SensorDataSet() { } + public SensorDataSet(SensorDataSet toCopy) { + this.heartRate = toCopy.heartRate; + this.cyclingCadence = toCopy.cyclingCadence; + this.cyclingDistanceSpeed = toCopy.cyclingDistanceSpeed; + this.cyclingPower = toCopy.cyclingPower; + } + public SensorDataHeartRate getHeartRate() { return heartRate; } diff --git a/src/main/java/de/dennisguse/opentracks/services/sensors/BluetoothRemoteSensorManager.java b/src/main/java/de/dennisguse/opentracks/services/sensors/BluetoothRemoteSensorManager.java index e82365312..e306549b9 100644 --- a/src/main/java/de/dennisguse/opentracks/services/sensors/BluetoothRemoteSensorManager.java +++ b/src/main/java/de/dennisguse/opentracks/services/sensors/BluetoothRemoteSensorManager.java @@ -166,8 +166,7 @@ public class BluetoothRemoteSensorManager implements BluetoothConnectionManager. } public SensorDataSet getSensorDataSet() { - // TODO Should return a copy. - return sensorDataSet; + return new SensorDataSet(sensorDataSet); } public void reset() {