forked from upstream-mirrors/OpenTracks
Cleanup: SensorDataCyclingDistanceSpeed.Data is a record.
This commit is contained in:
+1
-5
@@ -562,13 +562,9 @@ public class ExportImportTest {
|
|||||||
sensorDataSet.cyclingCadence = cyclingCadence;
|
sensorDataSet.cyclingCadence = cyclingCadence;
|
||||||
|
|
||||||
if (distance != null && speed != null) {
|
if (distance != null && speed != null) {
|
||||||
SensorDataCyclingDistanceSpeed.Data distanceSpeedData = Mockito.mock(SensorDataCyclingDistanceSpeed.Data.class);
|
|
||||||
Mockito.when(distanceSpeedData.getDistanceOverall()).thenReturn(distance);
|
|
||||||
Mockito.when(distanceSpeedData.getSpeed()).thenReturn(Speed.of(speed));
|
|
||||||
|
|
||||||
SensorDataCyclingDistanceSpeed distanceSpeed = Mockito.mock(SensorDataCyclingDistanceSpeed.class);
|
SensorDataCyclingDistanceSpeed distanceSpeed = Mockito.mock(SensorDataCyclingDistanceSpeed.class);
|
||||||
Mockito.when(distanceSpeed.hasValue()).thenReturn(true);
|
Mockito.when(distanceSpeed.hasValue()).thenReturn(true);
|
||||||
Mockito.when(distanceSpeed.getValue()).thenReturn(distanceSpeedData);
|
Mockito.when(distanceSpeed.getValue()).thenReturn(new SensorDataCyclingDistanceSpeed.Data(null, distance, Speed.of(speed)));
|
||||||
sensorDataSet.cyclingDistanceSpeed = distanceSpeed;
|
sensorDataSet.cyclingDistanceSpeed = distanceSpeed;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+2
-2
@@ -104,8 +104,8 @@ public class SensorDataCyclingTest {
|
|||||||
current.add(new Raw<>(new BluetoothHandlerCyclingDistanceSpeed.WheelData(2, 8016)));
|
current.add(new Raw<>(new BluetoothHandlerCyclingDistanceSpeed.WheelData(2, 8016)));
|
||||||
|
|
||||||
// then
|
// then
|
||||||
assertEquals(2.15, current.getValue().getDistance().toM(), 0.01);
|
assertEquals(2.15, current.getValue().distance().toM(), 0.01);
|
||||||
assertEquals(1.20, current.getValue().getSpeed().toMPS(), 0.01);
|
assertEquals(1.20, current.getValue().speed().toMPS(), 0.01);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
|
|||||||
+1
-34
@@ -73,38 +73,5 @@ public class SensorDataCyclingDistanceSpeed extends SensorData<BluetoothHandlerC
|
|||||||
this.wheelCircumference = wheelCircumference;
|
this.wheelCircumference = wheelCircumference;
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO Make record
|
public record Data(Distance distance, Distance distanceOverall, Speed speed) {}
|
||||||
public static class Data {
|
|
||||||
private final Distance distance;
|
|
||||||
private final Distance distanceOverall;
|
|
||||||
private final Speed speed;
|
|
||||||
|
|
||||||
private Data(Distance distance, Distance distanceOverall, Speed speed) {
|
|
||||||
this.distance = distance;
|
|
||||||
this.distanceOverall = distanceOverall;
|
|
||||||
this.speed = speed;
|
|
||||||
}
|
|
||||||
|
|
||||||
public Distance getDistance() {
|
|
||||||
return distance;
|
|
||||||
}
|
|
||||||
|
|
||||||
public Distance getDistanceOverall() {
|
|
||||||
return distanceOverall;
|
|
||||||
}
|
|
||||||
|
|
||||||
public Speed getSpeed() {
|
|
||||||
return speed;
|
|
||||||
}
|
|
||||||
|
|
||||||
@NonNull
|
|
||||||
@Override
|
|
||||||
public String toString() {
|
|
||||||
return "Data{" +
|
|
||||||
"distance=" + getDistance() +
|
|
||||||
", distance_overall=" + getDistanceOverall() +
|
|
||||||
", speed=" + getSpeed() +
|
|
||||||
'}';
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -68,8 +68,8 @@ public final class SensorDataSet {
|
|||||||
}
|
}
|
||||||
|
|
||||||
public Pair<Speed, String> getSpeed() {
|
public Pair<Speed, String> getSpeed() {
|
||||||
if (cyclingDistanceSpeed != null && cyclingDistanceSpeed.hasValue() && cyclingDistanceSpeed.getValue().getSpeed() != null) {
|
if (cyclingDistanceSpeed != null && cyclingDistanceSpeed.hasValue() && cyclingDistanceSpeed.getValue().speed() != null) {
|
||||||
return new Pair<>(cyclingDistanceSpeed.getValue().getSpeed(), cyclingDistanceSpeed.getSensorNameOrAddress());
|
return new Pair<>(cyclingDistanceSpeed.getValue().speed(), cyclingDistanceSpeed.getSensorNameOrAddress());
|
||||||
}
|
}
|
||||||
|
|
||||||
if (runningDistanceSpeedCadence != null && runningDistanceSpeedCadence.hasValue() && runningDistanceSpeedCadence.getValue().speed() != null) {
|
if (runningDistanceSpeedCadence != null && runningDistanceSpeedCadence.hasValue() && runningDistanceSpeedCadence.getValue().speed() != null) {
|
||||||
@@ -143,7 +143,7 @@ public final class SensorDataSet {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if (cyclingDistanceSpeed != null && cyclingDistanceSpeed.hasValue()) {
|
if (cyclingDistanceSpeed != null && cyclingDistanceSpeed.hasValue()) {
|
||||||
trackPoint.setSensorDistance(cyclingDistanceSpeed.getValue().getDistanceOverall());
|
trackPoint.setSensorDistance(cyclingDistanceSpeed.getValue().distanceOverall());
|
||||||
}
|
}
|
||||||
|
|
||||||
if (cyclingPower != null && cyclingPower.hasValue()) {
|
if (cyclingPower != null && cyclingPower.hasValue()) {
|
||||||
|
|||||||
Reference in New Issue
Block a user