Cleanup using AndroidStudio analyze.

src/main/java/de/dennisguse/opentracks/ShowErrorActivity.java

@@ -7,7 +7,6 @@ import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
 
-import java.io.UnsupportedEncodingException;
 import java.net.URLEncoder;
 import java.nio.charset.StandardCharsets;
 
@@ -40,17 +39,12 @@ public class ShowErrorActivity extends AbstractActivity {
 
     private void reportBug() {
         Uri uriUrl;
-        try {
+        uriUrl = Uri.parse(
-            uriUrl = Uri.parse(
+                String.format(
-                    String.format(
+                        getString(R.string.report_issue_link),
-                            getString(R.string.report_issue_link),
+                        URLEncoder.encode(viewBinding.textViewError.getText().toString(), StandardCharsets.UTF_8)
-                            URLEncoder.encode(viewBinding.textViewError.getText().toString(), StandardCharsets.UTF_8.toString())
+                )
-                    )
+        );
-            );
-        } catch (final UnsupportedEncodingException ignored) {
-            // can't happen as UTF-8 is always available
-            return;
-        }
         Intent intent = new Intent(Intent.ACTION_VIEW, uriUrl);
         startActivity(intent);
     }

src/main/java/de/dennisguse/opentracks/chart/ChartView.java

@@ -41,9 +41,9 @@ import androidx.core.view.GestureDetectorCompat;
 import java.text.NumberFormat;
 import java.time.Duration;
 import java.util.ArrayList;
+import java.util.Iterator;
 import java.util.LinkedList;
 import java.util.List;
-import java.util.Iterator;
 
 import de.dennisguse.opentracks.R;
 import de.dennisguse.opentracks.data.models.Marker;
@@ -679,12 +679,13 @@ public class ChartView extends View {
     private record TitlePosition(
             int line, // line number (starts at 1, top to bottom numbering)
             int xPos // x position in points (starts at 0, left to right indexing)
-    ) {};
+    ) {}
+
     private record TitleDimensions(
             int lineCount, // number of lines the titles will take
             int lineHeight, // height of a line (all lines have the same height)
             List<TitlePosition> titlePositions // positions of visible titles (the order corresponds to seriesList)
-    ) {};
+    ) {}
 
     /**
      * Draws series titles.
@@ -711,7 +712,7 @@ public class ChartView extends View {
     private TitleDimensions getTitleDimensions() {
         int lineCnt = 1;
         int lineHeight = 0;
-        List<TitlePosition> tps = new ArrayList<TitlePosition>();
+        List<TitlePosition> tps = new ArrayList<>();
         int xPosInLine = spacer;
         for (ChartValueSeries chartValueSeries : seriesList) {
             if (chartValueSeries.isEnabled() && chartValueSeries.hasData() || allowIfEmpty(chartValueSeries)) {

src/main/java/de/dennisguse/opentracks/data/models/Marker.java

@@ -263,7 +263,7 @@ public final class Marker {
     }
 
     public boolean hasPhoto() {
-        return photoUrl != null && !"".equals(photoUrl);
+        return photoUrl != null && !photoUrl.isEmpty();
     }
 
     public record Id(long id) implements Parcelable {

src/main/java/de/dennisguse/opentracks/io/file/exporter/GPXTrackExporter.java

@@ -310,7 +310,7 @@ public class GPXTrackExporter implements TrackExporter {
     }
 
     public Distance writeTrackPoint(ZoneOffset zoneOffset, TrackPoint trackPoint, List<TrackPoint> sensorPoints, Distance trackDistance) {
-        Distance cumulativeDistance = null;
+        Distance cumulativeDistance;
 
         printWriter.println("<trkpt " + formatLocation(trackPoint.getLatitude(), trackPoint.getLongitude()) + ">");
 

src/main/java/de/dennisguse/opentracks/io/file/exporter/KMLTrackExporter.java

@@ -498,7 +498,7 @@ public class KMLTrackExporter implements TrackExporter {
     }
 
     private void writeTypeLocalized(String localizedValue) {
-        if (localizedValue == null || localizedValue.equals("")) {
+        if (localizedValue == null || localizedValue.isEmpty()) {
             return;
         }
         printWriter.println("<ExtendedData>");

src/main/java/de/dennisguse/opentracks/io/file/importer/KmlTrackImporter.java

@@ -414,7 +414,7 @@ public class KmlTrackImporter extends DefaultHandler implements XMLImporter.Trac
         Float value = null;
         if (content != null) {
             content = content.trim();
-            if (!"".equals(content)) {
+            if (!content.isEmpty()) {
                 try {
                     value = Float.parseFloat(content);
                 } catch (NumberFormatException e) {

src/main/java/de/dennisguse/opentracks/sensors/GainManager.java

@@ -20,9 +20,7 @@ public class GainManager implements SensorConnector {
 
     private final SensorManager.SensorDataChangedObserver listener;
 
-    private final SharedPreferences.OnSharedPreferenceChangeListener sharedPreferenceChangeListener = (sharedPreferences, key) -> {
+    private final SharedPreferences.OnSharedPreferenceChangeListener sharedPreferenceChangeListener = (sharedPreferences, key) -> connect();
-        connect();
-    };
 
     private Context context;
     private Handler handler;

src/main/java/de/dennisguse/opentracks/sensors/sensorData/Aggregator.java

@@ -55,7 +55,7 @@ public abstract class Aggregator<Input, Output> {
     /**
      * Reset long term aggregated values (more than derived from previous SensorData). e.g. overall distance.
      */
-    public void reset() {};
+    public void reset() {}
 
     /**
      * Is the data recent considering the current time.

src/main/java/de/dennisguse/opentracks/settings/PreferencesUtils.java

@@ -229,7 +229,7 @@ public class PreferencesUtils {
 
     //TODO Check if actually needed or can be superseeded by a flexible default in getUnit()
     public static void applyDefaultUnit() {
-        if (getString(R.string.stats_units_key, "").equals("")) {
+        if (getString(R.string.stats_units_key, "").isEmpty()) {
             if (!Locale.US.equals(Locale.getDefault())) {
                 setUnit(UnitSystem.METRIC);
             } else {

src/main/java/de/dennisguse/opentracks/ui/markers/MarkerListActivity.java

@@ -114,9 +114,7 @@ public class MarkerListActivity extends AbstractActivity implements DeleteMarker
 
         setSupportActionBar(viewBinding.bottomAppBarLayout.bottomAppBar);
         setSupportActionBar(viewBinding.markerListToolbar);
-        viewBinding.bottomAppBarLayout.bottomAppBar.setNavigationOnClickListener(item -> {
+        viewBinding.bottomAppBarLayout.bottomAppBar.setNavigationOnClickListener(item -> finish());
-            finish();
-        });
     }
 
     @Override

src/main/res/values-zh-rTW/strings.xml

@@ -201,7 +201,6 @@ limitations under the License.
     <string name="generic_separator_done_total">/</string>
     <string name="generic_show_errors">顯示錯誤</string>
     <plurals name="generic_completed_with_errors">
-        <item quantity="one">已完成，但有一個錯誤</item>
         <item quantity="other">已完成，但有 %1$d 個錯誤</item>
     </plurals>
     <string name="generic_completed">完成</string>