Change code style of UploadResultActivityTest.

This commit is contained in:
youtaol
2012-06-12 10:33:18 +08:00
parent 56475a943f
commit d9f951230f
@@ -30,9 +30,8 @@ import android.widget.TextView;
* *
* @author Youtao Liu * @author Youtao Liu
*/ */
public class UploadResultActivityTest public class UploadResultActivityTest extends
extends ActivityInstrumentationTestCase2<UploadResultActivity> { ActivityInstrumentationTestCase2<UploadResultActivity> {
private UploadResultActivity uploadResultActivity; private UploadResultActivity uploadResultActivity;
private TextView errorFooter; private TextView errorFooter;
@@ -44,6 +43,9 @@ public class UploadResultActivityTest
private ImageView fusionTablesResultIcon; private ImageView fusionTablesResultIcon;
private ImageView docsResultIcon; private ImageView docsResultIcon;
private String successTitle;
private String errorTitle;
/** /**
* This method is necessary for ActivityInstrumentationTestCase2. * This method is necessary for ActivityInstrumentationTestCase2.
*/ */
@@ -57,16 +59,16 @@ public class UploadResultActivityTest
public void testAllSuccess() { public void testAllSuccess() {
initialActivity(true, true, true, true, true, true); initialActivity(true, true, true, true, true, true);
createDialogAndGetViews(); createDialogAndGetViews();
assertEquals(View.VISIBLE, successFooter.getVisibility()); assertEquals(View.VISIBLE, successFooter.getVisibility());
assertEquals(View.GONE, errorFooter.getVisibility()); assertEquals(View.GONE, errorFooter.getVisibility());
assertEquals(View.VISIBLE, mapsResult.getVisibility()); assertEquals(View.VISIBLE, mapsResult.getVisibility());
assertEquals(View.VISIBLE, fusionTablesResult.getVisibility()); assertEquals(View.VISIBLE, fusionTablesResult.getVisibility());
assertEquals(View.VISIBLE, docsResult.getVisibility()); assertEquals(View.VISIBLE, docsResult.getVisibility());
assertEquals(uploadResultActivity.getString(R.string.generic_success_title), mapsResultIcon.getContentDescription()); assertEquals(successTitle, mapsResultIcon.getContentDescription());
assertEquals(uploadResultActivity.getString(R.string.generic_success_title), fusionTablesResultIcon.getContentDescription()); assertEquals(successTitle, fusionTablesResultIcon.getContentDescription());
assertEquals(uploadResultActivity.getString(R.string.generic_success_title), docsResultIcon.getContentDescription()); assertEquals(successTitle, docsResultIcon.getContentDescription());
} }
/** /**
@@ -76,16 +78,16 @@ public class UploadResultActivityTest
// Send all kinds but all failed. // Send all kinds but all failed.
initialActivity(true, true, true, false, false, false); initialActivity(true, true, true, false, false, false);
createDialogAndGetViews(); createDialogAndGetViews();
assertEquals(View.GONE, successFooter.getVisibility()); assertEquals(View.GONE, successFooter.getVisibility());
assertEquals(View.VISIBLE, errorFooter.getVisibility()); assertEquals(View.VISIBLE, errorFooter.getVisibility());
assertEquals(View.VISIBLE, mapsResult.getVisibility()); assertEquals(View.VISIBLE, mapsResult.getVisibility());
assertEquals(View.VISIBLE, fusionTablesResult.getVisibility()); assertEquals(View.VISIBLE, fusionTablesResult.getVisibility());
assertEquals(View.VISIBLE, docsResult.getVisibility()); assertEquals(View.VISIBLE, docsResult.getVisibility());
assertEquals(uploadResultActivity.getString(R.string.generic_error_title), mapsResultIcon.getContentDescription()); assertEquals(errorTitle, mapsResultIcon.getContentDescription());
assertEquals(uploadResultActivity.getString(R.string.generic_error_title), fusionTablesResultIcon.getContentDescription()); assertEquals(errorTitle, fusionTablesResultIcon.getContentDescription());
assertEquals(uploadResultActivity.getString(R.string.generic_error_title), docsResultIcon.getContentDescription()); assertEquals(errorTitle, docsResultIcon.getContentDescription());
} }
/** /**
@@ -99,14 +101,14 @@ public class UploadResultActivityTest
public void testPartialSuccess() { public void testPartialSuccess() {
initialActivity(true, false, true, true, false, false); initialActivity(true, false, true, true, false, false);
createDialogAndGetViews(); createDialogAndGetViews();
assertEquals(View.VISIBLE, errorFooter.getVisibility()); assertEquals(View.VISIBLE, errorFooter.getVisibility());
assertEquals(View.VISIBLE, mapsResult.getVisibility()); assertEquals(View.VISIBLE, mapsResult.getVisibility());
assertEquals(View.GONE, fusionTablesResult.getVisibility()); assertEquals(View.GONE, fusionTablesResult.getVisibility());
assertEquals(View.VISIBLE, docsResult.getVisibility()); assertEquals(View.VISIBLE, docsResult.getVisibility());
assertEquals(uploadResultActivity.getString(R.string.generic_success_title), mapsResultIcon.getContentDescription()); assertEquals(successTitle, mapsResultIcon.getContentDescription());
assertEquals(uploadResultActivity.getString(R.string.generic_error_title), docsResultIcon.getContentDescription()); assertEquals(errorTitle, docsResultIcon.getContentDescription());
} }
/** /**
@@ -132,8 +134,10 @@ public class UploadResultActivityTest
intent.putExtra(SendRequest.SEND_REQUEST_KEY, sendRequest); intent.putExtra(SendRequest.SEND_REQUEST_KEY, sendRequest);
setActivityIntent(intent); setActivityIntent(intent);
uploadResultActivity = this.getActivity(); uploadResultActivity = this.getActivity();
successTitle = uploadResultActivity.getString(R.string.generic_success_title);
errorTitle = uploadResultActivity.getString(R.string.generic_error_title);
} }
/** /**
* Creates result dialog and gets views in the dialog. * Creates result dialog and gets views in the dialog.
*/ */
@@ -142,12 +146,11 @@ public class UploadResultActivityTest
View view = uploadResultActivity.view; View view = uploadResultActivity.view;
errorFooter = (TextView) view.findViewById(R.id.upload_result_error_footer); errorFooter = (TextView) view.findViewById(R.id.upload_result_error_footer);
successFooter = (TextView) view.findViewById(R.id.upload_result_success_footer); successFooter = (TextView) view.findViewById(R.id.upload_result_success_footer);
mapsResult = (LinearLayout) view.findViewById(R.id.upload_result_maps_result); mapsResult = (LinearLayout) view.findViewById(R.id.upload_result_maps_result);
fusionTablesResult = (LinearLayout) view.findViewById( fusionTablesResult = (LinearLayout) view.findViewById(R.id.upload_result_fusion_tables_result);
R.id.upload_result_fusion_tables_result);
docsResult = (LinearLayout) view.findViewById(R.id.upload_result_docs_result); docsResult = (LinearLayout) view.findViewById(R.id.upload_result_docs_result);
mapsResultIcon = (ImageView) view.findViewById(R.id.upload_result_maps_result_icon); mapsResultIcon = (ImageView) view.findViewById(R.id.upload_result_maps_result_icon);
fusionTablesResultIcon = (ImageView) view fusionTablesResultIcon = (ImageView) view
.findViewById(R.id.upload_result_fusion_tables_result_icon); .findViewById(R.id.upload_result_fusion_tables_result_icon);