diff --git a/src/main/java/de/dennisguse/opentracks/content/data/TrackPointsColumns.java b/src/main/java/de/dennisguse/opentracks/content/data/TrackPointsColumns.java index 2aea279a5..52a543a95 100644 --- a/src/main/java/de/dennisguse/opentracks/content/data/TrackPointsColumns.java +++ b/src/main/java/de/dennisguse/opentracks/content/data/TrackPointsColumns.java @@ -36,8 +36,12 @@ public interface TrackPointsColumns extends BaseColumns { // Columns String TRACKID = "trackid"; + String LONGITUDE = "longitude"; String LATITUDE = "latitude"; + double PAUSE_LATITUDE = 100.0; + double RESUME_LATITUDE = 200.0; + String TIME = "time"; String ALTITUDE = "elevation"; String ACCURACY = "accuracy"; diff --git a/src/main/java/de/dennisguse/opentracks/io/file/importer/AbstractFileTrackImporter.java b/src/main/java/de/dennisguse/opentracks/io/file/importer/AbstractFileTrackImporter.java index fdbd27d11..719081c8d 100644 --- a/src/main/java/de/dennisguse/opentracks/io/file/importer/AbstractFileTrackImporter.java +++ b/src/main/java/de/dennisguse/opentracks/io/file/importer/AbstractFileTrackImporter.java @@ -39,11 +39,11 @@ import javax.xml.parsers.SAXParserFactory; import de.dennisguse.opentracks.R; import de.dennisguse.opentracks.content.data.Track; +import de.dennisguse.opentracks.content.data.TrackPointsColumns; import de.dennisguse.opentracks.content.data.Waypoint; import de.dennisguse.opentracks.content.provider.ContentProviderUtils; import de.dennisguse.opentracks.content.provider.TrackPointFactory; import de.dennisguse.opentracks.content.provider.TrackPointIterator; -import de.dennisguse.opentracks.services.TrackRecordingService; import de.dennisguse.opentracks.stats.TripStatisticsUpdater; import de.dennisguse.opentracks.util.FileUtils; import de.dennisguse.opentracks.util.LocationUtils; @@ -274,7 +274,7 @@ abstract class AbstractFileTrackImporter extends DefaultHandler implements Track //If not the first segment, add a pause separator if there is at least one location in the last segment. if (trackData.numberOfSegments > 1 && trackData.lastLocationInCurrentSegment != null) { - insertLocation(createLocation(TrackRecordingService.PAUSE_LATITUDE, 0.0, 0.0, trackData.lastLocationInCurrentSegment.getTime())); + insertLocation(createLocation(TrackPointsColumns.PAUSE_LATITUDE, 0.0, 0.0, trackData.lastLocationInCurrentSegment.getTime())); } trackData.lastLocationInCurrentSegment = null; } @@ -344,8 +344,7 @@ abstract class AbstractFileTrackImporter extends DefaultHandler implements Track if (trackData.numberOfSegments > 1 && trackData.lastLocationInCurrentSegment == null) { // If not the first segment, add a resume separator before adding the first location. - insertLocation( - createLocation(TrackRecordingService.RESUME_LATITUDE, 0.0, 0.0, location.getTime())); + insertLocation(createLocation(TrackPointsColumns.RESUME_LATITUDE, 0.0, 0.0, location.getTime())); } trackData.lastLocationInCurrentSegment = location; return location; diff --git a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java index 26ef20a6a..66c4716ac 100644 --- a/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java +++ b/src/main/java/de/dennisguse/opentracks/services/TrackRecordingService.java @@ -43,6 +43,7 @@ import de.dennisguse.opentracks.TrackDetailActivity; import de.dennisguse.opentracks.TrackListActivity; import de.dennisguse.opentracks.content.data.Track; import de.dennisguse.opentracks.content.data.TrackPoint; +import de.dennisguse.opentracks.content.data.TrackPointsColumns; import de.dennisguse.opentracks.content.data.Waypoint; import de.dennisguse.opentracks.content.provider.ContentProviderUtils; import de.dennisguse.opentracks.content.provider.CustomContentProvider; @@ -70,12 +71,6 @@ import de.dennisguse.opentracks.util.UnitConversions; */ public class TrackRecordingService extends Service { - // TODO Move to a different place. - @Deprecated - public static final double PAUSE_LATITUDE = 100.0; - @Deprecated - public static final double RESUME_LATITUDE = 200.0; - // Anything faster than that (in meters per second) will be considered moving. private static final String TAG = TrackRecordingService.class.getSimpleName(); @@ -386,7 +381,7 @@ public class TrackRecordingService extends Service { if (track != null) { Location resume = new Location(LocationManager.GPS_PROVIDER); resume.setLongitude(0); - resume.setLatitude(RESUME_LATITUDE); + resume.setLatitude(TrackPointsColumns.RESUME_LATITUDE); resume.setTime(System.currentTimeMillis()); insertLocation(track, resume, null); } @@ -473,7 +468,7 @@ public class TrackRecordingService extends Service { Location pause = new Location(LocationManager.GPS_PROVIDER); pause.setLongitude(0); - pause.setLatitude(PAUSE_LATITUDE); + pause.setLatitude(TrackPointsColumns.PAUSE_LATITUDE); pause.setTime(System.currentTimeMillis()); insertLocation(track, pause, null); } @@ -610,7 +605,7 @@ public class TrackRecordingService extends Service { Location pause = new Location(LocationManager.GPS_PROVIDER); pause.setLongitude(0); - pause.setLatitude(PAUSE_LATITUDE); + pause.setLatitude(TrackPointsColumns.PAUSE_LATITUDE); pause.setTime(lastLocation.getTime()); insertLocation(track, pause, null); diff --git a/src/main/java/de/dennisguse/opentracks/stats/TripStatisticsUpdater.java b/src/main/java/de/dennisguse/opentracks/stats/TripStatisticsUpdater.java index 1e46da463..c51ba6652 100644 --- a/src/main/java/de/dennisguse/opentracks/stats/TripStatisticsUpdater.java +++ b/src/main/java/de/dennisguse/opentracks/stats/TripStatisticsUpdater.java @@ -21,11 +21,11 @@ import android.util.Log; import androidx.annotation.VisibleForTesting; +import de.dennisguse.opentracks.content.data.TrackPointsColumns; import de.dennisguse.opentracks.content.provider.TrackPointIterator; import de.dennisguse.opentracks.util.LocationUtils; import static de.dennisguse.opentracks.services.TrackRecordingService.MAX_NO_MOVEMENT_SPEED; -import static de.dennisguse.opentracks.services.TrackRecordingService.PAUSE_LATITUDE; /** * Updater for {@link TripStatistics}. @@ -123,7 +123,7 @@ public class TripStatisticsUpdater { updateTime(location.getTime()); if (!LocationUtils.isValidLocation(location)) { // Either pause or resume marker - if (location.getLatitude() == PAUSE_LATITUDE) { + if (location.getLatitude() == TrackPointsColumns.PAUSE_LATITUDE) { if (lastLocation != null && lastMovingLocation != null && lastLocation != lastMovingLocation) { currentSegment.addTotalDistance(lastMovingLocation.distanceTo(lastLocation)); }