From ee4f33429621b859ff8426b6dd782bb72df9ad8b Mon Sep 17 00:00:00 2001 From: Bartlomiej Niechwiej Date: Sun, 24 Oct 2010 03:26:32 -0700 Subject: [PATCH] Fixed a NPE under certain circumstances (move initialization to onCreate()). --- .../google/android/apps/mytracks/StatsActivity.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/MyTracks/src/com/google/android/apps/mytracks/StatsActivity.java b/MyTracks/src/com/google/android/apps/mytracks/StatsActivity.java index c492a0bb8..9d68c9c27 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/StatsActivity.java +++ b/MyTracks/src/com/google/android/apps/mytracks/StatsActivity.java @@ -52,7 +52,7 @@ import android.widget.Toast; public class StatsActivity extends Activity implements OnSharedPreferenceChangeListener { - private final StatsUtilities utils; + private StatsUtilities utils; private UIUpdateThread thread; private ContentObserver observer; @@ -94,7 +94,7 @@ public class StatsActivity extends Activity */ private boolean showCurrentSegment = false; - private final MyTracksProviderUtils providerUtils; + private MyTracksProviderUtils providerUtils; /** * A runnable for posting to the UI thread. Will update the total time field. @@ -133,16 +133,14 @@ public class StatsActivity extends Activity } } - public StatsActivity() { - utils = new StatsUtilities(this); - providerUtils = new MyTracksProviderUtilsImpl(getContentResolver()); - } - /** Called when the activity is first created. */ @Override public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); + utils = new StatsUtilities(this); + providerUtils = new MyTracksProviderUtilsImpl(getContentResolver()); + // The volume we want to control is the Text-To-Speech volume int volumeStream = new StatusAnnouncerFactory(ApiFeatures.getInstance()).getVolumeStream();