code review comments

This commit is contained in:
Matthew Simmons
2011-04-06 18:46:14 -04:00
parent a1ff1d2585
commit f984339b13
3 changed files with 21 additions and 17 deletions
@@ -88,26 +88,26 @@ class WriteProgressController {
} }
private final TrackWriter.OnCompletionListener writerCompleteListener = private final TrackWriter.OnCompletionListener writerCompleteListener =
new TrackWriter.OnCompletionListener() { new TrackWriter.OnCompletionListener() {
@Override @Override
public void onComplete() { public void onComplete() {
DialogManager.dismissDialogSafely(activity, dialog); DialogManager.dismissDialogSafely(activity, dialog);
if (onCompletionListener != null) { if (onCompletionListener != null) {
onCompletionListener.onComplete(writer); onCompletionListener.onComplete(writer);
}
} }
} };
};
private final TrackWriter.OnWriteListener writerWriteListener = private final TrackWriter.OnWriteListener writerWriteListener =
new TrackWriter.OnWriteListener() { new TrackWriter.OnWriteListener() {
@Override @Override
public void onWrite(int number, int max) { public void onWrite(int number, int max) {
if (number % 500 == 0) { if (number % 500 == 0) {
dialog.setIndeterminate(false); dialog.setIndeterminate(false);
dialog.setMax(max); dialog.setMax(max);
dialog.setProgress(Math.min(number, max)); dialog.setProgress(Math.min(number, max));
}
} }
} };
};
} }
@@ -24,6 +24,9 @@ import android.test.ActivityInstrumentationTestCase2;
import java.util.concurrent.Semaphore; import java.util.concurrent.Semaphore;
import java.util.concurrent.atomic.AtomicReference; import java.util.concurrent.atomic.AtomicReference;
/**
* @author Matthew Simmons
*/
public class WriteProgressControllerTest extends ActivityInstrumentationTestCase2<MyTracks> { public class WriteProgressControllerTest extends ActivityInstrumentationTestCase2<MyTracks> {
public WriteProgressControllerTest() { public WriteProgressControllerTest() {
super(MyTracks.class); super(MyTracks.class);
@@ -41,6 +41,7 @@ public class MockTrackWriter implements TrackWriter {
@Override @Override
public void setDirectory(File directory) { public void setDirectory(File directory) {
throw new RuntimeException("not implemented");
} }
@Override @Override