diff --git a/src/main/AndroidManifest.xml b/src/main/AndroidManifest.xml index 0182b62d5..f8b5ee154 100644 --- a/src/main/AndroidManifest.xml +++ b/src/main/AndroidManifest.xml @@ -38,7 +38,7 @@ limitations under the License. + android:theme="@style/TrackDeleteActivity" /> + android:theme="@style/ThemeCustomTransparentActivity"> @@ -105,7 +105,7 @@ limitations under the License. + android:theme="@style/ThemeCustomTransparentActivity" /> diff --git a/src/main/java/de/dennisguse/opentracks/DeleteAsyncTask.java b/src/main/java/de/dennisguse/opentracks/DeleteAsyncTask.java index f2fcb1ac6..ea1089a04 100644 --- a/src/main/java/de/dennisguse/opentracks/DeleteAsyncTask.java +++ b/src/main/java/de/dennisguse/opentracks/DeleteAsyncTask.java @@ -60,13 +60,6 @@ class DeleteAsyncTask extends AsyncTask { } } - @Override - protected void onPreExecute() { - if (deleteActivity != null) { - deleteActivity.showProgressDialog(); - } - } - @Override protected Boolean doInBackground(Void... params) { ContentProviderUtils contentProviderUtils = new ContentProviderUtils(context); diff --git a/src/main/java/de/dennisguse/opentracks/TrackDeleteActivity.java b/src/main/java/de/dennisguse/opentracks/TrackDeleteActivity.java index 944716a4b..accdfd932 100644 --- a/src/main/java/de/dennisguse/opentracks/TrackDeleteActivity.java +++ b/src/main/java/de/dennisguse/opentracks/TrackDeleteActivity.java @@ -17,15 +17,11 @@ package de.dennisguse.opentracks; import android.app.Activity; -import android.app.Dialog; -import android.content.DialogInterface; import android.content.Intent; import android.os.Bundle; -import de.dennisguse.opentracks.util.DialogUtils; - /** - * An activity for delete tracks. + * An activity for deleting tracks. * * @author Jimmy Shih */ @@ -33,14 +29,14 @@ public class TrackDeleteActivity extends Activity { public static final String EXTRA_TRACK_IDS = "track_ids"; - private static final int DIALOG_PROGRESS_ID = 0; - private DeleteAsyncTask deleteAsyncTask; @Override public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); + setContentView(R.layout.track_delete); + setResult(RESULT_CANCELED); Intent intent = getIntent(); @@ -56,41 +52,20 @@ public class TrackDeleteActivity extends Activity { } } + @Override + protected void onStop() { + super.onStop(); + deleteAsyncTask.cancel(true); + } + @Override public Object onRetainNonConfigurationInstance() { deleteAsyncTask.setActivity(null); return deleteAsyncTask; } - @Override - protected Dialog onCreateDialog(int id) { - if (id != DIALOG_PROGRESS_ID) { - return null; - } - return DialogUtils.createSpinnerProgressDialog( - this, R.string.track_delete_progress_message, new DialogInterface.OnCancelListener() { - @Override - public void onCancel(DialogInterface dialog) { - deleteAsyncTask.cancel(true); - dialog.dismiss(); - finish(); - } - }); - } - - /** - * Invokes when the associated AsyncTask completes. - */ public void onAsyncTaskCompleted() { - removeDialog(DIALOG_PROGRESS_ID); setResult(RESULT_OK); finish(); } - - /** - * Shows the progress dialog. - */ - public void showProgressDialog() { - showDialog(DIALOG_PROGRESS_ID); - } } diff --git a/src/main/java/de/dennisguse/opentracks/util/DialogUtils.java b/src/main/java/de/dennisguse/opentracks/util/DialogUtils.java index 3c2dff4a6..1eb8224a5 100644 --- a/src/main/java/de/dennisguse/opentracks/util/DialogUtils.java +++ b/src/main/java/de/dennisguse/opentracks/util/DialogUtils.java @@ -52,17 +52,6 @@ public class DialogUtils { .setTitle(titleId).create(); } - /** - * Creates a spinner progress dialog. - * - * @param context the context - * @param messageId the progress message id - * @param onCancelListener the cancel listener - */ - public static ProgressDialog createSpinnerProgressDialog(Context context, int messageId, DialogInterface.OnCancelListener onCancelListener) { - return createProgressDialog(true, context, messageId, onCancelListener); - } - /** * Creates a horizontal progress dialog. * @@ -72,27 +61,26 @@ public class DialogUtils { * @param formatArgs the format arguments for the messageId */ public static ProgressDialog createHorizontalProgressDialog(Context context, int messageId, DialogInterface.OnCancelListener onCancelListener, Object... formatArgs) { - return createProgressDialog(false, context, messageId, onCancelListener, formatArgs); + return createProgressDialog(context, messageId, onCancelListener, formatArgs); } /** * Creates a progress dialog. * - * @param spinner true to use the spinner style * @param context the context * @param messageId the progress message id * @param onCancelListener the cancel listener * @param formatArgs the format arguments for the message id */ - private static ProgressDialog createProgressDialog(boolean spinner, final Context context, int messageId, DialogInterface.OnCancelListener onCancelListener, Object... formatArgs) { - final ProgressDialog progressDialog = new ProgressDialog(context, R.style.ThemeCustomNotTransparent); + private static ProgressDialog createProgressDialog(final Context context, int messageId, DialogInterface.OnCancelListener onCancelListener, Object... formatArgs) { + final ProgressDialog progressDialog = new ProgressDialog(context, R.style.ThemeCustomNotTransparentDialog); progressDialog.setCancelable(true); progressDialog.setCanceledOnTouchOutside(false); progressDialog.setIcon(R.drawable.ic_dialog_info_24dp); progressDialog.setIndeterminate(true); progressDialog.setMessage(context.getString(messageId, formatArgs)); progressDialog.setOnCancelListener(onCancelListener); - progressDialog.setProgressStyle(spinner ? ProgressDialog.STYLE_SPINNER : ProgressDialog.STYLE_HORIZONTAL); + progressDialog.setProgressStyle(ProgressDialog.STYLE_HORIZONTAL); progressDialog.setTitle(R.string.generic_progress_title); return progressDialog; } diff --git a/src/main/res/layout/track_delete.xml b/src/main/res/layout/track_delete.xml new file mode 100644 index 000000000..dccefd632 --- /dev/null +++ b/src/main/res/layout/track_delete.xml @@ -0,0 +1,11 @@ + + + + + \ No newline at end of file diff --git a/src/main/res/values/themes_custom.xml b/src/main/res/values/themes_custom.xml index e078da93c..ac8986c17 100644 --- a/src/main/res/values/themes_custom.xml +++ b/src/main/res/values/themes_custom.xml @@ -35,8 +35,8 @@ limitations under the License. @color/holo_orange_dark true - - - + +