From 53e8c01d8885f699fd9744f481c21264c74409fd Mon Sep 17 00:00:00 2001 From: Moez Bhatti Date: Wed, 20 Jun 2018 15:13:51 -0400 Subject: [PATCH] Move AnalyticsManagerImpl to data module --- data/build.gradle | 9 +++++++++ .../moez/QKSMS/common/util/AnalyticsManagerImpl.kt | 2 +- .../moez/QKSMS/common/util/AnalyticsManagerImpl.kt | 0 presentation/build.gradle | 13 +++++++++++-- 4 files changed, 21 insertions(+), 3 deletions(-) rename {presentation => data}/src/noAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt (95%) rename {presentation => data}/src/withAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt (100%) diff --git a/data/build.gradle b/data/build.gradle index 73d40b18..5a45c98f 100644 --- a/data/build.gradle +++ b/data/build.gradle @@ -4,11 +4,18 @@ apply plugin: 'kotlin-kapt' android { compileSdkVersion 28 + publishNonDefault true + flavorDimensions "analytics" defaultConfig { minSdkVersion 21 targetSdkVersion 28 } + + productFlavors { + withAnalytics { dimension "analytics" } + noAnalytics { dimension "analytics" } + } } dependencies { @@ -35,6 +42,8 @@ dependencies { implementation "me.leolin:ShortcutBadger:1.1.21" implementation project(":android-smsmms") implementation project(':domain') + withAnalyticsImplementation "com.amplitude:android-sdk:2.16.0" + withAnalyticsImplementation "com.mixpanel.android:mixpanel-android:5.2.1" } repositories { diff --git a/presentation/src/noAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt b/data/src/noAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt similarity index 95% rename from presentation/src/noAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt rename to data/src/noAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt index ee486505..c2d36d08 100644 --- a/presentation/src/noAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt +++ b/data/src/noAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt @@ -18,7 +18,7 @@ */ package com.moez.QKSMS.common.util -import manager.AnalyticsManager +import com.moez.QKSMS.manager.AnalyticsManager import javax.inject.Inject import javax.inject.Singleton diff --git a/presentation/src/withAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt b/data/src/withAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt similarity index 100% rename from presentation/src/withAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt rename to data/src/withAnalytics/java/com/moez/QKSMS/common/util/AnalyticsManagerImpl.kt diff --git a/presentation/build.gradle b/presentation/build.gradle index af2a8ae2..875465a7 100644 --- a/presentation/build.gradle +++ b/presentation/build.gradle @@ -77,6 +77,13 @@ android.applicationVariants.all { variant -> } } +configurations { + noAnalyticsDebug + noAnalyticsRelease + withAnalyticsDebug + withAnalyticsRelease +} + dependencies { // lifecycle implementation "android.arch.lifecycle:extensions:$lifecycle_version" @@ -151,6 +158,8 @@ dependencies { implementation project(":android-smsmms") implementation project(':data') implementation project(':domain') - withAnalyticsImplementation "com.amplitude:android-sdk:2.16.0" - withAnalyticsImplementation "com.mixpanel.android:mixpanel-android:5.2.1" + noAnalyticsDebug project(path: ':data', configuration: 'noAnalyticsDebug') + noAnalyticsRelease project(path: ':data', configuration: 'noAnalyticsRelease') + withAnalyticsDebug project(path: ':data', configuration: 'withAnalyticsDebug') + withAnalyticsRelease project(path: ':data', configuration: 'withAnalyticsRelease') }