From 5cc975522ef1a33e22c887c5d5eb2c8220692c7c Mon Sep 17 00:00:00 2001 From: George Kankava Date: Sat, 2 Jul 2016 10:36:39 +0400 Subject: [PATCH] squid:S1155 - Collection.isEmpty() should be used to test for emptiness --- QKSMS/src/main/java/android/net/DhcpInfoInternal.java | 2 +- .../java/com/android/mms/dom/smil/ElementTimeImpl.java | 4 ++-- .../com/android/mms/transaction/TransactionService.java | 6 +++--- .../java/com/moez/QKSMS/common/google/DraftCache.java | 2 +- QKSMS/src/main/java/com/moez/QKSMS/data/Contact.java | 6 +++--- QKSMS/src/main/java/com/moez/QKSMS/exif/ExifData.java | 8 ++++---- .../src/main/java/com/moez/QKSMS/exif/ExifInterface.java | 2 +- .../main/java/com/moez/QKSMS/external/iab/IabHelper.java | 2 +- QKSMS/src/main/java/com/moez/QKSMS/model/MediaModel.java | 2 +- .../com/moez/QKSMS/ui/delivery/DeliveryReportHelper.java | 2 +- .../com/moez/QKSMS/ui/dialog/mms/MMSSetupFragment.java | 2 +- 11 files changed, 19 insertions(+), 19 deletions(-) diff --git a/QKSMS/src/main/java/android/net/DhcpInfoInternal.java b/QKSMS/src/main/java/android/net/DhcpInfoInternal.java index 8e4e6da5..69fea1b2 100644 --- a/QKSMS/src/main/java/android/net/DhcpInfoInternal.java +++ b/QKSMS/src/main/java/android/net/DhcpInfoInternal.java @@ -140,7 +140,7 @@ public class DhcpInfoInternal { dns2 = orig.dns2; } - if (mRoutes.size() == 0) { + if (mRoutes.isEmpty()) { for (RouteInfo route : orig.getRoutes()) { addRoute(route); } diff --git a/QKSMS/src/main/java/com/android/mms/dom/smil/ElementTimeImpl.java b/QKSMS/src/main/java/com/android/mms/dom/smil/ElementTimeImpl.java index a3443cd8..d3e11305 100644 --- a/QKSMS/src/main/java/com/android/mms/dom/smil/ElementTimeImpl.java +++ b/QKSMS/src/main/java/com/android/mms/dom/smil/ElementTimeImpl.java @@ -81,7 +81,7 @@ public abstract class ElementTimeImpl implements ElementTime { // Ignore badly formatted times } } - if (beginTimeList.size() == 0) { + if (beginTimeList.isEmpty()) { /* * What is the right default value? * @@ -139,7 +139,7 @@ public abstract class ElementTimeImpl implements ElementTime { } // "end" time is not specified - if (endTimeList.size() == 0) { + if (endTimeList.isEmpty()) { // Get duration float duration = getDur(); diff --git a/QKSMS/src/main/java/com/android/mms/transaction/TransactionService.java b/QKSMS/src/main/java/com/android/mms/transaction/TransactionService.java index 699348cf..aba3ab71 100644 --- a/QKSMS/src/main/java/com/android/mms/transaction/TransactionService.java +++ b/QKSMS/src/main/java/com/android/mms/transaction/TransactionService.java @@ -473,7 +473,7 @@ public class TransactionService extends Service implements Observer { try { synchronized (mProcessing) { mProcessing.remove(transaction); - if (mPending.size() > 0) { + if (!mPending.isEmpty()) { if (LOCAL_LOGV) Log.v(TAG, "update: handle next pending transaction..."); Message msg = mServiceHandler.obtainMessage( EVENT_HANDLE_NEXT_PENDING_TRANSACTION, @@ -799,7 +799,7 @@ public class TransactionService extends Service implements Observer { public void markAllPendingTransactionsAsFailed() { synchronized (mProcessing) { - while (mPending.size() != 0) { + while (!mPending.isEmpty()) { Transaction transaction = mPending.remove(0); transaction.mTransactionState.setState(TransactionState.FAILED); if (transaction instanceof SendTransaction) { @@ -824,7 +824,7 @@ public class TransactionService extends Service implements Observer { int numProcessTransaction; synchronized (mProcessing) { - if (mPending.size() != 0) { + if (!mPending.isEmpty()) { transaction = mPending.remove(0); } numProcessTransaction = mProcessing.size(); diff --git a/QKSMS/src/main/java/com/moez/QKSMS/common/google/DraftCache.java b/QKSMS/src/main/java/com/moez/QKSMS/common/google/DraftCache.java index 832575af..2c49b653 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/common/google/DraftCache.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/common/google/DraftCache.java @@ -131,7 +131,7 @@ public class DraftCache { // If nobody's interested in finding out about changes, // just bail out early. synchronized (mChangeListenersLock) { - if (mChangeListeners.size() < 1) { + if (mChangeListeners.isEmpty()) { return; } } diff --git a/QKSMS/src/main/java/com/moez/QKSMS/data/Contact.java b/QKSMS/src/main/java/com/moez/QKSMS/data/Contact.java index 2686a569..4d447f4e 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/data/Contact.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/data/Contact.java @@ -503,14 +503,14 @@ public class Contact { while (true) { Runnable r = null; synchronized (mThingsToLoad) { - if (mThingsToLoad.size() == 0) { + if (mThingsToLoad.isEmpty()) { try { mThingsToLoad.wait(); } catch (InterruptedException ex) { break; // Exception sent by Contact.init() to stop Runnable } } - if (mThingsToLoad.size() > 0) { + if (!mThingsToLoad.isEmpty()) { r = mThingsToLoad.remove(0); } } @@ -1175,7 +1175,7 @@ public class Contact { } } } - if (candidates.size() == 0) { + if (candidates.isEmpty()) { mContactsHash.remove(key); } } diff --git a/QKSMS/src/main/java/com/moez/QKSMS/exif/ExifData.java b/QKSMS/src/main/java/com/moez/QKSMS/exif/ExifData.java index 6a8eb851..3e7c1c45 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/exif/ExifData.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/exif/ExifData.java @@ -110,7 +110,7 @@ class ExifData { * Returns true if this header contains uncompressed strip. */ protected boolean hasUncompressedStrip() { - return mStripBytes.size() != 0; + return !mStripBytes.isEmpty(); } /** @@ -264,7 +264,7 @@ class ExifData { } } } - if (ret.size() == 0) { + if (ret.isEmpty()) { return null; } return ret; @@ -287,7 +287,7 @@ class ExifData { for (ExifTag t : tags) { ret.add(t); } - if (ret.size() == 0) { + if (ret.isEmpty()) { return null; } return ret; @@ -307,7 +307,7 @@ class ExifData { } } } - if (ret.size() == 0) { + if (ret.isEmpty()) { return null; } return ret; diff --git a/QKSMS/src/main/java/com/moez/QKSMS/exif/ExifInterface.java b/QKSMS/src/main/java/com/moez/QKSMS/exif/ExifInterface.java index b2f09621..6c7c6159 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/exif/ExifInterface.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/exif/ExifInterface.java @@ -2348,7 +2348,7 @@ public class ExifInterface { l.add(ifds[i]); } } - if (l.size() <= 0) { + if (l.isEmpty()) { return null; } int[] ret = new int[l.size()]; diff --git a/QKSMS/src/main/java/com/moez/QKSMS/external/iab/IabHelper.java b/QKSMS/src/main/java/com/moez/QKSMS/external/iab/IabHelper.java index 41df69fb..b2f01221 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/external/iab/IabHelper.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/external/iab/IabHelper.java @@ -921,7 +921,7 @@ public class IabHelper { } } - if (skuList.size() == 0) { + if (skuList.isEmpty()) { logDebug("queryPrices: nothing to do because there are no SKUs."); return BILLING_RESPONSE_RESULT_OK; } diff --git a/QKSMS/src/main/java/com/moez/QKSMS/model/MediaModel.java b/QKSMS/src/main/java/com/moez/QKSMS/model/MediaModel.java index cad605e3..d97edc23 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/model/MediaModel.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/model/MediaModel.java @@ -282,7 +282,7 @@ public abstract class MediaModel extends Model implements EventListener { } public MediaAction getCurrentAction() { - if (0 == mMediaActions.size()) { + if (mMediaActions.isEmpty()) { return MediaAction.NO_ACTIVE_ACTION; } return mMediaActions.remove(0); diff --git a/QKSMS/src/main/java/com/moez/QKSMS/ui/delivery/DeliveryReportHelper.java b/QKSMS/src/main/java/com/moez/QKSMS/ui/delivery/DeliveryReportHelper.java index 7bbab4e1..d2e10596 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/ui/delivery/DeliveryReportHelper.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/ui/delivery/DeliveryReportHelper.java @@ -208,7 +208,7 @@ public class DeliveryReportHelper { return null; } - if (reportReqs.size() == 0) { + if (reportReqs.isEmpty()) { return null; } diff --git a/QKSMS/src/main/java/com/moez/QKSMS/ui/dialog/mms/MMSSetupFragment.java b/QKSMS/src/main/java/com/moez/QKSMS/ui/dialog/mms/MMSSetupFragment.java index 9b7fd721..4a73eb25 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/ui/dialog/mms/MMSSetupFragment.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/ui/dialog/mms/MMSSetupFragment.java @@ -207,7 +207,7 @@ public class MMSSetupFragment extends QKFragment implements DialogFragmentListen } private void showConfigurationDialog() { - if (mAPNs.size() == 0) { + if (mAPNs.isEmpty()) { // Give the user a support channel and further instructions if automatic // configuration failed. launchDialog(NO_CONFIGURATIONS_FOUND);