From 62e370127f52d4b9dc19edd1feafa8c27afb80c7 Mon Sep 17 00:00:00 2001
From: moezbhatti <moez.bhatti@gmail.com>
Date: Wed, 26 Dec 2018 01:04:44 -0500
Subject: [PATCH] Conclude rating threshold experiment

---
 .../moez/QKSMS/mapper/RatingManagerImpl.kt    | 29 ++++---------------
 1 file changed, 6 insertions(+), 23 deletions(-)

diff --git a/data/src/main/java/com/moez/QKSMS/mapper/RatingManagerImpl.kt b/data/src/main/java/com/moez/QKSMS/mapper/RatingManagerImpl.kt
index a66dcd09..ba85267c 100644
--- a/data/src/main/java/com/moez/QKSMS/mapper/RatingManagerImpl.kt
+++ b/data/src/main/java/com/moez/QKSMS/mapper/RatingManagerImpl.kt
@@ -18,10 +18,7 @@
  */
 package com.moez.QKSMS.mapper
 
-import android.content.Context
 import com.f2prateek.rx.preferences2.RxSharedPreferences
-import com.moez.QKSMS.experiment.Experiment
-import com.moez.QKSMS.experiment.Variant
 import com.moez.QKSMS.manager.AnalyticsManager
 import com.moez.QKSMS.manager.RatingManager
 import io.reactivex.rxkotlin.Observables
@@ -29,10 +26,13 @@ import javax.inject.Inject
 
 class RatingManagerImpl @Inject constructor(
     rxPrefs: RxSharedPreferences,
-    private val analyticsManager: AnalyticsManager,
-    private val ratingThresholdExperiment: RatingThresholdExperiment
+    private val analyticsManager: AnalyticsManager
 ) : RatingManager {
 
+    companion object {
+        private const val RATING_THRESHOLD = 10
+    }
+
     private val sessions = rxPrefs.getInteger("sessions", 0)
     private val rated = rxPrefs.getBoolean("rated", false)
     private val dismissed = rxPrefs.getBoolean("dismissed", false)
@@ -42,7 +42,7 @@ class RatingManagerImpl @Inject constructor(
             rated.asObservable(),
             dismissed.asObservable()) { sessions, rated, dismissed ->
 
-        sessions > ratingThresholdExperiment.variant && !rated && !dismissed
+        sessions > RATING_THRESHOLD && !rated && !dismissed
     }
 
     override fun addSession() {
@@ -60,20 +60,3 @@ class RatingManagerImpl @Inject constructor(
     }
 
 }
-
-class RatingThresholdExperiment @Inject constructor(
-    context: Context,
-    analytics: AnalyticsManager
-) : Experiment<Int>(context, analytics) {
-
-    override val key: String = "Rating Threshold"
-
-    override val variants: List<Variant<Int>> = listOf(
-            Variant("variant_a", 100),
-            Variant("variant_b", 10))
-
-    override val default: Int = 100
-
-    override val qualifies: Boolean = true
-
-}
\ No newline at end of file