From 6dff95d1e504628f7eb86e14362d367d423dccbf Mon Sep 17 00:00:00 2001 From: Inhishonor Date: Fri, 3 Apr 2026 09:27:35 -0700 Subject: [PATCH] fix(compose): Prevent infinite loop on editing scheduled message For some asinine reason, `state.scheduled` was observed than set with the same value, which was causing an infinite loop. `scheduled` is completely irrelevant to `canSend` anyway, as scheduled is essentially a boolean, and it is handled elsewhere. --- .../moez/QKSMS/feature/compose/ComposeViewModel.kt | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeViewModel.kt b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeViewModel.kt index 440a975e..189bf3ec 100644 --- a/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeViewModel.kt +++ b/presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeViewModel.kt @@ -924,21 +924,18 @@ class ComposeViewModel @Inject constructor( } } - // set canSend state depending on if there is text input, an attachment or a schedule set + // set canSend state depending on if there is text input or an attachment Observables.combineLatest( - view.textChangedIntent, // input message text changed + view.textChangedIntent, state - .distinctUntilChanged { state -> state.attachments } // attachments changed - .map { it.attachments.size }, // number of attachments - state.distinctUntilChanged { state -> state.scheduled } // schedule set or not - .map { it.scheduled } + .distinctUntilChanged { state -> state.attachments } + .map { it.attachments.size } ) .autoDisposable(view.scope()) .subscribe { newState { copy( - canSend = (it.first.isNotBlank() || (it.second > 0)), - scheduled = it.third + canSend = (it.first.isNotBlank() || (it.second > 0)) ) } }