From 7332e5aa34918a00c4f5faa91546a42fe3e5f0f8 Mon Sep 17 00:00:00 2001 From: Moez Bhatti Date: Thu, 3 May 2018 00:34:56 -0400 Subject: [PATCH] #1118 - Add ContentDescriptions for buttons in Main and Compose activities --- presentation/src/main/res/layout/compose_activity.xml | 4 ++++ presentation/src/main/res/layout/main_activity.xml | 1 + presentation/src/main/res/values/strings.xml | 5 +++++ 3 files changed, 10 insertions(+) diff --git a/presentation/src/main/res/layout/compose_activity.xml b/presentation/src/main/res/layout/compose_activity.xml index 0b19ab2d..6f63024d 100644 --- a/presentation/src/main/res/layout/compose_activity.xml +++ b/presentation/src/main/res/layout/compose_activity.xml @@ -121,6 +121,7 @@ android:layout_width="44dp" android:layout_height="44dp" android:layout_marginStart="8dp" + android:contentDescription="@string/compose_attach_cd" android:padding="10dp" android:src="@drawable/ic_add_circle_black_24dp" app:layout_constraintBottom_toBottomOf="@id/message" @@ -132,6 +133,7 @@ android:layout_width="44dp" android:layout_height="44dp" android:background="@drawable/ripple" + android:contentDescription="@string/compose_camera_cd" android:padding="10dp" android:src="@drawable/ic_camera_alt_black_24dp" android:visibility="gone" @@ -145,6 +147,7 @@ android:layout_height="44dp" android:layout_marginEnd="8dp" android:background="@drawable/ripple" + android:contentDescription="@string/compose_gallery_cd" android:padding="10dp" android:src="@drawable/ic_insert_photo_black_24dp" android:visibility="gone" @@ -202,6 +205,7 @@ android:layout_marginBottom="8dp" android:layout_marginEnd="8dp" android:background="@drawable/circle" + android:contentDescription="@string/compose_send_cd" android:elevation="4dp" android:padding="10dp" android:src="@drawable/ic_send_black_24dp" diff --git a/presentation/src/main/res/layout/main_activity.xml b/presentation/src/main/res/layout/main_activity.xml index 99bd5206..0b7d8d5b 100644 --- a/presentation/src/main/res/layout/main_activity.xml +++ b/presentation/src/main/res/layout/main_activity.xml @@ -125,6 +125,7 @@ android:layout_height="wrap_content" android:layout_gravity="bottom|end" android:layout_margin="16dp" + android:contentDescription="@string/main_fab_cd" android:src="@drawable/ic_add_black_24dp" android:tint="@color/white" app:layout_anchor="@+id/recyclerView" diff --git a/presentation/src/main/res/values/strings.xml b/presentation/src/main/res/values/strings.xml index 26c3b841..0fc21e65 100644 --- a/presentation/src/main/res/values/strings.xml +++ b/presentation/src/main/res/values/strings.xml @@ -50,6 +50,7 @@ No results Your archived conversations will appear here Your scheduled messages will appear here + Start new conversation Inbox Archived @@ -78,6 +79,10 @@ Copy text Forward Delete + Add an attachment + Attach a photo + Take a photo + Send message Sending… Delivered %s