From 76e1aef66bef393122d0544a23992c41d9d4a135 Mon Sep 17 00:00:00 2001 From: Moez Bhatti Date: Thu, 29 Mar 2018 06:42:09 -0400 Subject: [PATCH] Use one layout for all conversation items --- .../conversations/ConversationsAdapter.kt | 22 +++-- .../layout/conversation_list_item_unread.xml | 87 ------------------- 2 files changed, 10 insertions(+), 99 deletions(-) delete mode 100644 presentation/src/main/res/layout/conversation_list_item_unread.xml diff --git a/presentation/src/main/java/feature/conversations/ConversationsAdapter.kt b/presentation/src/main/java/feature/conversations/ConversationsAdapter.kt index 41e82fa9..78660eec 100644 --- a/presentation/src/main/java/feature/conversations/ConversationsAdapter.kt +++ b/presentation/src/main/java/feature/conversations/ConversationsAdapter.kt @@ -19,6 +19,7 @@ package feature.conversations import android.content.Context +import android.graphics.Typeface import android.view.LayoutInflater import android.view.ViewGroup import com.jakewharton.rxbinding2.view.clicks @@ -28,8 +29,6 @@ import common.base.FlowableAdapter import common.base.QkViewHolder import common.util.Colors import common.util.DateFormatter -import io.reactivex.disposables.CompositeDisposable -import io.reactivex.rxkotlin.plusAssign import io.reactivex.subjects.PublishSubject import io.reactivex.subjects.Subject import kotlinx.android.synthetic.main.conversation_list_item.view.* @@ -47,24 +46,23 @@ class ConversationsAdapter @Inject constructor( val clicks: Subject = PublishSubject.create() val longClicks: Subject = PublishSubject.create() - private val disposables = CompositeDisposable() - init { setHasStableIds(true) } override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): QkViewHolder { - val layoutRes = when (viewType) { - 0 -> R.layout.conversation_list_item - else -> R.layout.conversation_list_item_unread - } - val layoutInflater = LayoutInflater.from(context) - val view = layoutInflater.inflate(layoutRes, parent, false) + val view = layoutInflater.inflate(R.layout.conversation_list_item, parent, false) if (viewType == 1) { - disposables += colors.theme - .subscribe { color -> view.date.setTextColor(color) } + view.title.setTypeface(view.title.typeface, Typeface.BOLD) + + view.snippet.setTypeface(view.snippet.typeface, Typeface.BOLD) + view.snippet.textColorObservable = colors.textPrimary + view.snippet.maxLines = 5 + + view.date.setTypeface(view.date.typeface, Typeface.BOLD) + view.date.textColorObservable = colors.textPrimary } return QkViewHolder(view) diff --git a/presentation/src/main/res/layout/conversation_list_item_unread.xml b/presentation/src/main/res/layout/conversation_list_item_unread.xml deleted file mode 100644 index bda13a28..00000000 --- a/presentation/src/main/res/layout/conversation_list_item_unread.xml +++ /dev/null @@ -1,87 +0,0 @@ - - - - - - - - - - - - - \ No newline at end of file