From 7712deeb823f0cc39db497706cea0add0adedc40 Mon Sep 17 00:00:00 2001 From: Inhishonor Date: Fri, 22 Aug 2025 16:35:59 -0700 Subject: [PATCH 1/2] Fix PII leaked in logs Conversation.title was being used in logging, which is either contact name, or phone number. --- .../main/java/com/moez/QKSMS/common/util/ShortcutManagerImpl.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/presentation/src/main/java/com/moez/QKSMS/common/util/ShortcutManagerImpl.kt b/presentation/src/main/java/com/moez/QKSMS/common/util/ShortcutManagerImpl.kt index 983c480b..fc352ae5 100644 --- a/presentation/src/main/java/com/moez/QKSMS/common/util/ShortcutManagerImpl.kt +++ b/presentation/src/main/java/com/moez/QKSMS/common/util/ShortcutManagerImpl.kt @@ -101,7 +101,7 @@ class ShortcutManagerImpl @Inject constructor( @TargetApi(29) private fun createShortcutForConversation(conversation: Conversation): ShortcutInfoCompat { - Timber.v("creating shortcut for conversation ${conversation.id} : ${conversation.getTitle()}") + Timber.v("creating shortcut for conversation ${conversation.id}") val icon = when { conversation.recipients.size == 1 -> { val recipient = conversation.recipients.first()!! From 1d56096dd808fb2daaa8dbbb00becc820a5342c5 Mon Sep 17 00:00:00 2001 From: Inhishonor Date: Fri, 22 Aug 2025 16:44:04 -0700 Subject: [PATCH 2/2] Bump Timber to 5.0.1 --- build.gradle | 2 +- .../src/main/java/com/moez/QKSMS/common/util/FileLoggingTree.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build.gradle b/build.gradle index de3e2c1d..9d2e3054 100644 --- a/build.gradle +++ b/build.gradle @@ -32,7 +32,7 @@ buildscript { ext.rxjava_version = '2.1.4' ext.rxkotlin_version = '2.1.0' ext.rx_preferences_version = '2.0.0-RC3' - ext.timber_version = '4.5.1' + ext.timber_version = '5.0.1' ext.androidx_work_version = "2.8.0" ext.abiCodes = ['armeabi-v7a': 1, 'arm64-v8a': 2] diff --git a/presentation/src/main/java/com/moez/QKSMS/common/util/FileLoggingTree.kt b/presentation/src/main/java/com/moez/QKSMS/common/util/FileLoggingTree.kt index bead7e56..db425a3a 100644 --- a/presentation/src/main/java/com/moez/QKSMS/common/util/FileLoggingTree.kt +++ b/presentation/src/main/java/com/moez/QKSMS/common/util/FileLoggingTree.kt @@ -45,7 +45,7 @@ class FileLoggingTree @Inject constructor( private var logFileUri: Uri? = null - override fun log(priority: Int, tag: String, message: String, t: Throwable?) { + override fun log(priority: Int, tag: String?, message: String, t: Throwable?) { if (!prefs.logging.get()) return Schedulers.io().scheduleDirect {