Dispose of all Rx Streams and Intents in ViewModel

This commit is contained in:
Moez Bhatti
2017-11-01 15:20:56 -07:00
parent 8a313f0269
commit 915887dc6b
5 changed files with 34 additions and 24 deletions
@@ -6,6 +6,7 @@ import com.moez.QKSMS.data.repository.MessageRepository
import com.moez.QKSMS.domain.interactor.MarkRead
import com.moez.QKSMS.domain.interactor.SendMessage
import com.moez.QKSMS.presentation.base.QkViewModel
import io.reactivex.rxkotlin.plusAssign
import javax.inject.Inject
class MessagesViewModel(val threadId: Long) : QkViewModel<MessagesView, MessagesState>(MessagesState()) {
@@ -19,6 +20,9 @@ class MessagesViewModel(val threadId: Long) : QkViewModel<MessagesView, Messages
init {
AppComponentManager.appComponent.inject(this)
disposables += sendMessage.disposables
disposables += markRead.disposables
dataChanged()
conversation = messageRepo.getConversationAsync(threadId)
conversation.addChangeListener { conversation: Conversation ->
@@ -36,11 +40,11 @@ class MessagesViewModel(val threadId: Long) : QkViewModel<MessagesView, Messages
override fun bindIntents(view: MessagesView) {
super.bindIntents(view)
view.textChangedIntent.subscribe { text ->
intents += view.textChangedIntent.subscribe { text ->
newState { it.copy(draft = text.toString(), canSend = text.isNotEmpty()) }
}
view.sendIntent.subscribe {
intents += view.sendIntent.subscribe {
val previousState = state.value!!
sendMessage.execute(SendMessage.Params(threadId, conversation.contacts[0].address, previousState.draft))
newState { it.copy(draft = "", canSend = false) }
@@ -53,8 +57,6 @@ class MessagesViewModel(val threadId: Long) : QkViewModel<MessagesView, Messages
override fun onCleared() {
super.onCleared()
sendMessage.dispose()
markRead.dispose()
conversation.removeAllChangeListeners()
}