squid:S1854 - Dead stores should be removed

This commit is contained in:
George Kankava
2016-03-05 13:33:25 +04:00
parent fad79c87a0
commit ac0c653983
5 changed files with 7 additions and 11 deletions
@@ -53,7 +53,7 @@ public class MessageStatusService extends IntentService {
byte[] pdu = intent.getByteArrayExtra("pdu"); byte[] pdu = intent.getByteArrayExtra("pdu");
String format = intent.getStringExtra("format"); String format = intent.getStringExtra("format");
SmsMessage message = updateMessageStatus(this, messageUri, pdu, format); updateMessageStatus(this, messageUri, pdu, format);
} }
private SmsMessage updateMessageStatus(Context context, Uri messageUri, byte[] pdu, private SmsMessage updateMessageStatus(Context context, Uri messageUri, byte[] pdu,
@@ -110,7 +110,7 @@ public class MmsMessageSender implements MessageSender {
values.put(Telephony.MmsSms.PendingMessages.RETRY_INDEX, 0); values.put(Telephony.MmsSms.PendingMessages.RETRY_INDEX, 0);
values.put(Telephony.MmsSms.PendingMessages.DUE_TIME, 0); values.put(Telephony.MmsSms.PendingMessages.DUE_TIME, 0);
Uri uri = SqliteWrapper.insert(mContext, mContext.getContentResolver(), SqliteWrapper.insert(mContext, mContext.getContentResolver(),
Telephony.MmsSms.PendingMessages.CONTENT_URI, values); Telephony.MmsSms.PendingMessages.CONTENT_URI, values);
} catch (Throwable e) { } catch (Throwable e) {
p.move(mMessageUri, Telephony.Mms.Outbox.CONTENT_URI); p.move(mMessageUri, Telephony.Mms.Outbox.CONTENT_URI);
@@ -40,10 +40,6 @@ public class MmsPushOutboxMessages extends BroadcastReceiver {
String action = intent.getAction(); String action = intent.getAction();
if(action.equalsIgnoreCase(INTENT_MMS_SEND_OUTBOX_MSG)){ if(action.equalsIgnoreCase(INTENT_MMS_SEND_OUTBOX_MSG)){
if (LOCAL_LOGV) Log.v(TAG, "Now waking up the MMS service"); if (LOCAL_LOGV) Log.v(TAG, "Now waking up the MMS service");
Intent service = new Intent(
TransactionService.HANDLE_PENDING_TRANSACTIONS_ACTION, null, context,
TransactionService.class
);
} }
} }
@@ -60,7 +60,7 @@ public class MmsSystemEventReceiver extends BroadcastReceiver {
String action = intent.getAction(); String action = intent.getAction();
if (action.equals("android.intent.action.CONTENT_CHANGED")) { if (action.equals("android.intent.action.CONTENT_CHANGED")) {
Uri changed = (Uri) intent.getParcelableExtra("deleted_contents"); intent.getParcelableExtra("deleted_contents");
} else if (action.equals(ConnectivityManager.CONNECTIVITY_ACTION)) { } else if (action.equals(ConnectivityManager.CONNECTIVITY_ACTION)) {
if (mConnMgr == null) { if (mConnMgr == null) {
mConnMgr = (ConnectivityManager) context mConnMgr = (ConnectivityManager) context
@@ -136,7 +136,7 @@ public class RetrieveTransaction extends Transaction implements Runnable {
throw new MmsException("Invalid M-Retrieve.conf PDU."); throw new MmsException("Invalid M-Retrieve.conf PDU.");
} }
Uri msgUri = null; Uri msgUri;
if (isDuplicateMessage(mContext, retrieveConf)) { if (isDuplicateMessage(mContext, retrieveConf)) {
// Mark this transaction as failed to prevent duplicate // Mark this transaction as failed to prevent duplicate
// notification to user. // notification to user.
@@ -225,11 +225,11 @@ public class RetrieveTransaction extends Transaction implements Runnable {
private static boolean isDuplicateMessageExtra(Cursor cursor, RetrieveConf rc) { private static boolean isDuplicateMessageExtra(Cursor cursor, RetrieveConf rc) {
// Compare message subjects, taking encoding into account // Compare message subjects, taking encoding into account
EncodedStringValue encodedSubjectReceived = null; EncodedStringValue encodedSubjectReceived;
EncodedStringValue encodedSubjectStored = null; EncodedStringValue encodedSubjectStored = null;
String subjectReceived = null; String subjectReceived = null;
String subjectStored = null; String subjectStored;
String subject = null; String subject;
encodedSubjectReceived = rc.getSubject(); encodedSubjectReceived = rc.getSubject();
if (encodedSubjectReceived != null) { if (encodedSubjectReceived != null) {