Set click listeners when creating viewHolder instead of binding

This commit is contained in:
Moez Bhatti
2018-08-10 21:59:37 -04:00
parent 64879857ac
commit b10f461752
12 changed files with 100 additions and 94 deletions
@@ -22,7 +22,6 @@ import android.content.Context
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.recyclerview.widget.RecyclerView
import com.moez.QKSMS.R
import com.moez.QKSMS.common.Navigator
import com.moez.QKSMS.common.base.QkRealmAdapter
@@ -32,7 +31,6 @@ import com.moez.QKSMS.extensions.isImage
import com.moez.QKSMS.extensions.isVideo
import com.moez.QKSMS.model.MmsPart
import com.moez.QKSMS.util.GlideApp
import io.reactivex.disposables.CompositeDisposable
import io.reactivex.subjects.PublishSubject
import kotlinx.android.synthetic.main.conversation_media_list_item.view.*
import javax.inject.Inject
@@ -44,11 +42,15 @@ class ConversationMediaAdapter @Inject constructor(
val thumbnailClicks: PublishSubject<View> = PublishSubject.create()
private val disposables = CompositeDisposable()
override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): QkViewHolder {
val view = LayoutInflater.from(parent.context).inflate(R.layout.conversation_media_list_item, parent, false)
return QkViewHolder(view)
val inflater = LayoutInflater.from(parent.context)
val view = inflater.inflate(R.layout.conversation_media_list_item, parent, false)
return QkViewHolder(view).apply {
view.thumbnail.setOnClickListener {
val part = getItem(adapterPosition)!!
if (part.isImage()) thumbnailClicks.onNext(it) else navigator.showMedia(part.id)
}
}
}
override fun onBindViewHolder(holder: QkViewHolder, position: Int) {
@@ -62,13 +64,6 @@ class ConversationMediaAdapter @Inject constructor(
view.video.setVisible(part.isVideo())
view.thumbnail.transitionName = part.id.toString()
view.thumbnail.setOnClickListener {
if (part.isImage()) thumbnailClicks.onNext(it) else navigator.showMedia(part.id)
}
}
override fun onDetachedFromRecyclerView(recyclerView: RecyclerView) {
disposables.clear()
}
}
@@ -42,21 +42,22 @@ class ConversationRecipientAdapter @Inject constructor(
override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): QkViewHolder {
val layoutInflater = LayoutInflater.from(parent.context)
val view = layoutInflater.inflate(R.layout.conversation_recipient_list_item, parent, false)
return QkViewHolder(view)
return QkViewHolder(view).apply {
view.setOnClickListener {
val recipient = getItem(adapterPosition)!!
if (recipient.contact == null) {
navigator.addContact(recipient.address)
} else {
view.avatar.callOnClick()
}
}
}
}
override fun onBindViewHolder(holder: QkViewHolder, position: Int) {
val recipient = getItem(position)!!
val view = holder.itemView
view.setOnClickListener {
if (recipient.contact == null) {
navigator.addContact(recipient.address)
} else {
view.avatar.callOnClick()
}
}
view.avatar.threadId = threadId
view.avatar.setContact(recipient)