From ce9be3031222718c50a66ca75c5750806dffdc81 Mon Sep 17 00:00:00 2001 From: George Kankava Date: Thu, 10 Mar 2016 10:43:50 +0400 Subject: [PATCH] squid:ClassVariableVisibilityCheck - Class variable fields should not have public accessibility --- .../moez/QKSMS/common/google/BlobCache.java | 30 +++++++++++++++++-- .../common/google/ImageCacheService.java | 20 +++++++++++-- .../QKSMS/common/google/ThumbnailManager.java | 4 +-- 3 files changed, 47 insertions(+), 7 deletions(-) diff --git a/QKSMS/src/main/java/com/moez/QKSMS/common/google/BlobCache.java b/QKSMS/src/main/java/com/moez/QKSMS/common/google/BlobCache.java index 793bd117..293c14b7 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/common/google/BlobCache.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/common/google/BlobCache.java @@ -400,9 +400,33 @@ public class BlobCache implements Closeable { } public static class LookupRequest { - public long key; // input: the key to find - public byte[] buffer; // input/output: the buffer to store the blob - public int length; // output: the length of the blob + private long key; // input: the key to find + private byte[] buffer; // input/output: the buffer to store the blob + private int length; // output: the length of the blob + + public long getKey() { + return key; + } + + public void setKey(long key) { + this.key = key; + } + + public byte[] getBuffer() { + return buffer; + } + + public void setBuffer(byte[] buffer) { + this.buffer = buffer; + } + + public int getLength() { + return length; + } + + public void setLength(int length) { + this.length = length; + } } // This method is for one-off lookup. For repeated lookup, use the version diff --git a/QKSMS/src/main/java/com/moez/QKSMS/common/google/ImageCacheService.java b/QKSMS/src/main/java/com/moez/QKSMS/common/google/ImageCacheService.java index a4be06e0..8d5a4f84 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/common/google/ImageCacheService.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/common/google/ImageCacheService.java @@ -50,8 +50,24 @@ public class ImageCacheService { mData = data; mOffset = offset; } - public byte[] mData; - public int mOffset; + private byte[] mData; + private int mOffset; + + public byte[] getData() { + return mData; + } + + public void setData(byte[] mData) { + this.mData = mData; + } + + public int getOffset() { + return mOffset; + } + + public void setOffset(int mOffset) { + this.mOffset = mOffset; + } } public ImageData getImageData(String path, int type) { diff --git a/QKSMS/src/main/java/com/moez/QKSMS/common/google/ThumbnailManager.java b/QKSMS/src/main/java/com/moez/QKSMS/common/google/ThumbnailManager.java index 6060131b..3b6a8807 100644 --- a/QKSMS/src/main/java/com/moez/QKSMS/common/google/ThumbnailManager.java +++ b/QKSMS/src/main/java/com/moez/QKSMS/common/google/ThumbnailManager.java @@ -322,8 +322,8 @@ public class ThumbnailManager extends BackgroundLoaderManager { if (data != null) { Options options = new Options(); options.inPreferredConfig = Config.ARGB_8888; - Bitmap bitmap = requestDecode(data.mData, - data.mOffset, data.mData.length - data.mOffset, options); + Bitmap bitmap = requestDecode(data.getData(), + data.getOffset(), data.getData().length - data.getOffset(), options); if (bitmap == null) { Log.w(TAG, "decode cached failed " + path); }