From eaaadcd3fb67e1ead01b0b0b0494905f6c385ddc Mon Sep 17 00:00:00 2001 From: Moez Bhatti Date: Sun, 3 Dec 2017 23:59:50 -0500 Subject: [PATCH] Clean up custom view constructors --- .../java/com/moez/QKSMS/presentation/view/AvatarView.kt | 5 +---- .../com/moez/QKSMS/presentation/view/GroupAvatarView.kt | 5 +---- .../java/com/moez/QKSMS/presentation/view/PreferenceView.kt | 3 +-- .../java/com/moez/QKSMS/presentation/view/TightTextView.kt | 6 +----- 4 files changed, 4 insertions(+), 15 deletions(-) diff --git a/qksms/src/main/java/com/moez/QKSMS/presentation/view/AvatarView.kt b/qksms/src/main/java/com/moez/QKSMS/presentation/view/AvatarView.kt index ff29d46a..45530f39 100644 --- a/qksms/src/main/java/com/moez/QKSMS/presentation/view/AvatarView.kt +++ b/qksms/src/main/java/com/moez/QKSMS/presentation/view/AvatarView.kt @@ -15,7 +15,7 @@ import io.reactivex.rxkotlin.plusAssign import kotlinx.android.synthetic.main.avatar_view.view.* import javax.inject.Inject -class AvatarView(context: Context, attrs: AttributeSet?, defStyleAttr: Int) : FrameLayout(context, attrs, defStyleAttr) { +class AvatarView @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null) : FrameLayout(context, attrs) { @Inject lateinit var themeManager: ThemeManager @@ -27,9 +27,6 @@ class AvatarView(context: Context, attrs: AttributeSet?, defStyleAttr: Int) : Fr updateView() } - constructor(context: Context, attrs: AttributeSet?) : this(context, attrs, 0) - constructor(context: Context) : this(context, null, 0) - init { View.inflate(context, R.layout.avatar_view, this) AppComponentManager.appComponent.inject(this) diff --git a/qksms/src/main/java/com/moez/QKSMS/presentation/view/GroupAvatarView.kt b/qksms/src/main/java/com/moez/QKSMS/presentation/view/GroupAvatarView.kt index 2a7acada..e4402bdc 100644 --- a/qksms/src/main/java/com/moez/QKSMS/presentation/view/GroupAvatarView.kt +++ b/qksms/src/main/java/com/moez/QKSMS/presentation/view/GroupAvatarView.kt @@ -9,7 +9,7 @@ import com.moez.QKSMS.data.model.Contact import io.realm.RealmList import kotlinx.android.synthetic.main.group_avatar_view.view.* -class GroupAvatarView(context: Context, attrs: AttributeSet?, defStyleAttr: Int) : ConstraintLayout(context, attrs, defStyleAttr) { +class GroupAvatarView @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null) : ConstraintLayout(context, attrs) { var contacts: RealmList = RealmList() set(value) { @@ -19,9 +19,6 @@ class GroupAvatarView(context: Context, attrs: AttributeSet?, defStyleAttr: Int) private val avatars by lazy { listOf(avatar1, avatar2, avatar3) } - constructor(context: Context, attrs: AttributeSet?) : this(context, attrs, 0) - constructor(context: Context) : this(context, null, 0) - init { View.inflate(context, R.layout.group_avatar_view, this) setBackgroundResource(R.drawable.circle) diff --git a/qksms/src/main/java/com/moez/QKSMS/presentation/view/PreferenceView.kt b/qksms/src/main/java/com/moez/QKSMS/presentation/view/PreferenceView.kt index 94af0fa0..dccdb3df 100644 --- a/qksms/src/main/java/com/moez/QKSMS/presentation/view/PreferenceView.kt +++ b/qksms/src/main/java/com/moez/QKSMS/presentation/view/PreferenceView.kt @@ -8,8 +8,7 @@ import com.moez.QKSMS.R import com.moez.QKSMS.common.util.extensions.setVisible import kotlinx.android.synthetic.main.preference_view.view.* -class PreferenceView @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null) - : LinearLayoutCompat(context, attrs) { +class PreferenceView @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null) : LinearLayoutCompat(context, attrs) { var title: String? = null set(value) { diff --git a/qksms/src/main/java/com/moez/QKSMS/presentation/view/TightTextView.kt b/qksms/src/main/java/com/moez/QKSMS/presentation/view/TightTextView.kt index f47f2f71..7bc1491f 100644 --- a/qksms/src/main/java/com/moez/QKSMS/presentation/view/TightTextView.kt +++ b/qksms/src/main/java/com/moez/QKSMS/presentation/view/TightTextView.kt @@ -4,11 +4,7 @@ import android.content.Context import android.util.AttributeSet import android.widget.TextView -class TightTextView @JvmOverloads constructor( - context: Context, - attrs: AttributeSet? = null, - defStyle: Int = 0) - : TextView(context, attrs, defStyle) { +class TightTextView @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null) : TextView(context, attrs) { override fun onMeasure(widthMeasureSpec: Int, heightMeasureSpec: Int) { super.onMeasure(widthMeasureSpec, heightMeasureSpec)