From 18491e3aabccaa59b25fe85f37511dc26998aa35 Mon Sep 17 00:00:00 2001 From: Jimmy Shih Date: Wed, 27 Jun 2012 10:42:10 -0700 Subject: [PATCH] When deleting tracks, use a non-UI thread. --- .../fragments/DeleteAllTrackDialogFragment.java | 9 +++++++-- .../fragments/DeleteOneMarkerDialogFragment.java | 10 ++++++++-- .../fragments/DeleteOneTrackDialogFragment.java | 11 ++++++++--- 3 files changed, 23 insertions(+), 7 deletions(-) diff --git a/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteAllTrackDialogFragment.java b/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteAllTrackDialogFragment.java index d847b6f95..819463108 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteAllTrackDialogFragment.java +++ b/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteAllTrackDialogFragment.java @@ -33,14 +33,19 @@ import android.support.v4.app.DialogFragment; public class DeleteAllTrackDialogFragment extends DialogFragment { public static final String DELETE_ALL_TRACK_DIALOG_TAG = "deleteAllTrackDialog"; - + @Override public Dialog onCreateDialog(Bundle savedInstanceState) { return DialogUtils.createConfirmationDialog(getActivity(), R.string.track_list_delete_all_confirm_message, new DialogInterface.OnClickListener() { @Override public void onClick(DialogInterface dialog, int which) { - MyTracksProviderUtils.Factory.get(getActivity()).deleteAllTracks(); + new Thread(new Runnable() { + @Override + public void run() { + MyTracksProviderUtils.Factory.get(getActivity()).deleteAllTracks(); + } + }).start(); } }); } diff --git a/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteOneMarkerDialogFragment.java b/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteOneMarkerDialogFragment.java index f21d25d74..3f196f35b 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteOneMarkerDialogFragment.java +++ b/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteOneMarkerDialogFragment.java @@ -56,8 +56,14 @@ public class DeleteOneMarkerDialogFragment extends DialogFragment { R.string.marker_delete_one_marker_confirm_message, new DialogInterface.OnClickListener() { @Override public void onClick(DialogInterface dialog, int which) { - MyTracksProviderUtils.Factory.get(getActivity()).deleteWaypoint( - getArguments().getLong(KEY_MARKER_ID), new DescriptionGeneratorImpl(getActivity())); + new Thread(new Runnable() { + @Override + public void run() { + MyTracksProviderUtils.Factory.get(getActivity()).deleteWaypoint( + getArguments().getLong(KEY_MARKER_ID), + new DescriptionGeneratorImpl(getActivity())); + } + }).start(); Intent intent = IntentUtils.newIntent(getActivity(), MarkerListActivity.class) .putExtra(MarkerListActivity.EXTRA_TRACK_ID, getArguments().getLong(KEY_TRACK_ID)); startActivity(intent); diff --git a/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteOneTrackDialogFragment.java b/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteOneTrackDialogFragment.java index a3d223f00..7dee67e80 100644 --- a/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteOneTrackDialogFragment.java +++ b/MyTracks/src/com/google/android/apps/mytracks/fragments/DeleteOneTrackDialogFragment.java @@ -79,13 +79,18 @@ public class DeleteOneTrackDialogFragment extends DialogFragment { R.string.track_detail_delete_confirm_message, new DialogInterface.OnClickListener() { @Override public void onClick(DialogInterface dialog, int which) { - long trackId = getArguments().getLong(KEY_TRACK_ID); - Context context = getActivity(); + final long trackId = getArguments().getLong(KEY_TRACK_ID); + final Context context = getActivity(); if (trackId == PreferencesUtils.getLong(context, R.string.recording_track_id_key)) { TrackRecordingServiceConnectionUtils.stop( context, caller.getTrackRecordingServiceConnection(), false); } - MyTracksProviderUtils.Factory.get(context).deleteTrack(trackId); + new Thread(new Runnable() { + @Override + public void run() { + MyTracksProviderUtils.Factory.get(context).deleteTrack(trackId); + } + }).start(); Intent intent = IntentUtils.newIntent(context, TrackListActivity.class); startActivity(intent); // Close the activity since its content can change after delete